* SOTBE-S3: make allied AI smarter
- they wont attack from poor defense anymore
- will only attack from hills where they have better defense
* SOTBE-S3: fix bad code in side AI
---------
Co-authored-by: Tahsin Jahin Khalid <5283677+knyghtmare@users.noreply.github.com>
if filtering type of damage in [damage_type] for both self and opponent when apply_to=both, it will create a recursion issue.
Idem for apply_to=attacker/defender when applied to opponent of owner of special.
* Death Squire optional advancement and damage nerf
The existing {ENABLE_DEATH_KNIGHT} macro allows Revenants to advance to Death Knights. The newly core-ed Death Squire also advances to Death Knight, but has no {ENABLE_DEATH_SQUIRE} macro.
I suggest adding a new {ENABLE_DEATH_SQUIRE} macro, while keeping the old {ENABLE_DEATH_KNIGHT} for backwards compatibility.
I also propose reducing the Death Squire's attack from 8x4 to 9x3, to make the Revenant a more competitive advancement.
Who's the current maintainer of SotA? Should {ENABLE_DEATH_SQUIRE} be used there, or should we continue using {ENABLE_DEATH_KNIGHT}?
Hejnewar, if you approve, what cost should the Death Squire be after this change?
* Reduce Death Squire damage from 8x4 to 9x3
* Update Skele_Death_Squire.cfg
Using four abilities instead of two means the C++ checking_tag
mechanism needs to handle multiple values, or needs to be supported
by recursion counting.
The branching test lets one level of recursion finish, and then tries
to go deeper. This tests for bugs where a recursion detection tool in
the engine gets its count reset when exiting one level of recursion.
There are no callers in mainline. The functions are not meant to be called directly at all – for each, there are wrapper functions that are intended to be called instead, which are still exposed.
This is a series of mostly minor changes to the encyclopedia:
- The Wesnoth Calendar has been renamed to Wesnothian Calendar.
- The calendar page now explains YW, BW, and AF. As far as I’m aware, these are not explained in-game despite their use.
- The unused file drakes.txt has been removed.
- The Great Ocean section now mentions the drakish name World Ocean and some drakish mythology from drakes.txt.
- The Great River page has had a section on the Ford of Abez added. This is partly copied from the wiki (section copied appears to have been added by Esr, 8 October 2008)
- Morogor has had Mount Krogor been added as a notable land feature in the encyclopedia, taken from drakes.txt.
- The Green Isle section has been greatly expanded to include details on settlements and terrain. I thought it would be useful to have this, as the Green Isle is the original home of the Wesnothians and a major part of the setting of TRoW.
- Added a short sentence on the Old Continent being the original homeland of orcs and humans.
- Westin has been added to the Wesnoth page.
- The Isle of Alduin has been added to the Wesnoth page.
- A section on the Green Swamp has been added to the Wesnoth page. This is copied from the wiki. (section copied appears to have been added by Octalot, 21 September 2021)
- The section on notable cities for the Southwestern Elves has been removed due to the lack of known cities in the region.
- The Northlands description has been modified.
- The local orcish names for the Heart Mountains are now mentioned on the page for the Heart Mountains.
- Tirigaz and Jotha now have short one-sentence descriptions.
- The Desert of Death has been added to the far north section.
- Various land features from the far north have had short descriptions added.
- A section on the Far South has been added. It does not expand much on current lore except for some mentions of monsters. It only includes the Mountains of Peril, Sandy Wastes, and the Black Forest (moved from Southwestern Elven Lands and slightly modified) and is intenced to be very vague to allow UMC creators to imagine details of the Far South.
