[SOTBE] S3: make allied AI smarter (#9239)

* SOTBE-S3: make allied AI smarter

- they wont attack from poor defense anymore
- will only attack from hills where they have better defense

* SOTBE-S3: fix bad code in side AI

---------

Co-authored-by: Tahsin Jahin Khalid <5283677+knyghtmare@users.noreply.github.com>

data/campaigns/Son_Of_The_Black_Eye/scenarios/03_Toward_Mountains_of_Haag.cfg

@@ -52,6 +52,28 @@
                 carryover_percentage=40
             [/gold_carryover]
         [/objectives]
+
+        [micro_ai]
+            side=3
+            ai_type=simple_attack
+            action=add
+
+            ca_score=110000
+
+            # take the side units into consideration
+            [filter]
+                side=3
+                canrecruit=no
+                [filter_location]
+                    x=1-38
+                    y=14-22
+                    terrain=M*,H*
+                [/filter_location]
+            [/filter]
+            [filter_second]
+                side=2
+            [/filter_second]
+        [/micro_ai]
     [/event]
 
     [item]
@@ -127,6 +149,32 @@
         team_name=Kapoue
         user_team_name=_ "Kapou’e"
         no_leader=yes
+
+        [ai]
+            # make allied units only attack from hills/mountains
+            # and not from flat (where they have poor defence)
+            [aspect]
+                id=attacks
+                [facet]
+                    invalidate_on_gamestate_change=yes
+                    [filter_own]
+                        canrecruit=no
+                        [filter_location]
+                            x=1-38
+                            y=14-22
+                            terrain=M*,H*
+                        [/filter_location]
+                    [/filter_own]
+                    [filter_enemy]
+                        side=2
+                        [filter_location]
+                            x=1-38
+                            y=14-22
+                        [/filter_location]
+                    [/filter_enemy]
+                [/facet]
+            [/aspect]
+        [/ai]
     [/side]
 
     {SOTBE_TRACK {JOURNEY_03_NEW} }