This specifically manifested with the new minimap rendering code. Since we were creating a new temp texture onto which to draw the minimap before drawing it to the window texture, the formerly set clip rect was incorrect when the old viewport was restored:
For a minimap texture of 738 x 912:
Clip before changing target: `[0,0|330,200]`
Clip after changing target: `[0,0|738,912]` (covers whole of new target)
Clip after old target is restored: `[476,55|330,200]`
It's unclear where the extra x,y values came from, but I suspect it's some issue with SDL's internal viewport handling.
This builds on the work in cca82c4c3a. There, I delegated the ctors to the `value` strict via a forwarding ctor, but it honestly seems better to just remove the value struct entirely and just have class members. There isn't anything that relies on `value` as a distinct type anymore anyway.
The change in minimap.cpp is to deal with build errors that suddenly emerged with this change.
This is a series of mostly minor changes to the encyclopedia:
- The Wesnoth Calendar has been renamed to Wesnothian Calendar.
- The calendar page now explains YW, BW, and AF. As far as I’m aware, these are not explained in-game despite their use.
- The unused file drakes.txt has been removed.
- The Great Ocean section now mentions the drakish name World Ocean and some drakish mythology from drakes.txt.
- The Great River page has had a section on the Ford of Abez added. This is partly copied from the wiki (section copied appears to have been added by Esr, 8 October 2008)
- Morogor has had Mount Krogor been added as a notable land feature in the encyclopedia, taken from drakes.txt.
- The Green Isle section has been greatly expanded to include details on settlements and terrain. I thought it would be useful to have this, as the Green Isle is the original home of the Wesnothians and a major part of the setting of TRoW.
- Added a short sentence on the Old Continent being the original homeland of orcs and humans.
- Westin has been added to the Wesnoth page.
- The Isle of Alduin has been added to the Wesnoth page.
- A section on the Green Swamp has been added to the Wesnoth page. This is copied from the wiki. (section copied appears to have been added by Octalot, 21 September 2021)
- The section on notable cities for the Southwestern Elves has been removed due to the lack of known cities in the region.
- The Northlands description has been modified.
- The local orcish names for the Heart Mountains are now mentioned on the page for the Heart Mountains.
- Tirigaz and Jotha now have short one-sentence descriptions.
- The Desert of Death has been added to the far north section.
- Various land features from the far north have had short descriptions added.
- A section on the Far South has been added. It does not expand much on current lore except for some mentions of monsters. It only includes the Mountains of Peril, Sandy Wastes, and the Black Forest (moved from Southwestern Elven Lands and slightly modified) and is intenced to be very vague to allow UMC creators to imagine details of the Far South.
Ensure that there is no coroutine yield between confirmation of login
and update of player_connections_. Otherwise another login under same
name could succeed if it happened before handle_player() which resulted
in an assert later.
Makes all the cache management functions local to the cache class. There's no reason
to publicly expose it through locator given that the actual cache objects which that
API needs to function are local to this translation unit anyway.
This also cleans up the cache implementation in order to take advantage of the switch
from a vector to map awhile back. `copy_from_cache` was removed in favor of bounds-
checked access.
Add two maintenance scripts, to help transition from external copyright tracking to putting all info in the file metadata.
- One script to read read copyrights.csv and write data to Exif tags.
- One script to read the image Exif tags, and write to a CSV
This comment existed when the unit was still in EI campaign. It's been moved to core ages ago and yet, the comment, now no longer relevant outside of EI still persisted...
