* bugfixes for unit type editor
1. accept space in unit type id
2. don't write translated string to generated wml
3. add textdomain at the top of the generated file
4. fix bad key in generated attack block
In "Ill Humors", 2 spawn regions for aswaldan herbs overlap, which can result in both spawning on the same hex without any special visual indicator.
Credit to PointMeAtTheDawn.
Instead of the aliasing hack that the oasis terrain used to use, have
the help topic generator reuse the editor_default_base as a hint that it
should be included in that section.
The terrain_type class gets a new boolean method, and more documentation.
There's a couple of refactors to use the new method in old code too.
* Elvish Avenger - decreased ranged attack from 11×4 to 10×4, decreased cost from 66 to 60
* Elvish Sharpshooter - decreased ranged attack from 12×5 to 10×5, decreased cost from 62 to 55
* Elvish Shyde - decreased ranged slow attack from 8×3 to 7×3, decreased ranged magical attack from 14×3 to 10×3, decreased cost from 69 to 58
* Elvish Enchantress - decreased ranged slow attack from 7×4 to 6×4, decreased ranged magical attack from 13×4 to 11×4, decreased cost from 70 to 62, decreased XP requirement from 198 to 180
* Elvish Sylph - decreased ranged magical attack from 16×5 to 13×5, decreased cost from 161 to 135
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use the attributes from the file that was modified most recently.
Credentials: move if the credentials file doesn't exist.
Fixes#7936
* Moved the Show All Languages checkbox from the main body to the
bottom left of the dialog to save space and make it more obviously
connected to the listbox.
* Changed the Show All Languages checkbox label to reduce the word
count a tiny bit.
* Added text regarding translation percentages representing core
textdomains only.
* Added a link to gettext.wesnoth.org.
In 1.19 since 82499d0785, this will apply a
max_value of 15, which will also be the combined value.
The same test has surprising result on 1.18, the max_value attributes get added
together for a total max_value of 47, but the values don't, so the single
highest value of 30 is used.
(the corresponding 1.18 commit is 9632febdb5)
These tests clarify what "cumulative" means for non-leadership abilites,
which since Wesnoth 1.1.3 doesn't seem to fit the English word.
For cumulative abilities, if the base value from the unit is higher that
the ability's value, then the base value is used instead. In the case of
a Skeleton with 40% base resistance, "cumulative=yes" is equivalent to
"value,cumulative=40,no".
In all of these cases, a single ability's value is used; "cumulative"
doesn't mean that the values from multiple abilities interact.
This is all when using value=, not when using add= or sub=.
(cherry picked from commit 9b2016a4af)
I don't know if a bow attack is added in the objects but in any case I prefer to transfer the special oar in abilities in the same way as for the amulet
If two [damage_type]alternative_type= are used with two different types, the chosen type displayed in the pre-combat window will be the one to which the opponent is most vulnerable. That type will then also be used in the attack if it is stronger than the original/replacement_type.
In the sidebar (report) all alternative_types are displayed.
---------
Co-authored-by: Gunter Labes <soliton@wesnoth.org>
max_value is used to limit the increase in resistance with the "resistance" capability, but there was no equivalent for its reduction.
To be able to add min_value without redoing the "resistance" checking for the umpteenth time, I prefer to modify effect:: so that the checking of these two attributes is done at the same time as the other numerical attributes and keep the door open to a possible generalization of the proceed
