* Run auto-format
* Avoid broad exception handling.
* Remove unnecessary reference to self.
* Tidy imports.
* Remove redundant brackets.
* Narrow exception handling on unrecognised locale.
* Simplify command construction.
* Simplify command construction.
* Avoid shadowing.
* Spelling corrections.
* Reviewed argument parsing:
* Average user probably won't know that ISO 15897 refers to POSIX locale names.
* 'default' probably isn't an accurate description of the entered locale so change to 'user'.
* Remove the hard-coded usage text - the default usage string from the arguments list is sufficient.
* Use title case for menus as per UI style guide.
* Avoid abbreviation for UI text and add translation notes.
* Reviewed text for the tabs representing options for each tool.
Also removed forced new-lines, which I think are unnecessary.
* Consolidate strings to allow for translation sharing.
* Add translation note
* Use title case for titles.
* End sentences with full-stop.
* Title case for titles, translation note, full-stop.
* Abbreviated error message sufficient - consistent with other error messages.
* Clarify file vs file name.
* The translations directory is referenced regardless of whether the user has specified a locale or not, so put the check for the translation directory outside the user-input condition.
* The function isn't just for the user-specified locale, it steps back to the system locale if no user-input is given for the language.
* Clarified the reason for the code duplication in the set-up for system locale.
* Use en_US for commentary.
* Treat 'normal mode' as just one string.
* Replace empty place-holder with numbered indexes to work around gettext limitation.
* Correct typography.
super="units/unit_type/abilities/~generic~" isn't quite accurate since there are a lot of keys/tags in there that may not mean anything for dummy abilities. Probably doesn't hurt to expect they work like in mainline though.
Levels have been normalized a little to scale smoothly. This combines
the old 1.25x and 1.5x zoom levels into a new ~1.41x zoom level.
Others are more-or-less unchanged, other than modification for the
requirement that scales are divisible by 4.
Also changed zoom level specification to direct integer sizes rather
than multiplication factors, so they can be specified accurately.
It has always been the case that they were required to be multiples
of four. This was just violated at some point.
This fixes problems with overlapping fog textures at some zoom
levels, and may also prevent some other rendering glitches.
* update falcon and raven races to not get names
To conform with other monster units
* units: remove a redundant line of code
from races falcon and raven definitions
At the suggestion of @stevecotton, I propose a special 'replacement_type' and 'alternative_type' attribute capable of modifying the type of attack used when the conditions are met.
Also make Holy water combine arcane damage with native type of weapon
Like holy water imbued ordinary weapon, it's seem logic what arcane damage dominant what if more efficient what original type(water can't altered pierce or blading of spear or sword)
The code keeps record of the previous hp to prevent unit:transform form changing it. But it reads it before the object was added which prevented the object from increasing the units hp.
a free random training on easier difficulties should only be given in the first scenario. (Otherwise they'll accumulate to 5 free trainings at scenario 5.)
Fix https://github.com/wesnoth/wesnoth/issues/7923 .when we want to detect an ability with value=0-20 and an ability with add=15 is present, this is detected because the system assigns a value of 0 when 'value' is not present, and so the system matches abilities that do not use 'value' or even no numerical value at all. it is therefore necessary to decide that the absence of an attribute is a non-correspondence to the criteria.
