0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

wmltools GUI review (#7971)

Browse source 
* Run auto-format

* Avoid broad exception handling.

* Remove unnecessary reference to self.

* Tidy imports.

* Remove redundant brackets.

* Narrow exception handling on unrecognised locale.

* Simplify command construction.

* Simplify command construction.

* Avoid shadowing.

* Spelling corrections.

* Reviewed argument parsing:
* Average user probably won't know that ISO 15897 refers to POSIX locale names.
* 'default' probably isn't an accurate description of the entered locale so change to 'user'.
* Remove the hard-coded usage text - the default usage string from the arguments list is sufficient.

* Use title case for menus as per UI style guide.

* Avoid abbreviation for UI text and add translation notes.

* Reviewed text for the tabs representing options for each tool.

Also removed forced new-lines, which I think are unnecessary.

* Consolidate strings to allow for translation sharing.

* Add translation note

* Use title case for titles.

* End sentences with full-stop.

* Title case for titles, translation note, full-stop.

* Abbreviated error message sufficient - consistent with other error messages.

* Clarify file vs file name.

* The translations directory is referenced regardless of whether the user has specified a locale or not, so put the check for the translation directory outside the user-input condition.

* The function isn't just for the user-specified locale, it steps back to the system locale if no user-input is given for the language.

* Clarified the reason for the code duplication in the set-up for system locale.

* Use en_US for commentary.

* Treat 'normal mode' as just one string.

* Replace empty place-holder with numbered indexes to work around gettext limitation.

* Correct typography.
This commit is contained in:
Wedge009 2023-11-11 04:55:22 +11:00 • committed by GitHub
parent cdd05db833
commit 559aacbf65
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 900 additions and 756 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1656
data/tools/GUI.pyw
View file

File diff suppressed because it is too large Load diff