* Duplicated text
* Favour generic term 'file manager' over Microsoft terminology.
* Clarify language code use.
* Replace inconsistent spelling of 'add-on'.
- The t_string type is now a schema built-in type and no longer attempts a regex match.
- You can also specify that non-t_string types may be optionally-translatable; this case supports a regex match on the string (but note that the translation mark is not part of the match).
- Error messages involving keys with very large values ( > 128 characters) will now truncate the value.
- To account for occasional cases where the schema is intentionally violated, the --validate command-line option now automatically defines the SCHEMA_VALIDATION preprocessor define.
A key validates as type t_string if one of the following is true:
- The key is not present
- The key has at least one segment with a translation mark
- The key is blank (an empty string)
Any type other than t_string is not allowed to be translatable by default, unless you specify allow_translatable=yes in the [type] tag.
An optionally-translatable string could also be defined as a union of t_string and some other type.
As the disengaged state is part-way between the "partial" and "moved" states,
the orb has parts in each color. On the minimap these units are shown in the
partial color (which is also the color that would be used before this change).
This will match the mounted Quenoth units' "disengage" skill, when they
can still move but can't attack. It should also trigger for some UMC abilities
that get extra moves after a character attacks.
During testing, I found that TSG allows some of the bandits to attack on the
first turn of the bandit branch. There's no gameplay change there, but the orbs
make it much clearer that some units can still attack.
I think there are already too many preferences for orbs, so reused the existing
settings for the colors. A new "show disengaged orb" preference is added, which
when disabled shows the old partial orb instead.
Update the orb and ellipse sections of doc/manual/.
Notes about how I created the new orb image:
* create a color range to_ellipse_red with rgb=FF0000,FF0000,000000,FF0000
* wesnoth --render-image 'misc/orb.png~RC(magenta>to_ellipse_red)' images/misc/orb-ellipse-red.png
* open the orb.png and orb-ellipse-red.png images as layers in Gimp, add a layer mask to both of them
* use the layer mask to get each pixel from exactly one of the layers
https://github.com/wesnoth/wesnoth/pull/5481 removed the check that made
wmllint: display on and wmllint: display off necessary.
This PR removes now redundant wmllint comments.
find ./data/ -name '*.cfg' -exec sed -ri '/^ *# *wmllint *:? *display *(on|off) *$/d; s/ *# *wmllint *:? *display *(on|off) *$//' '{}' ';'
The image added here is a grass background to draw units on via Image Path
Functions. For the documentation, a square image looks better than a hexagon
that has black borders.
Instead of using the allied orb during their turn, the unmoved, moved and
partial orbs are shown. The player's own units will be shown with the moved orb
during the ally's turn, which matches the previous behavior. This is intended for
co-operative MP campaigns, where it will make it easier for players to discuss
possible moves. The UX is also visible in SP scenarios with allied sides, HttT's
first scenario is an easy place to see what it does.
If another status is added to the orb_status enum, this code is likely to
support it with no changes needed for the parts in this commit. For example,
issue #5155's proposed orb_status::disengaged has been tested with this.
Updated the documentation about orb colors. In these docs I've moved all of
the images to a single line above the bullet-pointed list, as otherwise the
layout looked bad once a line wrapped - the first line appeared
horizontally-aligned with the center of the image, the second started under the
image.
Added documentation about the delay in multiplayer games, as the purpose of this
orb-coloring feature is to assist discussion in multiplayer games.
This command and the documentation provided by ":help droid" were updated
in efd808ea84, but we missed that this command
is also documented in the help browser's (Commands, General Commands) page.
The docs here are more verbose than in ":help", so the text is newly written
instead of being copied from the existing location.
This removes some subtle todo text that didn't have a explicit "TODO" in
the text, although it was tracked as part of #4280. The discussion ended
without a conclusion about whether those statements were correct for all
mainline campaigns.
The existing text in this help topic represented paragraphs by having
translatable strings that start with whitespace (two newlines), as described in
issue #4480. As this commit already needed to change all but two of the
paragraphs, I've switched them all to using non-translatable paragraph
separators. Even though the whole save-loading topic is new in 1.15, it has
already been translated in some languages, and making this consistent means two
unnecessary fuzzy strings. Sorry to the translators, but I think it's
worthwhile.
This simply removes the todo. Conclusions from trying to add a link:
* Any link should be to something more specific than the "Mainline Campaigns
Feedback" forum, which is a set of sub-forums that may or may not have any
recent and-or useful information for the particular scenario that the user is
having trouble with. For replays in particular, some (most?) don't have replays
that have been uploaded to the feedback threads, and given Wesnoth's
incompatibility with previous stable branches the replays that are there might
not be usable.
*`The forums are English, so might want a note in all the non-English
translations that isn't in the English text.
... with the idea that these pages will either be improved or hidden again
before 1.16.0. I think the terrain-editor part will be good enough to stay in
1.16, but the scenario editor part needs to be updated by someone familiar with
it.
This puts the two tips that are currently in https://wiki.wesnoth.org/MapEditor
in to the in-game text.
* Draft 'Why did I lose?' help topic
* fixup! Draft 'Why did I lose?' help topic
Implement @beetlenaut's suggestions
* help: Change to title case for consistency with the rest of the section
* help: Explain the term 'foreknowledge'
[ci skip]
At no point is "generated" checked for as value of that key (the only valid value is "yes").
"generated" is a valid value for sort_topics, however. As for whether we want sorting or not
for Eras, I don't think so. The era order as displayed seems logical enough since it groups
each era and Age of Heroes variant together.
(cherry picked from commit 6b20ccdb62)
The error message was, upon opening the page:
```
Parse error when parsing help text: 'Error when parsing help markup as WML: 'Unexpected characters after variable name (expected , or =)
at <unknown>:2''
```
The <bold> tag in question can be seen on old_master_20181015 here:
71a6daf961/data/core/help.cfg (L199)
I had disabled this when I redid the End Credits screen in GUI2 (476027f) since (IIRC)
I didn't want to figure out about parsing the new config-based credits storage. The topic
remained in Help, empty. We've decided the new End Credits screen is a better method for
viewing the credits anyway, so I'm now removing the topic.
