Overall statistics (only for files with a smaller recompressed size):
Original size: 16720 KiB on 404 files
Optimized size: 15237 KiB
Total saving: 1482 KiB = 8% decrease
The second part of the narrator messages were not translated, not sure
why. This patch is a work-around not a proper fix. Once 1.10 is in its
own branch a proper fix can be committed. That fix will change
translatable strings, and is the reason for a work-around in the trunk.
Fixes bug #19316.
(fix for bug #19188)
This causes statistics, scenario overwiew and turn dialog to show the
save_id instead of current_player. This doesn't break stringfreeze
since save_id isn't translatable. Any bug report complaints about
these dialogs no longer showing player name's translation shall be
rejected. >:|
Uninvasive workaround. Adding a dummy side would require many changes
and complicate the wml code. I've been using save_id=human player in
my addon campaign which involves leader change as well sine ever
without anyone complaining so hopefully...
since they break compatibility.
This reverts
2011-12-16T01:24:54Z!anonymissimus@arcor.de
2011-12-16T04:06:47Z!Majora700@gmail.com
2011-12-16T04:08:22Z!Majora700@gmail.com
2011-12-16T04:14:58Z!Majora700@gmail.com
2011-12-16T20:13:27Z!anonymissimus@arcor.de
2011-12-16T20:14:08Z!anonymissimus@arcor.de
2011-12-16T20:48:39Z!Majora700@gmail.com
2011-12-17T09:46:29Z!Majora700@gmail.com
1. The internal type is a std::string, the lua getters/setters should
reflect that like all the existing ones already do instead of making
implicit conversions.
2. It doesn't make sense to convert the already translated string
into a t_string again upon getting it.
3. The setter in team.cpp you added is redundant.
4. The attribute is apparently not really meant to be modified
by lua or wml so a tag is no good idea.
(not commiting any files that were reported as broken, there are many!)
Original size: 130846 KiB on 10530 files
Optimized size: 127520 KiB
Total saving: 3325 KiB = 2% decrease
NOTE: Extremely many files received (smaller) changes but due to the
extremely large amount of changes I am not 100% sure that this
conversion is correct. This is the output of
utils/png_format_check.sh:
RGBA: 10247 RGB: 10 Gray+A: 256 Gray: 0 Index+A: 0 Index: 0 Other: 0
Overall statistics (only for files with a smaller recompressed size):
Original size: 128949 KiB on 9778 files
Optimized size: 125813 KiB
Total saving: 3135 KiB = 2% decrease
