Commit graph

29838 commits

Author SHA1 Message Date
Dalas121
dbed8aa4e9
EI S04b: add objective note regarding herb distribution.
S04b's alternative objective involves collecting herbs that semi-randomly spawn around the map, hidden under fog. Herbs spawn in all directions, but the map layout and scenario design can lead players to expect herbs to all be in the east. This objective note clarifies herb placement.

https://forums.wesnoth.org/viewtopic.php?t=57915
2024-05-24 20:10:21 -05:00
Jonathan-Kelly
b3a8d02774
WoF: fix Lua type error with cast to number (#8773)
Lua was getting this variable without being told it is a number rather than a string. On some systems it is interpreted as a string which breaks this monster spawner code and throws Lua error messages onto the player's screen.
2024-05-24 13:30:01 -04:00
Jonathan-Kelly
a8194ee764
WoF S11: fix easy win AI exploit (#8774)
Fixes #8759
2024-05-24 13:12:19 -04:00
Subhraman Sarkar
9b38089db0
Story screen redesign (#8510) 2024-05-24 19:29:46 +05:30
Dalas121
2591899723
EI S09: add label to gold pile
EI's S09 has a small pile of gold some distance off the main path, visible through the shroud.

Without a label, players may over-commit units/upkeep to getting the gold without realizing it's only a small amount, and possibly worth skipping.
2024-05-22 17:21:12 -05:00
Dalas121
f539e70706
EI: remove random traits from S16 townsfolk (#8896)
Units with traits may sometimes have quick and may sometimes not have quick. This causes civilians to randomly block certain castle hexes that the player can use to recruit.

Remove traits to prevent this random blocking. Increase MP 4->5 to prevent 2 castle hexes from always being blocked.
2024-05-22 09:54:45 -05:00
Dalas121
7fde3f5ab6
EI: simplify S16 achievement (#8897)
The current S16 achievement requires that the player don't recall any units or have any items.

Some items are undroppable, which can make this achievement impossible if you give one to a loyal auto-recalled unit early in the campaign.

This PR alters the achievement to only care about droppable items.
2024-05-22 09:51:02 -05:00
Earth-Cake
b772c241e2 liberty generals name achievement fix for dawn 2024-05-21 23:21:37 -05:00
Dalas121
da47ecf25d
EI: Prevent Dacyn from using the Plague Staff (#8892)
Fixes #8885
2024-05-21 11:14:44 -05:00
Wedge009
73cc52b506 wmlxgettext: Remove unused WmlDefineState class disabled-as-comment/string and resolve #8867 (Python 3.12 highlighting invalid escape sequence in string with SyntaxError). 2024-05-21 14:55:09 +02:00
newfrenchy83
3d097f2950 add [filter_wml] to filter abilities like [experimental_filter_ability], [experimental_filter_ability_active] or [overwrite][experimental_filter_specials]
adding a sub-filter should make it possible to take into account the sub_tags of the abilities in the checking
2024-05-21 14:54:44 +02:00
Toom
9e08a78bf5
Reject [terrain] with unknown terrain type 2024-05-21 11:34:41 +02:00
Subhraman Sarkar
92d66554dd
UI : About dialog (#8803)
* Redesigned the version dialog to serve as a general purpose About dialog.

* Credits button removed from title screen

* Moved community dialog contents to about dialog as new tab

Co-Authored-By: Pentarctagon

* Bugfixes to the tab_container widget

* Success indication mechanism on copy buttons
2024-05-21 09:43:32 +05:30
Celtic Minstrel
8d5ca809f4 [Lua] Update obsolete location functions in ai_helper to return a proper named tuple and access locations as x,y instead of [1],[2] 2024-05-19 12:54:35 -04:00
Celtic Minstrel
058d0502e5 [Lua] Update obsolete use of [1],[2] to refer to locations, and simplify some code by leveraging the fact that any object with x,y qualifies as a location; also use moves_left for reachmaps instead of [3] 2024-05-19 12:54:35 -04:00
Celtic Minstrel
f5c4f2e841 [Lua] Update obsolete usage of [1],[2] to refer to a tag's name and contents 2024-05-19 12:54:35 -04:00
Celtic Minstrel
0f6fe67477 [Lua] Use wml.tag to construct WML tables 2024-05-19 12:54:35 -04:00
Wedge009
ef13ea4565 Tutorial S2: Only trigger comment about the 'Dumbo' orc if it is still alive after the attack.
Addresses final point in #5544.
2024-05-19 10:54:16 +10:00
Tahsin Jahin Khalid
c57251ef34
Units: fix white horse HP and XP stats (#8814)
As pointed out by Celtic Minstrel and hejnewar
2024-05-15 16:54:53 +06:00
Subhraman Sarkar
336226d198
bugfixes for unit type editor (#8846)
* bugfixes for unit type editor

1. accept space in unit type id
2. don't write translated string to generated wml
3. add textdomain at the top of the generated file
4. fix bad key in generated attack block
2024-05-12 14:41:28 +05:30
doofus-01
62b9ddaa47
Wyvern graphics work (#8854)
* Wyvern portrait and animations
2024-05-11 19:43:45 -07:00
Dalas121
3e4e805b08
EI S04b: Prevent aswaldan herbs from stacking (#8859)
In "Ill Humors", 2 spawn regions for aswaldan herbs overlap, which can result in both spawning on the same hex without any special visual indicator.

Credit to PointMeAtTheDawn.
2024-05-07 17:52:49 -05:00
Subhraman Sarkar
03a46f1d7c
Combobox, Tab Container and Editability in Text Box (#8390)
* new combobox and tab container widgets
* ediability in text box via the editable key
2024-05-06 09:56:44 +05:30
Dalas121
9d3e2e82a3
EI: s10 fix owaec being able to enter the sanctuary (#8850)
Fixes #8843
2024-05-05 09:13:54 -05:00
Elvish_Hunter
d8b1064c32 Added Fire Wisp unit
The sprites were made by fmunoz, who agreed by forum PM to re-license them under the CC-BY-SA license.
2024-05-05 11:06:47 +02:00
Earth-Cake
30a1a1e7be
EI - changed undead variants from 'spider' to 'ant' (#8849) 2024-05-04 20:49:09 -05:00
Nils Kneuper
f43e977263 updated Norwegian translation credits 2024-05-04 16:02:28 +02:00
Steve Cotton
91fab6939a EI: Add po hints about the plague staff
(cherry picked from commit 8c83da78e2)
2024-05-04 09:44:39 +10:00
Wedge009
7987b863dd Editor Help: grammar correction. Resolves #8615.
[ci skip]
2024-05-03 13:40:38 +02:00
Steve Cotton
3fba8897d8 Help shows terrain types in the section for their default_base
Instead of the aliasing hack that the oasis terrain used to use, have
the help topic generator reuse the editor_default_base as a hint that it
should be included in that section.

The terrain_type class gets a new boolean method, and more documentation.
There's a couple of refactors to use the new method in old code too.
2024-05-01 12:33:01 +02:00
nemaara
ff040853c2 DiD S3: do not allow exp grinding and buff puzzle exp 2024-04-29 18:37:56 -07:00
doofus-01
0b281f64e0
1.19 - Brush up minor characters (#8764)
* HttT sea orc update

* TSG eyestalk portrait

* TRoW vampire lady portrait
2024-04-28 18:53:11 -07:00
Tahsin Jahin Khalid
4fb9f51db7 utils.cfg: typo fix in FULL HEAL macro 2024-04-28 20:45:27 +02:00
Jonathan-Kelly
890caf513c Add submerge to oasis terrain
Follow up to #8783 this makes a unit on an oasis tile visibly sink slightly into its waters, just like with ford terrain.
2024-04-28 11:31:45 +02:00
ForestDragon
72d2f4588b
Nerf Elvish Shyde/Enchantress/Sylph/Sharpshooter/Avenger
* Elvish Avenger - decreased ranged attack from 11×4 to 10×4, decreased cost from 66 to 60
* Elvish Sharpshooter - decreased ranged attack from 12×5 to 10×5, decreased cost from 62 to 55
* Elvish Shyde - decreased ranged slow attack from 8×3 to 7×3, decreased ranged magical attack from 14×3 to 10×3, decreased cost from 69 to 58
* Elvish Enchantress - decreased ranged slow attack from 7×4 to 6×4, decreased ranged magical attack from 13×4 to 11×4, decreased cost from 70 to 62, decreased XP requirement from 198 to 180
* Elvish Sylph - decreased ranged magical attack from 16×5 to 13×5, decreased cost from 161 to 135
2024-04-27 13:56:50 +02:00
Tahsin Jahin Khalid
60a620ba76
HttT S16: fix li'sar missing her unrenamable=yes (#8782)
* S16: fix li'sar missing her unrenamable=yes

* S16: add one more instance of unrenamable=yes
2024-04-27 12:53:23 +06:00
pentarctagon
6d12b17d95 add tooltip. 2024-04-27 00:55:24 -05:00
Pentarctagon
b3f6f80010
Add a button to the build info dialog to rerun the migrator. (#8791)
Add-ons: checks for any that exist in the chosen other version but not in the current version.
Preferences: adds attributes that don't exist from the chosen other version's preferences that aren't in the current version's preferences. for attributes that exist in both, use the attributes from the file that was modified most recently.
Credentials: move if the credentials file doesn't exist.

Fixes #7936
2024-04-27 00:45:41 -05:00
Gunter Labes
c2d179f75e
Missed one pair of quotes 2024-04-26 23:39:02 +02:00
Gunter Labes
2099c23e54
Remove unnecessary workaround 2024-04-26 23:33:19 +02:00
Jonathan-Kelly
b3802f44ea SoF S7: fewer and slower enemy outriders
This is to counteract the swifter and deadlier Elvish Outrider after the 1.18 core unit balance changes.
2024-04-26 16:44:24 +02:00
newfrenchy83
71a6e465e0 using number of amla to condition increase of experience to level change
Like this, when Youth remain level 1 in EASY mode, max_experience remain to 16
2024-04-24 20:01:37 +02:00
newfrenchy83
8554e9844e add formula in Quenoth Youth advancements 2024-04-24 20:01:37 +02:00
Iris Morelle
00cdaaa2d6 gui/language_selection: Additional UI work for clarity
* Moved the Show All Languages checkbox from the main body to the
   bottom left of the dialog to save space and make it more obviously
   connected to the listbox.

 * Changed the Show All Languages checkbox label to reduce the word
   count a tiny bit.

 * Added text regarding translation percentages representing core
   textdomains only.

 * Added a link to gettext.wesnoth.org.
2024-04-24 09:45:13 -04:00
Steve Cotton
ac12be8342 Unit test cumulative resistance with a max_value
In 1.19 since 82499d0785, this will apply a
max_value of 15, which will also be the combined value.

The same test has surprising result on 1.18, the max_value attributes get added
together for a total max_value of 47, but the values don't, so the single
highest value of 30 is used.

(the corresponding 1.18 commit is 9632febdb5)
2024-04-24 14:52:22 +02:00
Steve Cotton
3fb8a91bc6 Unit test cumulative resistance with a base value
These tests clarify what "cumulative" means for non-leadership abilites,
which since Wesnoth 1.1.3 doesn't seem to fit the English word.

For cumulative abilities, if the base value from the unit is higher that
the ability's value, then the base value is used instead. In the case of
a Skeleton with 40% base resistance, "cumulative=yes" is equivalent to
"value,cumulative=40,no".

In all of these cases, a single ability's value is used; "cumulative"
doesn't mean that the values from multiple abilities interact.

This is all when using value=, not when using add= or sub=.

(cherry picked from commit 9b2016a4af)
2024-04-24 14:52:22 +02:00
newfrenchy83
51e568ff1c Convert CRYSTAL_QUIVER to ability for consistency and move overlay and halo to abilities
I don't know if a bow  attack is added in the objects but in any case I prefer to transfer the special oar in abilities in the same way as for the amulet
2024-04-24 10:41:09 +02:00
newfrenchy83
929d62e7f6 Fix EI: Plague Staff Doesn't Gain Arcane Damage When Equipped After Holy Amulet
Fix https://github.com/wesnoth/wesnoth/issues/8745 in using ability instead of specials
2024-04-24 10:41:09 +02:00
Jonathan-Kelly
707c4e6ed2 Add shallow water to oasis like ford terrain
Resolves  #8753
2024-04-24 04:39:06 +02:00
newfrenchy83
c7080e0ecc
Select alternative damage type based on opponent resistances
If two [damage_type]alternative_type= are used with two different types, the chosen type displayed in the pre-combat window will be the one to which the opponent is most vulnerable. That type will then also be used in the attack if it is stronger than the original/replacement_type.

In the sidebar (report) all alternative_types are displayed.

---------

Co-authored-by: Gunter Labes <soliton@wesnoth.org>
2024-04-21 13:05:03 +02:00