The logic is supposed to be, if (x,y) == (prev_x, prev_y), then
skip the "find_vacant_hex" function because we don't have to move.
Instead we effectively had, if (x == prev_x OR y == prev_y), then
we can skip the check.
This revises a commit
72f138c544
in the hopes to fix a bug reported here:
http://forums.wesnoth.org/viewtopic.php?f=4&t=41084
Fixes the following wmllint warning:
> "../../data/campaigns/Under_the_Burning_Suns/scenarios/04_Descending_into_Darkness.cfg", line 346: [remove_shroud] without "side" attribute is now applied to all sides
Modified the lua script for wml_action.move_unit. In the
loop to check for vacant tile, if the current location
is equal to the previous location we don't look for a
vacant tile since our location is free (where we are).
Conflicts:
changelog
This label didn't seem to contribute much of anything, and it
caused big problems for translators because we don't have
dynamically resizing text labels, and that would have provoked
intractable layout problems anyways, so we decide just to remove
it and rely on the tooltips / media controller icons on the buttons
to tell the user what is going on.
See also discussion here:
http://forums.wesnoth.org/viewtopic.php?f=9&t=24598&start=120#p575851
Somehow the combination of “” and new lines caused the string to be
terminated prematurely when it was extracted into the .pot file. Fixed
by removing the “”.
The problem: wmlscope assigns each file to a directory-based subtree, and
assumes that it is visible to every other file in that subtree. The intent
is that each campaign (or add-on of another type) will be in its own
subtree.
However, wmlscope/wmltools has derived these subtrees based on what
arguments get passed to wmlscope, rather than checking whether campaigns
have actually been split out. For instance, invoking wmlscope with
"../data/core ../data/campaigns <userdata>/data/add-ons" will cause
wmlscope to see three subtrees, one of which consists of all mainline
campaigns and another that includes all the user's add-ons. This leads to
many spurious "more than one definition/resource is visible here" errors.
A wildcard like "data/campaigns/*" would be expanded to all the individual
campaign directories. However, the wmlscope user might not know that they
should do that. Also, until the glob module was imported recently, globbing
did not work in the Windows cmd shell.
The solution: declare "campaigns" and "add-ons" to be roots, and check for
their presence in the directory names. If indicated, split out the
subdirectories into their own subtrees. Since it is possible that the user
may have moved, copied, or drafted campaigns/add-ons to another folder
that isn't following Wesnoth convention, also check for that.
While testing wmlscope without including data/core, which guarantees lots
of "unresolved" references, I got a crash pointing to this line with the
traceback: "NameError: global name 'args' is not defined".
At first, I thought the crash might have been caused by my splitting out
parse_macroref into its own function, several months ago. However, the
line is at the wrong indentation level for those "args" to be the variable
referenced here. So what "args" might have been intended?
After tracking down the commit that added "args=args" to this line, I've
concluded that this was simply a mistake. ESR isn't around to ask anymore,
but if a macro was never defined, or is not called correctly, what "args"
could be relevant?
The Windows cmd shell will not expand a globbed argument by default, in
fact it will make the argument invalid. Importing and utilizing the glob
module is needed for x-platform.
Globbing is especially important for breaking up the subtree, so wmlscope
doesn't give off "more than one resource/definition is visible here"
errors.
This option is pretty similar in effect to -v -v. Particularly now that
some new switches have been added recently, the clutter makes it no
longer worth keeping around.
A comment notes the option's disappearance, in case anyone wonders what
happened to it or how to get the same functionality.
Going back through wmllint's history, it turns out that there apparently
haven't been any "experimental conversions" since 1.4. Especially since
some new switches have been added recently, the clutter makes it no longer
worth keeping around.
A comment notes the option's disappearance, in case anyone is interested
in recreating experimental conversions again.
These towns were misspelled in their encyclopedia entries, compared to
the Wesnoth map. All of the instances in my UMC collection follow the map
spellings, so I am not leaving the incorrect spelling as an alternative.
Also, there were spelling rules for both "Memog" and Melmog on separate
lines. No reason to keep the mistake around.
Limited number of bats Khrakrahs may have at a time, moved the dwarves
closer to the map edge where possible, and gave the Berserkers
predefined traits to prevent them from being quick (except one on hard).
