Commit graph

737 commits

Author SHA1 Message Date
Subhraman Sarkar
4c1b1ebe20 reduce hardcoded extensions in python files, only instance at wmltool3.py 2024-07-05 09:05:26 +05:30
Steve Cotton
f431e724f8 wmllint: drop the rule about [campaign]rank= being a multiple of 5
The idea of using multiples of 5 seems like a way to avoid having to change
multiple campaigns' ranks at once, because it leaves space to rearrange a
mainline campaign between two other campaigns.

But enforcing "it must be a multiple of 5, even if that means changing other
campaigns" loses the advantage of using multiples. For example, WoF currently
has rank=152, which triggers the warning, which has caused a PR to be opened
that changes WoF, SoF, LoW and SotA - because keeping them in order requires
four campaigns to change.

(cherry picked from commit 42822ac374)
2024-03-06 08:58:08 +01:00
Elvish_Hunter
10733b1071 wmllint: check if campaigns are in the 'campaigns' folder before considering them as mainline for the rank check 2024-01-26 21:46:37 +01:00
Elvish_Hunter
1c9274faea wmllint: make the 'ignore' magic comment actually work in certain situations
Fixes #8182
2024-01-26 21:31:56 +01:00
Elvish_Hunter
28cea58aff wmllint: warn about [filter] in [kill] tags 2023-12-25 21:15:45 +01:00
Gunter Labes
26ec459cb0
Revert "wmllitnt: add two missing corrections (#7765)"
This reverts commit 915d9c5aba since it just adds redundant replacements.
2023-07-19 11:24:28 +02:00
Tahsin Jahin Khalid
915d9c5aba
wmllitnt: add two missing corrections (#7765) 2023-07-12 22:59:43 +02:00
Severin Glöckner
72935c7c03 wmllint: conversion rules for moved sprites 2023-06-27 12:58:20 +02:00
Tahsin Jahin Khalid
6a0df44c00
wmllint: add new conversion rule for the Elvish Fighter image path 2023-06-20 14:22:50 +02:00
Slayer95
81014cc0c2
Update wmllint calls to parse_macroref (#7662)
Fixup for #7561.
2023-05-30 18:03:20 +02:00
Elvish_Hunter
d4c8d08064 wmllint: improve [campaign] rank= validation message 2022-12-30 23:33:59 +01:00
Elvish_Hunter
c1a074ea41 wmllint: validate values of [campaign] rank= 2022-12-30 22:49:36 +01:00
Toom
07dc953875
Escape < and > even if only one of them exists or if found multiple times (#7154)
* Escape < and > even if only one of them exists

In python negative index counts from the end, so without this change or another solution
"example with only < one side" would be converted to 
"example with only < one sid&gt;example with only < one side"

* Escape < and > even if found multiple times
2022-12-20 20:07:17 +01:00
Wedge009
26adbf4416 wmllint: As requested, adding recognition of WebP image labels.
Extension of #7079.
2022-11-03 11:26:30 +11:00
Wedge009
2010ffdbba
wmllint: Ignore labels for translation if a PNG extension is found (#7079)
* wmllint: Ignore labels for translation if a PNG extension is found.

Resolves #6995.
2022-11-03 11:16:37 +11:00
Dou1622
a667740fe5
Fix wmllint translation mark errors (#6966)
* Fix wmllint translation mark errors

* Added wesnoth-help domain

* Try to give better labels for the WC map generator settings which are now marked for translation.

Co-authored-by: Wedge009 <wedge009@wedge009.net>
2022-11-01 13:40:49 +11:00
Tahsin Jahin Khalid
fde3c8df29 wmllint: add terrain code updaters
Allows updating maps by wmllint. Accommodates #7042
2022-10-10 21:47:42 +08:00
Steve Cotton
a2747cc651 wmllint: stop adding wesnoth-icon.png to messages
We're had at least two people look at the "good first issue" list, pick up
the wmllint warnings, open a PR, and then get a response that these .pngs
shouldn't be added by default. That's not a welcoming introduction.

IIRC we didn't get full consensus that these should never be added, but I
think it's time to open a "just drop that code, no options" PR. If someone
wants it back in a subset of circumstances, they can always create a PR to
readd it along with adding an option to enable it.
2022-08-31 21:27:15 +02:00
Elvish_Hunter
8b8f99e65a wmllint: fixed translation marks not being removed from values when checking if a string is empty 2022-05-28 22:03:25 +02:00
Elvish_Hunter
f7859ad104 wmllint: automatically remove {SOUND:SLOW} and {SOUND:POISON} lines
Part of point 5 of issue #6403
2022-05-17 23:57:08 +02:00
Tahsin Jahin Khalid
4c42228c52
wmllint: add Giant Stoat -> Frost Stoat monster ID change (#6694) 2022-05-14 23:24:03 +02:00
Elvish_Hunter
62ef86e2bd wmllint: updated mainline campaigns tuple 2022-05-06 20:53:22 +02:00
Elvish_Hunter
52da1fa774 wmllint: replaced gif with webp in two regexps 2022-05-01 11:24:28 +02:00
Pentarctagon
9469f8af63 Update wmllint. 2022-04-30 14:23:32 -05:00
Elvish_Hunter
f65e434428 wmllint: finish removing support for the old special notes system
The magic comments 'notecheck off', 'notecheck on' and 'match <ability> with <note>' no longer have any effect.
2022-04-26 11:19:43 +02:00
Elvish_Hunter
2c993867cf wmllint: removed --stringfreeze command line flag
This flag was supposed to disable repair attempts for newlines in messages, however it never did so, even when the non-standard word wrap check was still available. Instead, it just disabled repair attempts for double spaces after sentence ends.
2022-04-25 23:05:39 +02:00
Elvish_Hunter
e1553e8c52 wmllint: added conversion rule for maps/background.png to WebP 2022-03-15 22:47:17 +01:00
Elvish_Hunter
528ea56424 wmllint and wmlindent: avoid crashing on non-UTF8 files
Fixes #2091
2022-02-16 10:59:05 +01:00
Elvish_Hunter
cde990a9a0 wmllint: handle deprecated [unit] placement= values 2022-02-16 10:53:29 +01:00
Gunter Labes
9f87a2a9e6
Remove ancient check
No `letter` attribute for terrain since more than a decade.
2022-02-15 20:15:30 +01:00
Gunter Labes
8f4331f9d2
Remove condition improperly added in 49318f6
The intention was to check for strings with only spaces but the test checked for
spaces at the start of the string. Neither seems useful.
2022-02-15 20:00:00 +01:00
Gunter Labes
e8e5387069 Improve empty value checks 2022-02-15 19:49:30 +01:00
Gunter Labes
ef2205aa62 Fix comment handling if the value is empty (fixes #6514) 2022-02-15 19:49:30 +01:00
Elvish_Hunter
bcab977c03 Removed some duplicated images used by the obsolete unit_box theme 2022-01-14 22:15:55 +01:00
Elvish_Hunter
6227507af7 wmllint: fixed a typo in a terrain code 2022-01-11 14:23:44 +01:00
Elvish_Hunter
5a50c03aaf wmllint: fixed Ggf -> Gg^Emf and Qv -> Mv terrain conversions 2022-01-10 21:02:20 +01:00
Elvish_Hunter
33fbc5252a wmllint: added support for unit levels and types in recruitment pattern checks 2021-12-27 22:39:58 +01:00
Elvish_Hunter
b0d3097a62 Added --version flag to wmllint, wmlscope and wmlindent
Also made GUI.pyw report the version in the about dialog. Fixes #6346
2021-12-26 22:10:44 +01:00
Elvish_Hunter
912625be84 wmllint: automatically remove {MAGENTA_IS_THE_TEAM_COLOR} 2021-12-03 11:47:48 +01:00
max-torch
74d8ac9e77 Edit wmllint KeyboardInterrupt Displayed Message 2021-11-17 23:08:37 +01:00
Elvish_Hunter
4fed167032 wmllint: added automatic update of four terrain macros
Fixes #6009
2021-08-06 20:50:07 +02:00
Elvish_Hunter
80900fdc1a wmllint: removed check for spaces in e-mail addresses 2021-07-31 17:47:45 +02:00
Toom
87e0900729
Update dune explorer image path, closes #5945 (#5946) 2021-07-12 16:42:41 -05:00
Elvish_Hunter
78c0954b2a wmllint: added names to the translatable keys tuple 2021-06-25 21:34:27 +02:00
Elvish_Hunter
78b7e4ae11 wmllint: removed checks for arcane, spirit and defense cap special notes
These special notes now are automatically added by the engine.
2021-06-24 21:14:34 +02:00
Elvish_Hunter
0ef5b9f6d9 wmllint: added special_note to the translatable keys tuple 2021-06-24 21:14:34 +02:00
Celtic Minstrel
3568b5ff66 An easier way of setting special notes in the most common use-case (abilities and weapon specials)
Rebased version of e6c58fc35c, with merge conflicts resolved.
2021-06-01 14:29:57 +02:00
Elvish_Hunter
c1c80e3a7f wmllint: implemented Xol terrain conversion 2021-03-01 20:30:07 +01:00
Elvish_Hunter
780797e3bc wmllint: enable checks inside Lua [args] tags
Completes PR #5470
2021-03-01 18:43:03 +01:00
Elvish_Hunter
2a83e78a3c wmllint: don't try to collect WML tags inside Lua code
Fixes #5509
2021-02-16 16:18:53 +01:00