wmllint: removed --stringfreeze command line flag

This flag was supposed to disable repair attempts for newlines in messages, however it never did so, even when the non-standard word wrap check was still available. Instead, it just disabled repair attempts for double spaces after sentence ends.

changelog.md

@@ -17,6 +17,7 @@
  ### Units
  ### User interface
  ### WML Engine
+   * The `--stringfreeze` (`-Z`) command line flag has been removed from wmllint.
  ### Miscellaneous and Bug Fixes
 
 ## Version 1.17.3

data/tools/GUI.pyw

@@ -624,20 +624,12 @@ class WmllintTab(Frame):
                               column=0,
                               sticky=W,
                               padx=10)
-        self.freeze_variable=BooleanVar()
-        self.freeze_check=Checkbutton(self.options_frame,
-                                      text="Ignore newlines in messages",
-                                      variable=self.freeze_variable)
-        self.freeze_check.grid(row=4,
-                               column=0,
-                               sticky=W,
-                               padx=10)
         self.skip_variable=BooleanVar()
         self.skip_core=Checkbutton(self.options_frame,
                                    text="Skip core directory",
                                    variable=self.skip_variable,
                                    command=self.skip_core_dir_callback)
-        self.skip_core.grid(row=5,
+        self.skip_core.grid(row=4,
                                column=0,
                                sticky=W,
                                padx=10)
@@ -1201,8 +1193,6 @@ Please select a directory or disable the "Skip core directory" option""")
             wmllint_command_string.append("--known")
         if self.wmllint_tab.spell_variable.get():
             wmllint_command_string.append("--nospellcheck")
-        if self.wmllint_tab.freeze_variable.get():
-            wmllint_command_string.append("--stringfreeze")
         if not self.wmllint_tab.skip_variable.get():
             wmllint_command_string.append(WESNOTH_CORE_DIR)
         if os.path.exists(umc_dir): # add-on exists

data/tools/wmllint

@@ -2260,8 +2260,7 @@ to be called on their own".format(filename, num))
                 if nv != value:
                     print('"%s", line %d: double space after sentence end' \
                           % (filename, i+1))
-                    if not stringfreeze:
-                        lines[i] = sentence_end.sub(" ", lines[i])
+                    lines[i] = sentence_end.sub(" ", lines[i])
                 if capitalization_error.search(lines[i]):
                     print('"%s", line %d: probable capitalization or punctuation error' \
                           % (filename, i+1))
@@ -3314,8 +3313,7 @@ to all sides.""")
 scenarios, etc.""")
     parser.add_argument("-S", "--nospellcheck", action="store_false",
                         help="Suppress spellchecking")
-    parser.add_argument("-Z", "--stringfreeze", action="store_true",
-                        help="Suppress repair attempts of newlines in messages")
+    # -Z --stringfreeze has been removed; it just disabled repairs of double spaces after sentence ends
     # -f --future has been removed; there have been no experimental conversions since 1.4
     # -p --progress has been removed; similar to existing -v -v
     parser.add_argument("directories", action="store", nargs="*",
@@ -3331,7 +3329,6 @@ directory.""")
     dryrun = namespace.dryrun
     missingside = namespace.missing
     revert = namespace.revert
-    stringfreeze = namespace.stringfreeze
     stripcr = namespace.stripcr
     verbose = namespace.verbose
     dospellcheck = namespace.nospellcheck # WARNING! We store the opposite of the value needed!