0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

wmllint: drop the rule about [campaign]rank= being a multiple of 5

Browse source 
The idea of using multiples of 5 seems like a way to avoid having to change
multiple campaigns' ranks at once, because it leaves space to rearrange a
mainline campaign between two other campaigns.

But enforcing "it must be a multiple of 5, even if that means changing other
campaigns" loses the advantage of using multiples. For example, WoF currently
has rank=152, which triggers the warning, which has caused a PR to be opened
that changes WoF, SoF, LoW and SotA - because keeping them in order requires
four campaigns to change.

(cherry picked from commit 42822ac374)
This commit is contained in:
Steve Cotton 2024-02-25 15:19:44 +01:00
parent c9a343da9d
commit f431e724f8
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
data/tools/wmllint
View file

@ -1729,8 +1729,8 @@ def local_sanity_check(filename, nav, key, prefix, value, comment):
if campaign_rank < 300:
print(errlead + "rank for add-on campaigns should be greater than or equal to 300")
elif "campaigns" in filename:
if campaign_rank >= 300 or (campaign_rank % 5) != 0:
print(errlead + "rank for mainline campaigns should be a multiple of 5 between 0 and 299 (included)")
if campaign_rank >= 300:
print(errlead + "rank for mainline campaigns should be between 0 and 299 (included)")
except ValueError:
print(errlead + "rank must be a numeric value")