Treat "editor^The overlays '^Uf' and '^Ufi' are deprecated because ..."
as a having translation hint "editor", and show "The overlays ..." to the
user. This disallows using carets inside the translation hint itself.
Code already reviewed in the discussion in #4359.
Currently, the value of `game["savegame"]` is one of `mp_game_settings::SAVED_GAME_MODE`. However, the `to_bool()` function doesn't recognize any of those values as being true, so a game is always shown in the MP lobby as not being a reload, even if it actually is.
Change terrain_type_data's documentation and some methods to avoid exposing
implementation details, for example renaming try_merge_terrains to is_known.
Move the code to load all the [terrain_types] in to the terrain_type_data
class's own .cpp file, and out of terrain.cpp.
Add documentation about "underlying", and why worst(best(a,b),c,d) terrains don't work
The commented-out code for merging pluses and minuses in the middle of an alias
was commented out in 1.5's d2edbe118a, but the
concept of pluses and minuses in the middle of an alias seems broken anyway
(see comments added to merge_alias_lists in this commit).
Descriptions are t_strings, avoid converting them to std::string and back.
The string _("replay") is already used elsewhere, so this prevents two kinds of bugs from
happening:
- Translating _("replay") and _(" replay") differently
- Translating _(" replay") without the leading space
14 po files got this wrong in one way or another.
Before this commit, a probability of 0.67% was shown as 0.67%.
Now it is shown as 0.7%.
(That's not a typo. I'm talking about a chance of 67 permyriad.)
Reproducible in the test scenario by having the Wolf Rider attack the
unit to its south.
This makes it so if you try to recall and your recall list is empty when
accounting for the whiteboard, you get the "There are no troops" error
rather than the "You currently can't recall" error below it.
The function's only purpose so far is to initialize a function pointer
to a kernel32.dll export (GetFinalPathNameByHandleW) that isn't present
on versions before Windows Vista. However, this development branch
explicitly bumps the minimum build target to Windows 7, rendering the
code redundant.
This also gets rid of a rather bothersome GCC warning involving the
FARPROC pointer cast used to store the result of GetProcAddress().
* Rendering in batches is default behaviour as of SDL 2.0.10 but causes rendering issues in Wesnoth.
* Fixes#4237
* Fixes#4245
* Not sure if #4309 may benefit as well
Explicitly use t_str() to avoid an ambiguous construction from
7bee8ee157, which made GCC9 error out because it
could alternatively use t_string::t_string(const string &).
Resolve the merge conflict from 26d1ca7a7d
Fixes#1111.
Quoting the issue:
> The implications would be, e.g., that you could chat (to yourself, i.e. "for the record", i.e. for the replay) in SP mode, thus making notes in the chatlog about the gameplay.
