Commit graph

29843 commits

Author SHA1 Message Date
Celtic Minstrel
1efc2fbe4d [Lua] Avoid reusing no-longer-needed variables for different meanings
This raises Lua warnings about mismatched types
2024-02-26 13:24:36 -05:00
Celtic Minstrel
f19b7829c7 [Lua] Fix call of nonexistent function 2024-02-26 13:24:36 -05:00
Steve Cotton
b9cb577bac HttT S06: Make Elensefar's defenses look damaged by the Orcish siege
Just some debris embellishments to suggest that the towers at the
end of the bridges were hit with siege weapons. The defense stats
are still the same and there's no dialogue change to go with this.
2024-02-26 11:31:38 +01:00
Gunter Labes
9371562454
Add 1.17 port number back
Once the server gets turned off the port number should be moved to the deactivated list instead of removed.
2024-02-25 19:31:25 +01:00
doofus-01
2eeccd98d8
skeletal rider and alternative bear portraits (#8453)
* skeletal rider portrait

* alternative bear portrait
2024-02-25 08:40:47 -08:00
Charles Dang
011fa3aa9d Editor: refined Addon Selection prompt 2024-02-24 20:01:37 -05:00
Charles Dang
b0d1b75a9f MP/Staging: don't hardcode bold formatting in translatable strings 2024-02-24 20:00:06 -05:00
Charles Dang
d3739effcf MP/Create Game: bump game label border size 2024-02-24 19:06:18 -05:00
Charles Dang
08fc993c16 GUI2/Canvas: allow text shape to set outline (resolves #8398) 2024-02-24 18:30:33 -05:00
Nils Kneuper
a64f86962a add "noconvert" flag to Bengali translator name 2024-02-24 16:23:49 +01:00
Nils Kneuper
460eb623c0 updated Bengali translation, activated in credits
This introduces a new string for the translation!
2024-02-24 15:07:08 +01:00
Charles Dang
8ea8b6c7c3 Restore fog and reachmap highlights to minimap
I don't like this solution, but it's the quickest way to get the effect back without
A: having to deal with surfaces
B: having to fiddle with color blend modes
C: having to apply the effect both to the base and the overlays (the old surface impl continuously
   blit a single surface together so it could just adjust the final product once)
2024-02-21 18:50:59 -05:00
Wedge009
a59c32f9e2 Bat images were moved from undead directory to bats in #6655. 2024-02-21 11:11:12 +11:00
Wedge009
b334f6707b Saurian Prophet/Seer portrait was converted from PNG to WebP.
[ci skip]
2024-02-21 11:11:12 +11:00
pentarctagon
6a8d4bc1db 1.19.0-dev 2024-02-19 21:12:01 -06:00
pentarctagon
d1b3ede924 1.17.26 2024-02-19 21:05:54 -06:00
pentarctagon
264c8413d0 pot-update and regenerate doc files 2024-02-19 21:02:14 -06:00
pentarctagon
820bbc53b8 update add-on server port for 1.18, also here 2024-02-19 18:52:20 -06:00
Steve Cotton
731e59f986 Add Bengali translation to the build scripts
No translated text yet, just template .po files.

The po files are generated assuming that PR 8433 will merge, removing
the new translatable text from the multiline_text and spinner widgets.
2024-02-19 17:08:10 -06:00
newfrenchy83
b4abee7c38
Fix increase by percentage returns 1 if experience is equal to zero (#8425)
Using `[effect]app/y_to,increase=experience,"40%"` on a unit with 0 XP used
to give that unit 1 XP, because of a minimum in the C++.
2024-02-19 13:49:09 +01:00
Hejnewar
0034b98fc2 UtBS Heroes: Taunting Strike xp farm fix
In addition make taunting strike more synergised with bolas.
2024-02-18 21:04:29 +01:00
Hejnewar
82128b6b5a UtBS Units: Fighter line adjustments
Adjust Fighter line to allow for easier early leveling and more late game staying power. Add parry to secondary melee attacks in order to incentivise their use.
2024-02-18 21:04:29 +01:00
Steve Cotton
bd31d9042d DiD S10: Fix missing line in human heroes' book endings
A simple case of `role=unit` instead of `speaker=unit`, the
necessary translatable text was already in the scenario.
2024-02-18 16:43:54 +01:00
Hejnewar
cfb7221262 UtBS S01: Improve event/dialog consistency regardless of trigger order
Fix #8201
2024-02-18 14:44:54 +01:00
Hejnewar
a7680561d0 UtBS S05: Use enter_hex so events cannot be triggered out-of-sequence
Fix #8190
2024-02-18 14:44:54 +01:00
Steve Cotton
af8c2fe5cb
EI S11-S18: Add more PO hints
Has a few updates to S04a, S04b, S09 and S99 too.

Lore: this declares Khrakrahs (dragon seen in SoF) to be male.
He's been in many versions of Wesnoth that only had male drakes,
thus will surely already be male in any translation where the
gender has an effect on the wording.

There's a few "TODO for 1.19" comments added:

* In S12, the left behind units say "we must ride ... to save Wesnoth",
    but it should be "you must ride".
* The intro of S13 is confusing, there's little indication of why you
    only have one unit, or what mission he failed.
* In S16, Gweddry says "night approaches" on turn 1 (morning)
2024-02-18 10:44:32 +01:00
gfgtdf
c7ca36be6e
wc: fix #6513 Bezoar artifact (#8340)
* wc: fix #6513  Bezoar artifact

The item now applies the effects directly instead of using [trait]s, 
The lua code that added traits in the wc lua files didn't work, but the main reason why i preferred  this solution instead of changing the lua files is that it makes it possible to simply remove the artifact via for example [remove_object] (which wouldn't work for artifacts using traits as those are separate modifications)

The code now also adds a dummy ability so that players know that this unit has the benefits of the healthy fearless and  undead  traits.
2024-02-17 23:25:07 +01:00
MechanicalDragon963
c6d8c67495 HttT S16, S19a, S19b and S22: Map embellishments
S16 (Hasty Alliance) uses more rocks and bridges, including
bridges over lava.

S19a (Snow Plains) gets some dirt roads without snow on, and the
edge of the map gets some ice and water.

S19b (Swamp of Dread) gets a wide variant of swamp terrains
instead of sand.

S22 gets more variety in the forests and grasslands.

Cherry-picked from the branch in PR #8243.
2024-02-17 22:05:08 +01:00
Steve Cotton
1c4b46add3 EI S01, S13: Fix Gaennell's gender
She's meant to be female, but in S01 the gender defaulted to male,
while in S13 it was set to random.
2024-02-17 20:24:08 +01:00
OrekOrek
97635055f0
HttT S17 Ensure map always has 6 castle hexes around Konrad (#8314)
HttT S17 map height +5

According to several hundred test runs, Konrad's castle seems to be produced between y=59 and y=71 when the center of the chamber is set at y=65 as it currently is.

Because map_height=75 means that the playable map size is y=73 due to the border hexes at the top and bottom, this change probably guarantees that Konrad's castle is fully within the playable map.
2024-02-17 18:05:18 +01:00
Subhraman Sarkar
8d3a52eb3f
Stop multiline_text from infinite growing and show scrollbar instead
Fixes the following bugs :

Stop scroll_text from growing infinitely and instead show the
scrollbars when the text dimensions exceed the default size of
the underlying multiline_text in some dialogs (such as edit_pbl,
the pbl publishing editor).

Allow horizontal_grow/vertical_grow to work correctly. Currently,
the widget stops vertically growing due to absence of
max_height=0, again in some specific dialogs.
2024-02-17 12:50:09 +01:00
Dalas121
e380abd2ce
EI S12: bugfixes for dra_nak_dead and flying undead drowning
EI - dra_nak_dead branch bugfix. Fixes #8414.

* S18 conditionally forwards the player to the bonus scenario, S99. One of the required conditions is that dra_nak_dead is not yes. The victory event of S12 unconditionally cleared dra_nak_dead, meaning that that test in S18 would always pass.
* S12 tests dra_nak_dead to see if he was killed in S11, and if he wasn't then it renames "Varrak-Klar" to "Chief Dra-Nak", as if Dra-Nak was pursuing the heroes. However, S12 didn't set the dra_nak_dead variable if the renamed Varrak-Klar died.

EI - S12 bugfix flying undead being drowned/trapped

* In EI S12, units were killed/lost when a bridge is destroyed.
* Flying units shouldn't be killed/lost, as they can fly.
2024-02-17 03:52:26 +01:00
pentarctagon
d4956dbed7 fix mixed indentation. 2024-02-16 09:40:16 -06:00
Celtic Minstrel
8d30761ca8
[WoF] Avoid code duplication and fix a non-translatable string (#8384)
Instead of copy-pasting the multiplayer turns over advantage function, just use that function directly.

This required making some changes to the function to better support this specific use-case,
but I think it's still better than copy-pasting it.

I split the primary functionality out into two separate pieces – calculation and display.
Thus, the main function is technically unchanged, while WoF can avoid the weird things it does
and just calculate and display how it wants.

This fixes #8368.
2024-02-16 09:38:45 -05:00
Toom
0e99d4b38b Revert renaming of ai_helper.checked_move_core
@CelticMinstrel #fixes #8412
2024-02-16 15:32:00 +01:00
Dalas121
17ea7cd2c2 EI: fix Terraent standing animation, and update stats to match mainline
When Terraent was created, the mainline paladin had no standing anim. When that was added, it conflicted with Terraent's. This fixes that issue.

This also updates Terraent's other stats to match the mainline paladin's rebalanced stats.
2024-02-16 00:47:45 +01:00
P. J. McDermott
368e270bf3 Fix some spelling errors
These are not translatable strings.

Debian's lintian QA tool found the instances in code.
2024-02-15 17:27:44 -06:00
P. J. McDermott
39fb741309 Make TeamColorizer and update_pathfinding executable
These scripts get installed but were missing execute mode bits.
2024-02-15 17:27:44 -06:00
Steve Cotton
4567d56e22 EI S05-S10: Add more PO hints 2024-02-15 17:33:41 +01:00
Dalas121
1a6e559e5c EI - fix S11 cell-door-open event
You begin the scenario locked in a cell needing to escape through some caves, but it's possible to open the cell from the inside.  This fixes that.
2024-02-15 15:31:41 +01:00
Celtic Minstrel
915fd49ae6 Tutorial: Specify the side of Li'sar in the char select
When a unit data passed to `to_map` either lacks a side or has
side zero, implementation automatically sets it to 1, thus the
existing code worked fine. However:

1. The lack of a `side` could trigger a warning in EmmyLua. It
currently doesn't trigger that, but would with Celtic Minstrel's
planned improvements in Wesnoth's lint hints.

2. The tutorial should be good example code, and the special-case
in the C++ code that made this work is a case of "assume it's a
SP situation, and choose the result that benefits side 1".
2024-02-15 09:57:17 +01:00
Celtic Minstrel
600c88c291 [WC] I think this was a remnant of a global variable removal...? 2024-02-13 19:32:39 -05:00
Celtic Minstrel
0ef38c82c8 [WC] Fix a broken map filter
I'm not sure what the intent was here, so I had to make a guess.
2024-02-13 19:32:29 -05:00
Celtic Minstrel
f7ef5e1362 [LuaDoc] Convert all the ai_helper documentation to LuaDoc format, and add LuaDoc for all previously-undocumented functions. 2024-02-13 19:29:21 -05:00
Celtic Minstrel
94adca0fff [LuaDoc] Fix some non-nullable warnings by adding explicit type annotations on local variables 2024-02-13 19:29:21 -05:00
Celtic Minstrel
b506010a8f [LuaDoc] Correct some dumb errors 2024-02-13 19:29:21 -05:00
Celtic Minstrel
4b5a8e25e8 [LuaDoc] Suppress some diagnostics 2024-02-13 19:29:21 -05:00
Celtic Minstrel
6145c48d35 [LuaDoc] Fix incorrect declaration of unit.variables and side.variables - make them consistent with wml.variables 2024-02-13 19:29:20 -05:00
pentarctagon
029da00681 use scroll_text for pbl editor description 2024-02-13 15:37:12 -06:00
Subhraman Sarkar
6c5a8e923d
Spinner and multiline textbox widgets (#8199) 2024-02-13 11:54:34 -06:00