Commit graph

18 commits

Author SHA1 Message Date
Celtic Minstrel
8d30761ca8
[WoF] Avoid code duplication and fix a non-translatable string (#8384)
Instead of copy-pasting the multiplayer turns over advantage function, just use that function directly.

This required making some changes to the function to better support this specific use-case,
but I think it's still better than copy-pasting it.

I split the primary functionality out into two separate pieces – calculation and display.
Thus, the main function is technically unchanged, while WoF can avoid the weird things it does
and just calculate and display how it wants.

This fixes #8368.
2024-02-16 09:38:45 -05:00
Pentarctagon
370d03ccb7 Fix luacheck warnings and add to CI.
Note the `exclude_files` in .luacheckrc should be deleted once the eventual Ubuntu 22.04 base image has an updated luacheck that supports lua 5.4.
2021-11-28 14:26:02 -06:00
Celtic Minstrel
bf746a0207 Update mainline content to use the wesnoth.scenario module 2021-05-11 14:52:21 -04:00
Celtic Minstrel
05b0b7a1df Update uses of wesnoth.fire 2021-05-11 14:52:20 -04:00
Steve Cotton
8e315683ae Add wesnoth.colors[name].pango_color and use it in the multiplayer turns-over dialog 2021-04-28 10:44:19 +02:00
Steve Cotton
26b3ad42a5 Multiplayer turns over dialog: stop using %d and %s in translatable strings
This should probably be changed into a table of GUI2 widgets, but this commit
is an improvement on what was here before. It removes the broken conjunct list
formatting for 3-way ties. However, it also means that there are 5 lines per
language to translate again.

Fixes #4274.
2021-04-28 09:11:29 +02:00
Celtic Minstrel
aaa2dc4ece Rollback possibility of wesnoth.get_units matching recall list units
Now it's renamed to wesnoth.units.find_on_map.

wesnoth.units.find implements the case of finding units on either the map or a recall list.
2019-11-15 22:39:09 -05:00
Celtic Minstrel
977f05d77f Lua: Replace uses of deprecated (moved) unit functions
Also backtracked the removal of wesnoth.get_recall_units, which is now available as wesnoth.units.find_on_recall - it's just more convenient than passing x=recall to wesnoth.units.find
2019-11-15 22:39:08 -05:00
joeylmaalouf
b96ff34df4 Allow ties to be reported as such in the turns_over_advantage calculation (fixes #1341)
(cherry-picked from commit 3d481c1b8b)
2018-10-07 03:24:49 +00:00
mattsc
05d5afa6a9 Lua code: replace deprecated wesnoth.get_variable() calls
(cherry-picked from commit f1764d182f)
2018-10-07 03:21:06 +00:00
Celtic Minstrel
1123c8a707 Remove some uses of set_wml_tag_metatable
(cherry-picked from commit 3939c332b9)
2018-10-07 03:18:29 +00:00
Charles Dang
471c9e876a Addressed a large chunk of the whitespace issues from #2613
[ci skip]
2018-03-09 11:37:00 +11:00
Alexander van Gessel
523f61c6e7 Set a fallback color
It will be used only if there are no sides, which shouldn't happen, but can.
See issue #2063.
2017-10-04 14:24:46 +02:00
Celtic Minstrel
8d4cf3cf62 Shorten requires where possible 2017-05-03 02:42:25 -04:00
gfgtdf
e1045f9b46 cleanup turn_over_advantage lua code
- removed ugly hack to convert 'break' into 'continue'
- fixed 'color' global varible leaked
2017-02-14 18:24:54 +01:00
Charles Dang
659e482e01 Moved eras files back to multiplayer/ since its movement caused errors in replays pre-move 2016-09-11 10:23:53 +11:00
Charles Dang
3cb8878b9a Fix duplicate loading of eras in mp
This fixes warnings about the era macros being redefined without being #undef-ed when
loading MP.
2016-08-30 19:39:00 +11:00
gfgtdf
634d29020f dont make 4mp leader quick in campaigns by default
making 4mp leader automaticly quick is unexpected for a campaigns
designer. And the intention is make it easier to port sp campaigns to
mp.
To do this i ported the quick4 mp leader code to lua.

I also moved the lua code from eras.cfg to a new file eras.lua, this
makes is easier for an editor to detect lua syntax highlichting
automaticly.
2015-06-16 02:13:08 +02:00