0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "Add [modify_unit]rebuild=no"

Browse source 
This reverts commit 51d6402453.

After discussion with @gfgtdf it was determined that this is not a useful feature after all, since it was in fact the default behaviour for the optimized path.
This commit is contained in:
Celtic Minstrel 2019-11-16 14:38:05 -05:00
parent 3686dba82c
commit 2cc7fe6450
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.md
View file

@ -54,7 +54,6 @@
* [effect]apply_to=variation now supports heal_full * [effect]apply_to=variation now supports heal_full
* Support [set/clear_variable] inside [modify_unit/side] * Support [set/clear_variable] inside [modify_unit/side]
* Support [variables] in [modify_side], as in [modify_unit] * Support [variables] in [modify_side], as in [modify_unit]
* [modify_unit] now accepts rebuild=no which will avoid a rebuild of the unit if possible (not guaranteed)
### Packaging ### Packaging
* The Wesnoth client now looks for the data/dist file when logging into the multiplayer server. * The Wesnoth client now looks for the data/dist file when logging into the multiplayer server.
This file should contain one of the following values based on where the package is for: This file should contain one of the following values based on where the package is for:

5
data/lua/wml/modify_unit.lua
View file

@ -53,7 +53,6 @@ local known_attributes = make_set {
"description", "description",
"hidden", "hidden",
"unrenamable", "unrenamable",
"rebuild",
} }
local known_tags = make_set { local known_tags = make_set {
@ -168,10 +167,10 @@ local function simple_modify_unit(cfg)
u:transform(cfg.type or u.type, cfg.variation) u:transform(cfg.type or u.type, cfg.variation)
end end
-- by default always do an advancement here (not only when experience/max_experience/type was modified) -- always do an advancement here (not only when experience/max_experience/type was modified)
-- for compatibility with old code. -- for compatibility with old code.
-- Skip for recall list units -- Skip for recall list units
if u.valid == 'map' and (cfg.experience or cfg.max_experience or cfg.rebuild ~= false) then if u.valid == 'map' then
u:advance() u:advance()
end end
end end