Linus Groh
a81bce8c2a
LibJS: Make Array.length non-configurable
...
This was incorrect, it's only writable.
2020-05-01 16:54:01 +02:00
Linus Groh
65dbe17dd7
LibJS: Add Value::to_size_t()
2020-05-01 16:54:01 +02:00
Linus Groh
62671bea68
LibJS: Add Object::has_property()
...
Like Object::has_own_property() but going down the prototype chain.
2020-05-01 16:54:01 +02:00
Linus Groh
4cdd802927
LibJS: Return a bool from Object::put* to indicate success
2020-05-01 16:54:01 +02:00
Kesse Jones
6dbb5df81f
LibJS: Add String.prototype.lastIndexOf
2020-05-01 16:50:37 +02:00
Emanuele Torre
46b79eaad9
LibJS: Implement console.countReset()
...
I chose to also make it print "<counter_name>: 0\n" when a counter gets
reset, similarly to how firefox behaves.
2020-05-01 13:02:01 +02:00
Emanuele Torre
8c60ba1e42
LibJS: Implement console.count()
2020-05-01 13:02:01 +02:00
Matthew Olsson
28ef654d13
LibJS: Add object literal method shorthand
2020-05-01 12:28:40 +02:00
Andreas Kling
88f7f9712d
TextEditor: Use document path as base URL for markdown preview HTML
2020-04-30 23:43:17 +02:00
Andreas Kling
770dedcc23
LibGUI: Remove some ancient unused debug logging
2020-04-30 22:42:02 +02:00
Andreas Kling
68513abf39
Terminal: Tweak default prompt color slightly :^)
2020-04-30 22:38:40 +02:00
Andreas Kling
06c478852a
FileManager: Realize the initial path when opened from the command line
2020-04-30 22:38:28 +02:00
Andreas Kling
b2b30567ab
js: Turn on live syntax highlighting by default
2020-04-30 22:37:50 +02:00
Andreas Kling
fec52fa94b
LibX86: Disassemble BSWAP
2020-04-30 22:15:16 +02:00
Andreas Kling
a40aa80df1
Debugger: Add missing newline in "help" output
2020-04-30 22:15:16 +02:00
Andreas Kling
2822b1035f
WindowServer: Fix some pixels in menus after window border changes
2020-04-30 22:15:16 +02:00
Andreas Kling
c3a2dffe29
WindowServer: Tweak window icon menu popup location
2020-04-30 22:15:16 +02:00
Andreas Kling
5bdd05024f
DisplaySettings: Tweak label "Color Name" => "Color"
2020-04-30 22:15:16 +02:00
AnotherTest
977aa3968c
LibLine: Reset inline_search_cursor along with cursor
...
This fixes the issue where the editor would only scroll up one command
and then 'search' for it
2020-04-30 22:14:59 +02:00
Andreas Kling
23d99e92b9
WindowServer: Add action icons to the window menus
2020-04-30 12:58:38 +02:00
Andreas Kling
6c0fed3866
TextEditor: Pledge "unix" so we can load images in Markdown preview
...
We should think a bit more about how we want preview content to
interact with the outside world, but for now let's just make it run.
2020-04-30 12:32:41 +02:00
Andreas Kling
e8a5c10382
Base: Add back the OG grid wallpaper from back in the day, now as a PNG
2020-04-30 12:31:02 +02:00
Andreas Kling
888e35f0fe
AK: Add ALWAYS_INLINE, NEVER_INLINE and FLATTEN macros
...
It's tedious to write (and look at) [[gnu::always_inline]] etc. :^)
2020-04-30 11:43:25 +02:00
Sergey Bugaev
f1a8fb1e88
LibMarkdown: Add support for images :^)
2020-04-30 11:30:27 +02:00
Sergey Bugaev
b8aab5fdc3
LibMarkdown: Handle broken link markup better
...
Let's output *something* instead of crashing on a failed assertion.
2020-04-30 11:30:27 +02:00
Sergey Bugaev
279cf9294a
AK: Always inline trivial StringView constructors
2020-04-30 11:30:27 +02:00
Sergey Bugaev
135d29b498
AK: Assert that we don't create StringViews of negative length
...
Due to us using size_t for the length, the actual value will always be positive.
If, for example, we calculate the length as "0 - 1", we'll get SIZE_T_MAX. What
we can do is check that adding the characters pointer and the length together
doesn't overflow.
2020-04-30 11:30:27 +02:00
Sergey Bugaev
361a1b54d7
AK: Add Checked::addition_would_overflow()
...
And switch the two-argument version of Checked::multiplication_would_overflow()
to use __builtin_mul_overflow_p(). This helps GCC optimize the code better.
2020-04-30 11:30:27 +02:00
Sergey Bugaev
1b36ddce1d
LibC: Hint the compiler that assertions rarely fail
...
Also, rewrite the macro to expand to an if statement instead of
a weird ternary operator with a (void)0 banch.
2020-04-30 11:30:27 +02:00
Sergey Bugaev
b319aca81a
LibCore: Do not assert that NonnullRefPtr is non-null
...
Clang complains about this; with the change the next commit is going
to make to ASSERT() internals, GCC is going to start to complain as well.
2020-04-30 11:30:27 +02:00
AnotherTest
0fb4a808ef
Shell: Provide the correct invariant length to the line editor
2020-04-30 10:47:22 +02:00
mattco98
683a0696f3
LibJS: Add Object.{keys,values,entries}()
2020-04-30 09:53:16 +02:00
Andreas Kling
36a5e0be4b
LibCore: Don't continue in forked child if exec() fails
...
Fixes #1854 .
2020-04-30 09:52:07 +02:00
Andreas Kling
8fc6ff94fe
LibGUI: Scale TabWidget tabs according to available space
...
In TabWidgets with the "uniform tabs" mode on, we will now scale tabs
between a minimum and maximum size, distributing the available space.
Partially addresses #1971 .
2020-04-30 09:28:36 +02:00
AnotherTest
a80ddf584f
Shell+LibLine: Handle escaped characters correctly
...
This patchset fixes incorrect handling of escaped tokens (`a\ b`) in
Shell autocompletion and LibLine.
The users of LibLine can now choose between two token splitting modes,
either taking into account escapes, or ignoring them.
2020-04-30 09:07:38 +02:00
Andreas Kling
f2cdef5c47
LibGUI: Cycle through TabWidget tabs with Ctrl+Tab / Ctrl+Shift+Tab
...
Fixes #2022 .
2020-04-30 09:04:39 +02:00
Andreas Kling
a9f6f862e2
WindowServer: Fix typo (backgound_color => background_color)
2020-04-30 09:04:39 +02:00
Dylan Katz
47f413c47f
Browser: Add missing tooltip to bookmark button
...
The tip will say "Add Bookmark" if not a bookmark and "Remove
Bookmark" if it is.
2020-04-30 08:52:21 +02:00
AnotherTest
fb63b84c78
Shell: Correctly parse quoted filenames in redirection
...
This commit fixes the (incorrect) behaviour of treating quotes as part
of the redirection filename.
Fixes #1857 :^)
2020-04-30 08:51:54 +02:00
Linus Groh
fc34123a54
LibJS: Fix ConditionalExpression::dump()
...
Let's not print m_test three times :^)
2020-04-30 08:43:38 +02:00
Linus Groh
8614fb4092
LibJS: Enforce that ++/-- operand is an identifier or member expression
2020-04-30 08:41:31 +02:00
Linus Groh
624eaa32af
LibJS: Add Parser::syntax_error() helper
...
Instead of having fprintf()s all over the place we can now use
syntax_error("message") or syntax_error("message", line, column).
This takes care of a consistent format, appending a newline and getting
the line number and column of the current token if the last two params
are omitted.
2020-04-30 08:41:31 +02:00
Andreas Kling
85fd0d2187
FileManager: Fix crash when file properties has unnamed UID or GID
...
It's perfectly valid for a file to be owned by a UID or GID with no
corresponding entry in /etc/passwd or /etc/group respectively.
Fixes #1988 .
2020-04-29 19:35:20 +02:00
Andreas Kling
9f32d71782
LibGUI: Use "OK, Cancel" button order in InputBox
2020-04-29 19:31:15 +02:00
Andreas Kling
77916f030f
LibGUI: Use "OK, Cancel" button order in ColorPicker
2020-04-29 19:29:09 +02:00
Andreas Kling
51ab0e967e
LibGUI: Use a sunken GUI::Frame for the ColorPicker color spectrum
...
This looks a lot nicer than just a plain widget. :^)
2020-04-29 19:28:19 +02:00
Andreas Kling
d7d5788469
LibGUI: ColorPicker should pick custom color from bitmap, not window
...
It's not always safe to access pixel data of a window's backing store
since the kernel may decide to purge it at his leisure. Fix this by
instead picking colors from the color spectrum bitmap directly instead.
Also fix up mouse event logic while we're here so it only cares about
the left mouse button
Fixes #1657 .
2020-04-29 19:17:40 +02:00
Andreas Kling
6a01827046
LibGUI: Exit ColorPicker (successfully) when double-clicking a color
...
It feels natural that if I double click a color button, the dialog
closes successfully and "returns" that color.
2020-04-29 19:17:40 +02:00
Andreas Kling
57fe4d19ac
LibGUI: Remove unnecessary is_enabled() checks in mouse event handlers
...
We never deliver mouse events to disabled widgets, so there's no need
to check is_enabled() in these event handlers.
2020-04-29 19:17:40 +02:00
Andreas Kling
cdbc252190
LibGUI: Require a full click on ColorInput's color rect to open picker
...
Let's not open the ColorPicker on mousedown, that was too jarring.
2020-04-29 19:17:40 +02:00