Dominik Honnef
6f9a67a7c7
Make IP allocator lazy
...
Instead of allocating all possible IPs in advance, generate them as
needed.
A loop will cycle through all possible IPs in sequential order,
allocating them as needed and marking them as in use. Once the loop
exhausts all IPs, it will wrap back to the beginning. IPs that are
already in use will be skipped. When an IP is released, it will be
cleared and be available for allocation again.
Two decisions went into this design:
1) Minimize memory footprint by only allocating IPs that are actually
in use
2) Minimize reuse of released IP addresses to avoid sending traffic to
the wrong containers
As a side effect, the functions for IP/Mask<->int conversion have been
rewritten to never be able to fail in order to reduce the amount of
error returns.
Fixes gh-231
2013-04-01 06:02:44 +02:00
Guillaume J. Charmes
d949e2804a
Add a check to avoid double start (resulting in dockerd to panic) and unit test for it
2013-03-31 14:15:10 -07:00
Solomon Hykes
a6779bcae2
Revert regression introduced in 81eac415ad, which caused 'docker run -i' to never close stdin
2013-03-31 02:44:56 -07:00
Solomon Hykes
8293a0d533
Bumped version to 0.1.1
2013-03-31 02:18:04 -07:00
Solomon Hykes
0b9a3c86a2
Show shorthand container IDs for convenience. Shorthand IDs (or any non-conflicting prefix) can be used to lookup containers
2013-03-31 02:02:01 -07:00
Solomon Hykes
5a2a044e24
Merge remote-tracking branch 'origin/125-reattach_attached_run_command-fix'
2013-03-31 00:20:31 -07:00
Guillaume J. Charmes
99f9b69716
Add debug infos in CmdInfo to know the amount of fds and goroutines in use
2013-03-30 10:33:10 -07:00
Guillaume J. Charmes
b336d928fe
Make sure to close all pipes when detaching client ( #228 )
2013-03-30 09:47:09 -07:00
Guillaume J. Charmes
4760749402
Close the containers stdin when the process dies
2013-03-30 09:08:53 -07:00
Guillaume J. Charmes
7efde5eb83
Fix a scope issue preventing the close of slave stdin pty ( #228 )
2013-03-30 09:07:54 -07:00
Guillaume J. Charmes
5252ab697c
Store the master ptys in order to close them when the process dies ( #228 )
2013-03-30 09:05:53 -07:00
Guillaume J. Charmes
41555f67e0
Merge pull request #269 from cespare/gofmt-1
...
Gofmt.
2013-03-30 12:46:47 -07:00
Guillaume J. Charmes
8cceafc834
Add unit test for the #125 scenario. Reattach after client disconnect on stdin allocated container
2013-03-30 06:55:47 -07:00
Caleb Spare
2d4c5ddbdd
Gofmt.
2013-03-29 23:58:30 -07:00
Solomon Hykes
d1ed28cb94
Merge remote-tracking branch 'robryk/cmdstream-deadlock'
2013-03-29 23:43:02 -07:00
Solomon Hykes
7dbb1eacc1
Merge remote-tracking branch 'origin/improve_container_tests'
2013-03-29 23:41:09 -07:00
Robert Obryk
68278b66c5
Added a timeout to TestCmdStreamLargeStderr.
2013-03-29 22:36:36 +01:00
Solomon Hykes
f483b214bb
Merge remote-tracking branch 'robryk/bufreader-race'
2013-03-29 13:50:33 -07:00
Solomon Hykes
f5b458b1dc
Merge pull request #250 from metachord/master
...
Remove unnecessary path parts
2013-03-29 13:42:23 -07:00
Solomon Hykes
f7b4f0c193
FIXME: implement a timeout in TestCmdStreamLArgStderr to avoid blocking the whole test suite when it fails
2013-03-29 13:37:52 -07:00
Solomon Hykes
6ede6bc8f2
Comment CmdStream a little bit to facilitate future fixes and contributions
2013-03-29 13:26:02 -07:00
Solomon Hykes
fdae64d8d7
Merge remote-tracking branch 'robryk/cmdstream-deadlock'
2013-03-29 13:20:17 -07:00
Solomon Hykes
f85e6548c7
Comment to explain CmdStream
2013-03-29 13:18:59 -07:00
Solomon Hykes
c937e237ad
Merged Ctrl-C interception by @creack
2013-03-29 13:12:04 -07:00
Guillaume J. Charmes
0ebdca5e61
Add unit test for multiple attach / restart
2013-03-29 10:56:49 -07:00
Guillaume J. Charmes
81eac415ad
Do not close the stdin of the process when the client deattaches himslef
2013-03-29 09:42:42 -07:00
Guillaume J. Charmes
0b2eee8b33
Fix #108 , reattach now works properly
2013-03-29 09:31:47 -07:00
Solomon Hykes
d0d5d5ff09
Merge pull request #265 from dotcloud/formating_debug_harmonize
...
Formating debug harmonize
2013-03-29 21:30:43 -07:00
Solomon Hykes
57dfca052b
Merge pull request #266 from dotcloud/do_not_log_stopped_container
...
Do not log non-running containers
2013-03-29 21:29:19 -07:00
Solomon Hykes
99b36c2c32
Add comments in graph.go
2013-03-29 21:13:59 -07:00
Solomon Hykes
b013d93786
Merge remote-tracking branch 'origin/264-remove_cmdAttach_option'
2013-03-29 20:30:43 -07:00
Solomon Hykes
b1fa21aa0e
Merge remote-tracking branch 'lopter/master'
2013-03-29 20:17:33 -07:00
Louis Opter
9740102990
Fix output in the login command
...
It was broken because the terminal is in raw mode.
This changeset adds code in the login commmand to do a little bit of
interpretation on the user input (something usually done by the terminal
emulator itself).
2013-03-29 11:39:41 -07:00
Guillaume J. Charmes
0f7a4534c1
Do not log non-running containers
2013-03-29 08:46:06 -07:00
Guillaume J. Charmes
7a565a0479
Remove unused variable from container struct
2013-03-29 08:41:48 -07:00
Guillaume J. Charmes
69c2250ec2
Add some error checking in container monitor
2013-03-29 08:29:59 -07:00
Guillaume J. Charmes
d17f78c373
Harmonize the error management. Use fmt.Errorf instead of errors.New
2013-03-29 08:19:42 -07:00
Guillaume J. Charmes
ccac5b1382
Add debug infos
2013-03-29 08:18:43 -07:00
Guillaume J. Charmes
9442d6b349
Remove the options of CmdAttach
2013-03-29 07:49:26 -07:00
Guillaume J. Charmes
232dbb1864
Improve the containers unit tests (add error checking)
2013-03-29 07:44:58 -07:00
Robert Obryk
58befe3081
Fix a deadlock in CmdStream.
...
As per FIXME, CmdStream could have deadlocked if a command printed
enough on stderr. This commit fixes that, but still keeps all of
the stderr output in memory.
2013-03-29 12:55:48 +01:00
Robert Obryk
d52451bcf8
Fix a race condition in bufReader.
...
The race condition cen be detected by running existing bufReader tests
with Go's race detector.
2013-03-29 11:00:50 +01:00
Maxim Treskin
6d72758f12
Remove unnecessary part of paths to lxc executables
2013-03-29 12:07:25 +07:00
Solomon Hykes
1d6929c8bc
Fixed leftover from docs merge. Thanks @cespare for spotting!
2013-03-28 19:18:03 -07:00
Solomon Hykes
48a208baf1
Merging dhrp/docs
2013-03-28 19:12:58 -07:00
Thatcher Peskens
61cf09b2e7
Fixed some links in gettingstarted
2013-03-28 19:03:06 -07:00
Solomon Hykes
b51fe837a4
Merge pull request #241 from titanous/cleanup-deps
...
Remove unneeded sqlite deps from puppet and debian control
2013-03-28 18:45:44 -07:00
Solomon Hykes
4e11e42546
Merge pull request #244 from dotcloud/docs-julien
...
Docs: Changed the url of the LEGO img to point to the one with copyright
2013-03-28 18:45:20 -07:00
Solomon Hykes
ba33d67a1a
Test that iptables() looks for iptables in the PATH
2013-03-28 18:44:47 -07:00
Solomon Hykes
70853785b6
Merge remote-tracking branch 'shawnsi/iptables-wrapper'
2013-03-28 18:40:02 -07:00
