Timothy Flynn
7ecca42898
CI: Restore the code linting job
...
Unlike in Serenity, let's just run this job once per PR rather than on
every job. This lets us install fewer dependencies on the build-and-test
pipelines.
2024-06-16 15:30:28 -04:00
Andreas Kling
c096608dd9
Meta: Update for GitHub org rename to LadybirdBrowser
2024-06-09 13:02:56 +02:00
Andreas Kling
baf7a2dee7
CI: Update lint-commits workflow to say Ladybird
2024-06-04 09:32:07 +02:00
Tim Ledbetter
319496eb70
Meta/CI: Remove unnecessary github-token usage from lintcommits script
2024-06-03 13:31:15 +02:00
Andreas Kling
2936a9a45e
Meta/CI: Give actions/github-script access to ladybird-bot token
2024-06-03 10:53:53 +02:00
Andreas Kling
4907eb1950
Meta/CI: Use LADYBIRD_BOT_TOKEN to post as ladybird-bot on GitHub
2024-06-03 10:53:53 +02:00
Andrew Kaster
6d3a54e4a8
Meta: Update Documentation and CI for repo move
2024-06-03 10:53:53 +02:00
Andrew Kaster
6ea4c248ab
CI: Update comment-on-pr version
...
This new rev changes the Dockerfile to use a ruby 3 image, just like the
upstream repo.
2024-01-12 11:16:11 -07:00
Idan Horowitz
0befa77b99
CI: Update comment-on-pr version
...
The newer version installs a specific version of octokit, since the
latest version no longer supports the ruby installation in github
actions vms. This should resolve the CI issues.
2024-01-10 09:34:55 +01:00
dependabot[bot]
f1837eded9
CI: Bump actions/github-script from 6 to 7
...
Bumps [actions/github-script](https://github.com/actions/github-script ) from 6 to 7.
- [Release notes](https://github.com/actions/github-script/releases )
- [Commits](https://github.com/actions/github-script/compare/v6...v7 )
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-12-04 07:13:30 -05:00
Jelle Raaijmakers
100c8f9bcf
CI: Add GitHub author presence check in commit linter
...
If GitHub is unable to match a commit's author to a GitHub user, the
`.author` object is set to `null` in the API's response.
2023-01-19 23:48:57 +00:00
Jelle Raaijmakers
6ef8100e25
CI: Ignore dependabot in commit linter for PRs
...
Dependabot cannot be configured to significantly change the way it
formats its commit message, and it currently includes a "Signed-Off-By"
tag which is not allowed by our linter.
This updates our CI commit linter to exclude bots from the checks.
2023-01-18 14:06:05 +00:00
Linus Groh
7c2e134abd
CI: Unify secrets.BUGGIEBOT and secrets.BUGGIEBOT_TOKEN
...
The latter is clearer, so let's use that.
2023-01-06 18:19:42 +01:00
Lucas CHOLLET
fa29214d9a
CI: Fix commit linting for multi-line commit messages
...
Third time's the charm
2022-12-10 17:52:26 +00:00
Lucas CHOLLET
b3478b3613
CI: Correct regex to retrieve git merge commit
...
In 839c1a57
, I wrongly assumed that a matched pattern will raise an
error, it's the opposite. This patch "negates" the regex to solve the
issue.
2022-12-10 16:23:09 +00:00
Lucas CHOLLET
839c1a574d
CI: Add a check to report git merge commit
2022-12-10 12:07:06 +00:00
martinfalisse
432b2aed67
CI: Upgrade actions/github-script
to v6
...
The only breaking change is an internal switch to node 16 which doesn't
seem to affect the functionality of the lintcommits script.
2022-11-25 23:03:59 +01:00
Nathan Wallace
2f1029e7c4
Meta+CI: Upgrade to ubuntu-22.04
...
This commit upgrades Github Actions workers to ubuntu-22.04
As part of that change, we (currently) no longer need the backports
nor toolchain-r/test PPAs, because ubuntu-22.04 include
recent-enough version of QEMU and gcc
2022-05-24 06:30:57 -04:00
Idan Horowitz
a8537ad096
CI: Require a blank line between commit titles and bodies
2022-01-11 23:45:14 +02:00
Brian Gianforcaro
c6c59653ce
CI: Update the lint commits
error message to be more user friendly
...
We often see PR's opened and then immediately closed because folks think
they did something bad, or don't know how to fix the situation. So lets
try to give them a few pointers.
2022-01-07 00:39:12 -08:00
Ben Wiederhake
7ba7668fbb
Meta: Allow overlong 'fixup!' commit titles in pre-commit hook
2021-11-28 11:49:13 -08:00
thislooksfun
d2ef8b29e8
CI: Prevent false errors if a commit message contains CRLF
...
Previously if a commit message contained any carriage returns it would
correctly fail the 'contains CRLF line breaks' test, but it would also
report 'Commit message lines are too long' and 'Commit title ends in a
period', even if neither is true.
2021-11-19 22:30:11 +02:00
thislooksfun
7ee409ef98
CI: Rewrite the lintcommits workflow using an inline script
...
tim-actions/commit-message-checker-with-regex@v0.3.1 only uses the
keys 'sha' and 'commit.message'. Passing more information than that
is unnecessary and can lead to CI failures like this one:
https://github.com/SerenityOS/serenity/runs/4029269017?check_suite_focus=true#step:4:7
Instead of trying to pass data between workflow steps, we can instead
just do it all at once (plus this gives us more control over
formatting, which has also been improved).
2021-10-29 16:51:22 +03:00
Idan Horowitz
24ed8511dd
CI+Meta: Add Signed-off-by tag filter to the commit message linter
2021-09-07 20:46:34 +01:00
Idan Horowitz
350fb0e3db
Meta: Bring lint-commit.sh up to date with the CI commit linter
...
This was missing 2 of the recently added checks. Also added a reminder
in the CI linter to update the Meta (commit hook) version.
2021-07-27 20:41:49 +01:00
Idan Horowitz
34ec0fa8ad
CI: Skip commit linter line length check on lines that contain URLs
2021-07-23 20:27:12 +04:30
Idan Horowitz
f09e361eef
CI: Disallow spaces just before the separating colon in commit titles
2021-07-13 19:56:14 +01:00
Idan Horowitz
69eb05e705
CI: Run the commit linter for Draft Pull Requests
...
The commit linter will now run for draft pull requests as well, but
BuggieBot will not post a message on failing draft PRs.
2021-07-09 21:06:09 +01:00
sin-ack
93996eb48e
CI: Remove incorrect single quote escape
...
The A in YAML stands for Ass-backwards.
2021-06-17 00:07:26 +02:00
sin-ack
129a0fcfb5
CI: Make sure the first word of each commit is capitalized
...
The first word for each commit should be a verb anyway, and this
automates @alimpfard's nits. :^)
2021-06-16 14:41:17 +01:00
Idan Horowitz
6a067e5a1d
CI: Disable the commit linter on draft pull requests
2021-05-29 15:59:47 +01:00
Idan Horowitz
a8ca4751b9
CI: Update comment-on-pr to a version that supports pull_request_target ( #7431 )
...
The previous version unfortunately didn't work for that workflow type if
the author of the PR did not already have write access to the repo.
2021-05-23 23:37:45 +01:00
Idan Horowitz
fd68e606e7
CI: Make BuggieBot reply to pull requests that fail the commit linter
...
This should help reduce the repeating "Please check the contributing
guide" replies from reviewers.
2021-05-23 18:09:54 +02:00