beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Meta: Bring lint-commit.sh up to date with the CI commit linter

Browse source 
This was missing 2 of the recently added checks. Also added a reminder
in the CI linter to update the Meta (commit hook) version.
This commit is contained in:
Idan Horowitz 2021-07-27 22:37:17 +03:00 committed by Linus Groh
parent af3a26f4cc
commit 350fb0e3db
Notes: sideshowbarker 2024-07-18 08:01:41 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/350fb0e3dbe
Pull-request: https://github.com/SerenityOS/serenity/pull/9045
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/lintcommits.yml vendored
View file

@ -2,6 +2,8 @@ name: Commit linter
on: [pull_request_target]
# Make sure to update Meta/lint-commit.sh to match this script when adding new checks!
jobs:
lint_commits:
runs-on: ubuntu-20.04

8
Meta/lint-commit.sh
View file

@ -28,11 +28,17 @@ while read -r line; do
error "Missing category in commit title (if this is a fix up of a previous commit, it should be squashed)"
fi
title_case_pattern="^\S.*?: [A-Z0-9]"
if [[ $line_number -eq 1 ]] && (echo "$line" | grep -P -v -q "$title_case_pattern"); then
error "First word of commit after the subsystem is not capitalized"
fi
if [[ $line_number -eq 1 ]] && [[ "$line" =~ \.$ ]]; then
error "Commit title ends in a period"
fi
if [[ $line_length -gt 72 ]]; then
url_pattern="([a-z]+:\/\/)?(([a-zA-Z0-9_]|-)+\.)+[a-z]{2,}(:\d+)?([a-zA-Z_0-9@:%\+.~\?&\/=]|-)+"
if [[ $line_length -gt 72 ]] && (echo "$line" | grep -P -v -q "$url_pattern"); then
error "Commit message lines are too long (maximum allowed is 72 characters)"
fi
done <"$commit_file"