beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Normalize the angle delta in CanvasPath::ellipse()

Browse source 
This fixes both the incorrect arc and ellipse from #22817.
This commit is contained in:
MacDue 2024-03-24 15:17:50 +00:00 committed by Andreas Kling
parent b31fb36ed3
commit c6899b79b6
Notes: sideshowbarker 2024-07-17 02:56:25 +09:00 
Author: https://github.com/MacDue
Commit: https://github.com/SerenityOS/serenity/commit/c6899b79b6
Pull-request: https://github.com/SerenityOS/serenity/pull/23701
4 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
Tests/LibWeb/Ref/canvas-arcs-and-ellipses.html Normal file
View file

@ -0,0 +1,22 @@
<link rel="match" href="reference/canvas-arcs-and-ellipses-ref.html" />
<style>
canvas {
border: 1px solid black;
image-rendering: pixelated;
}
</style>
<canvas id="canvas" width="125" height="125"></canvas>
<script>
const canvas = document.getElementById("canvas")
const context = canvas.getContext("2d");
context.beginPath();
context.arc(59, 55, 38, 5.3849570248895775, 2.9421639085067177);
context.stroke();
context.fill();
context.beginPath();
context.ellipse(20,20,15,8,1.2273132071162383,4.1926143018618225,2.8853539230051624);
context.stroke();
context.fill();
</script>

9
Tests/LibWeb/Ref/reference/canvas-arcs-and-ellipses-ref.html Normal file
View file

@ -0,0 +1,9 @@
<style>
* {
margin: 0;
}
body {
background-color: white;
}
</style>
<img src="./images/canvas-arcs-and-ellipses-ref.png">

BIN
Tests/LibWeb/Ref/reference/images/canvas-arcs-and-ellipses-ref.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 999 B

2
Userland/Libraries/LibWeb/HTML/Canvas/CanvasPath.cpp
View file

@ -157,6 +157,8 @@ WebIDL::ExceptionOr<void> CanvasPath::ellipse(float x, float y, float radius_x,
auto end_point = resolve_point_with_angle(end_angle);
auto delta_theta = end_angle - start_angle;
if (delta_theta < 0)
delta_theta += AK::Pi<float> * 2;
auto transform = active_transform();