beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Reschedule repaint for navigables with ongoing painting

Browse source 
Fixes delayed repainting in the following case:
1. Style or layout invalidation triggers html event loop processing.
2. Event loop processing does nothing because there is no rendering
   opportunity.
3. Style or layout change won't be reflected until something else
   triggers event loop processing
This commit is contained in:
Aliaksandr Kalenik 2024-03-24 13:22:01 +01:00 committed by Andreas Kling
parent 3bdfca1119
commit b31fb36ed3
Notes: sideshowbarker 2024-07-16 22:26:05 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/b31fb36ed3
Pull-request: https://github.com/SerenityOS/serenity/pull/23698
Reviewed-by: https://github.com/nico
2 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -196,6 +196,22 @@ void EventLoop::process()
}
};
// AD-HOC: Since event loop processing steps do not constantly running in parallel, and
// something must trigger them, we need to manually schedule a repaint for all
// navigables that do not have a rendering opportunity at this event loop iteration.
// Otherwise their repaint will be delayed until something else will trigger event
// loop processing.
for_each_fully_active_document_in_docs([&](DOM::Document& document) {
auto navigable = document.navigable();
if (navigable && navigable->has_a_rendering_opportunity())
return;
auto* browsing_context = document.browsing_context();
if (!browsing_context)
return;
auto& page = browsing_context->page();
page.client().schedule_repaint();
});
// 2. Rendering opportunities: Remove from docs all Document objects whose node navigables do not have a rendering opportunity.
docs.remove_all_matching([&](auto& document) {
auto navigable = document->navigable();

7
Userland/Services/WebContent/PageClient.cpp
View file

@ -105,8 +105,11 @@ void PageClient::ready_to_paint()
{
auto old_paint_state = exchange(m_paint_state, PaintState::Ready);
if (old_paint_state == PaintState::PaintWhenReady)
schedule_repaint();
if (old_paint_state == PaintState::PaintWhenReady) {
// NOTE: Repainting always has to be scheduled from HTML event loop processing steps
// to make sure style and layout are up-to-date.
page().top_level_traversable()->set_needs_display();
}
}
void PageClient::add_backing_store(i32 front_bitmap_id, Gfx::ShareableBitmap const& front_bitmap, i32 back_bitmap_id, Gfx::ShareableBitmap const& back_bitmap)