beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Revert "WebContent: Limit the Console client to the top-level navigable"

Browse source 
This reverts commit 758f4887bc.

This commit was causing ASAN to complain about a use-after-poison, see
https://github.com/LadybirdBrowser/ladybird/issues/809
This commit is contained in:
Sam Atkins 2024-07-24 15:28:27 +01:00
parent 6ae9b54f11
commit 6160400ab7
Notes: github-actions[bot] 2024-07-24 15:45:41 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6160400ab72
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/810
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Services/WebContent/PageClient.cpp
View file

@ -342,13 +342,8 @@ void PageClient::page_did_create_new_document(Web::DOM::Document& document)
void PageClient::page_did_change_active_document_in_top_level_browsing_context(Web::DOM::Document& document)
{
auto& realm = document.realm();
VERIFY(m_console_clients.contains(document));
m_top_level_document_console_client = *m_console_clients.get(document).value();
auto console_object = realm.intrinsics().console_object();
console_object->console().set_client(*m_top_level_document_console_client);
}
void PageClient::page_did_destroy_document(Web::DOM::Document& document)
@ -671,6 +666,7 @@ void PageClient::initialize_js_console(Web::DOM::Document& document)
auto& realm = document.realm();
auto console_object = realm.intrinsics().console_object();
auto console_client = heap().allocate_without_realm<WebContentConsoleClient>(console_object->console(), document.realm(), *this);
console_object->console().set_client(*console_client);
m_console_clients.set(document, console_client);
}