From 6160400ab7217f1977b10641cafe42f3ade77337 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 24 Jul 2024 15:28:27 +0100 Subject: [PATCH] Revert "WebContent: Limit the Console client to the top-level navigable" This reverts commit 758f4887bc1a2bbbf111fb3bee120e491322ba32. This commit was causing ASAN to complain about a use-after-poison, see https://github.com/LadybirdBrowser/ladybird/issues/809 --- Userland/Services/WebContent/PageClient.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Userland/Services/WebContent/PageClient.cpp b/Userland/Services/WebContent/PageClient.cpp index 8cdfdbd4e49..0c87fb3c26d 100644 --- a/Userland/Services/WebContent/PageClient.cpp +++ b/Userland/Services/WebContent/PageClient.cpp @@ -342,13 +342,8 @@ void PageClient::page_did_create_new_document(Web::DOM::Document& document) void PageClient::page_did_change_active_document_in_top_level_browsing_context(Web::DOM::Document& document) { - auto& realm = document.realm(); - VERIFY(m_console_clients.contains(document)); m_top_level_document_console_client = *m_console_clients.get(document).value(); - - auto console_object = realm.intrinsics().console_object(); - console_object->console().set_client(*m_top_level_document_console_client); } void PageClient::page_did_destroy_document(Web::DOM::Document& document) @@ -671,6 +666,7 @@ void PageClient::initialize_js_console(Web::DOM::Document& document) auto& realm = document.realm(); auto console_object = realm.intrinsics().console_object(); auto console_client = heap().allocate_without_realm(console_object->console(), document.realm(), *this); + console_object->console().set_client(*console_client); m_console_clients.set(document, console_client); }