beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
ladybird/Userland/Libraries/LibGfx/Painter.h

157 lines
7.8 KiB
C
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 08:38:21 +00:00
/*
LibGfx: Adjust parameter order for Painter::draw_ui_text() Let's put the rect first so it's the same as draw_text().
2021-04-09 09:09:48 +00:00
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 08:38:21 +00:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 08:24:48 +00:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 08:38:21 +00:00
*/
Intense hacking on Widgets.
2018-10-10 14:49:36 +00:00
#pragma once
LibGfx: More work on header dependency reduction
2020-02-14 22:28:42 +00:00
#include <AK/Forward.h>
LibGfx: Move a bunch of LogStream::operator<< to cpp files
2020-02-14 23:58:14 +00:00
#include <AK/NonnullRefPtr.h>
AK: Add a forward declaration header You can now #include <AK/Forward.h> to get most of the AK types as forward declarations. Header dependency explosion is one of the main contributors to compile times at the moment, so this is a step towards smaller include graphs.
2020-02-14 20:41:10 +00:00
#include <AK/Vector.h>
#include <LibGfx/Color.h>
LibGfx: More work on header dependency reduction
2020-02-14 22:28:42 +00:00
#include <LibGfx/Forward.h>
AK: Add a forward declaration header You can now #include <AK/Forward.h> to get most of the AK types as forward declarations. Header dependency explosion is one of the main contributors to compile times at the moment, so this is a step towards smaller include graphs.
2020-02-14 20:41:10 +00:00
#include <LibGfx/Point.h>
#include <LibGfx/Rect.h>
#include <LibGfx/Size.h>
LibGfx: Rename from LibDraw :^)
2020-02-06 11:04:00 +00:00
#include <LibGfx/TextAlignment.h>
#include <LibGfx/TextElision.h>
Intense hacking on Widgets.
2018-10-10 14:49:36 +00:00
LibDraw: Put all classes in the Gfx namespace I started adding things to a Draw namespace, but it somehow felt really wrong seeing Draw::Rect and Draw::Bitmap, etc. So instead, let's rename the library to LibGfx. :^)
2020-02-06 10:56:38 +00:00
namespace Gfx {
Intense hacking on Widgets.
2018-10-10 14:49:36 +00:00
class Painter {
public:
LibGfx: Give Bitmap a scale factor Gfx::Bitmap can now store its scale factor. Normally it's 1, but in high dpi mode it can be 2. If a Bitmap with a scale factor of 2 is blitted to a Painter with scale factor of 2, the pixels can be copied over without any resampling. (When blitting a Bitmap with a scale factor of 1 to a Painter with scale factor of 2, the Bitmap is painted at twice its width and height at paint time. Blitting a Bitmap with a scale factor of 2 to a Painter with scale factor 1 is not supported.) A Bitmap with scale factor of 2 reports the same width() and height() as one with scale factor 1. That's important because many places in the codebase use a bitmap's width() and height() to layout Widgets, and all widget coordinates are in logical coordinates as well, per Documentation/HighDPI.md. Bitmap grows physical_width() / physical_height() to access the actual pixel size. Update a few callers that work with pixels to call this instead. Make Painter's constructor take its scale factor from the target bitmap that's passed in, and update its various blit() methods to handle blitting a 2x bitmap to a 2x painter. This allows removing some gnarly code in Compositor. (In return, put some new gnarly code in LibGfxScaleDemo to preserve behavior there.) No intended behavior change.
2021-01-19 17:10:47 +00:00
explicit Painter(Gfx::Bitmap&);
Intense hacking on Widgets.
2018-10-10 14:49:36 +00:00
~Painter();
LibGfx: Replace 'bool dotted' with a LineStyle::{Solid,Dotted} enum Just a bool is insufficient as we'll have to support dashed lines as well.
2020-05-10 10:58:33 +00:00
enum class LineStyle {
Solid,
Dotted,
LibGfx: Add support for dashed lines Non-configurable for now.
2020-05-10 15:17:26 +00:00
Dashed,
LibGfx: Replace 'bool dotted' with a LineStyle::{Solid,Dotted} enum Just a bool is insufficient as we'll have to support dashed lines as well.
2020-05-10 10:58:33 +00:00
};
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void clear_rect(const IntRect&, Color);
void fill_rect(const IntRect&, Color);
void fill_rect_with_dither_pattern(const IntRect&, Color, Color);
void fill_rect_with_checkerboard(const IntRect&, const IntSize&, Color color_dark, Color color_light);
void fill_rect_with_gradient(Orientation, const IntRect&, Color gradient_start, Color gradient_end);
void fill_rect_with_gradient(const IntRect&, Color gradient_start, Color gradient_end);
void fill_ellipse(const IntRect&, Color);
Revert "LibGfx: Add directional floating-point scaling to Painter" This reverts commit ff76a5b8d2e4dfe007c20a1376cb6862a2c2dbe0.
2021-05-03 14:37:05 +00:00
void draw_rect(const IntRect&, Color, bool rough = false);
LibGUI+LibGfx: Improve focus rect appearance Draw a dotted focus rect to make it stand out more. Also make it much larger on regular text-only GUI::Buttons.
2020-10-26 19:43:59 +00:00
void draw_focus_rect(const IntRect&, Color);
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void draw_bitmap(const IntPoint&, const CharacterBitmap&, Color = Color());
void draw_bitmap(const IntPoint&, const GlyphBitmap&, Color = Color());
LibGfx: Add elliptical curves to Path
2020-07-22 06:46:15 +00:00
void draw_scaled_bitmap(const IntRect& dst_rect, const Gfx::Bitmap&, const IntRect& src_rect, float opacity = 1.0f);
LibGfx: Add a draw_scaled_bitmap() variant that takes a FloatRect as src_rect Consider draw_scaled_bitmap({0, 0, 10, 10}, source, {0, 0, 5, 5}). Imagine wanting to split that up into two calls, like e.g. the compositor when redrawing the background with damage rects. You really want to be able to say draw_scaled_bitmap({0, 0, 5, 10}, source, {0, 0, 2.5, 5}) but up to now you couldn't. Now you can. This makes painting very low-res images (such as tile.png) in mode "stretch" work much better.
2021-01-22 20:13:47 +00:00
void draw_scaled_bitmap(const IntRect& dst_rect, const Gfx::Bitmap&, const FloatRect& src_rect, float opacity = 1.0f);
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void draw_triangle(const IntPoint&, const IntPoint&, const IntPoint&, Color);
void draw_ellipse_intersecting(const IntRect&, Color, int thickness = 1);
void set_pixel(const IntPoint&, Color);
LibGUI+LibGfx: Implement upside-down appearance for bottom-side tabs GUI::TabWidget has long has a TabPosition::Bottom option, but we still rendered the tab buttons the same as TabPosition::Top. This patch implements a custom look for bottom-side tabs. I've done my best to match the look of the top-side ones, but there might be some improvements we can make here. :^)
2020-08-23 21:39:27 +00:00
void set_pixel(int x, int y, Color color) { set_pixel({ x, y }, color); }
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void draw_line(const IntPoint&, const IntPoint&, Color, int thickness = 1, LineStyle style = LineStyle::Solid);
void draw_quadratic_bezier_curve(const IntPoint& control_point, const IntPoint&, const IntPoint&, Color, int thickness = 1, LineStyle style = LineStyle::Solid);
LibGfx: Add elliptical curves to Path
2020-07-22 06:46:15 +00:00
void draw_elliptical_arc(const IntPoint& p1, const IntPoint& p2, const IntPoint& center, const FloatPoint& radii, float x_axis_rotation, float theta_1, float theta_delta, Color, int thickness = 1, LineStyle style = LineStyle::Solid);
WindowServer: Implement simple window shadows This implements simple window shadows around most windows, including tooltips. Because this method uses a bitmap for the shadow bits, it is limited to rectangular window frames. For non-rectangular window frames we'll need to implement a more sophisticated algorithm.
2021-02-09 00:27:51 +00:00
void blit(const IntPoint&, const Gfx::Bitmap&, const IntRect& src_rect, float opacity = 1.0f, bool apply_alpha = true);
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void blit_dimmed(const IntPoint&, const Gfx::Bitmap&, const IntRect& src_rect);
void blit_brightened(const IntPoint&, const Gfx::Bitmap&, const IntRect& src_rect);
void blit_filtered(const IntPoint&, const Gfx::Bitmap&, const IntRect& src_rect, Function<Color(Color)>);
void draw_tiled_bitmap(const IntRect& dst_rect, const Gfx::Bitmap&);
void blit_offset(const IntPoint&, const Gfx::Bitmap&, const IntRect& src_rect, const IntPoint&);
LibGUI+LibGfx+WindowServer: Auto-generate disabled action icons :^) This patch adds a simple filter that makes button and menu item icons have that "'90s disabled" look when disabled. It's pretty awesome.
2020-10-27 20:17:50 +00:00
void blit_disabled(const IntPoint&, const Gfx::Bitmap&, const IntRect&, const Palette&);
LibWeb: Make CSS background image painting respect destination origin and transparency It was previously using draw_tiled_bitmap, which always aligns the tiles with the global origin and does not respect the alpha of the source. Switch to a new Painter::blit_tiled helper which uses Painter::blit under the hood, which has more correct behavior.
2021-03-06 00:42:50 +00:00
void blit_tiled(const IntRect&, const Gfx::Bitmap&, const IntRect& src_rect);
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void draw_text(const IntRect&, const StringView&, const Font&, TextAlignment = TextAlignment::TopLeft, Color = Color::Black, TextElision = TextElision::None);
void draw_text(const IntRect&, const StringView&, TextAlignment = TextAlignment::TopLeft, Color = Color::Black, TextElision = TextElision::None);
void draw_text(const IntRect&, const Utf32View&, const Font&, TextAlignment = TextAlignment::TopLeft, Color = Color::Black, TextElision = TextElision::None);
void draw_text(const IntRect&, const Utf32View&, TextAlignment = TextAlignment::TopLeft, Color = Color::Black, TextElision = TextElision::None);
LibGfx: Reduce code duplication in Painter::draw_text Use the same logic for all variants for Painter::draw_text. Also, add an overload that allows taking a callback function for custom gylph drawing. This allows drawing some glyphs differently in the correct location when drawing more complex strings (e.g. multi-line, elisions, etc).
2020-10-20 15:51:04 +00:00
void draw_text(Function<void(const IntRect&, u32)>, const IntRect&, const StringView&, const Font&, TextAlignment = TextAlignment::TopLeft, TextElision = TextElision::None);
void draw_text(Function<void(const IntRect&, u32)>, const IntRect&, const Utf8View&, const Font&, TextAlignment = TextAlignment::TopLeft, TextElision = TextElision::None);
void draw_text(Function<void(const IntRect&, u32)>, const IntRect&, const Utf32View&, const Font&, TextAlignment = TextAlignment::TopLeft, TextElision = TextElision::None);
LibGfx: Add a Gfx::TextAlignment parameter to Painter::draw_ui_text()
2021-04-09 09:15:41 +00:00
void draw_ui_text(const Gfx::IntRect&, const StringView&, const Gfx::Font&, TextAlignment, Gfx::Color);
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void draw_glyph(const IntPoint&, u32, Color);
void draw_glyph(const IntPoint&, u32, const Font&, Color);
void draw_emoji(const IntPoint&, const Gfx::Bitmap&, const Font&);
Unicode: Try s/codepoint/code_point/g again This time, without trailing 's'. Ran: git grep -l 'codepoint' | xargs sed -ie 's/codepoint/code_point/g
2020-08-05 20:31:20 +00:00
void draw_glyph_or_emoji(const IntPoint&, u32 code_point, const Font&, Color);
Update Painter class to the new coding style.
2019-01-12 16:02:54 +00:00
LibGfx: Implement filling paths There are some imperfections with intersecting edges (because the main algorithm used is scanline, and that is not geared towards drawing complex shapes), however, it behaves mostly fine for normal use :^)
2020-05-06 07:25:12 +00:00
static void for_each_line_segment_on_bezier_curve(const FloatPoint& control_point, const FloatPoint& p1, const FloatPoint& p2, Function<void(const FloatPoint&, const FloatPoint&)>&);
static void for_each_line_segment_on_bezier_curve(const FloatPoint& control_point, const FloatPoint& p1, const FloatPoint& p2, Function<void(const FloatPoint&, const FloatPoint&)>&&);
LibGfx: Add elliptical curves to Path
2020-07-22 06:46:15 +00:00
static void for_each_line_segment_on_elliptical_arc(const FloatPoint& p1, const FloatPoint& p2, const FloatPoint& center, const FloatPoint radii, float x_axis_rotation, float theta_1, float theta_delta, Function<void(const FloatPoint&, const FloatPoint&)>&);
static void for_each_line_segment_on_elliptical_arc(const FloatPoint& p1, const FloatPoint& p2, const FloatPoint& center, const FloatPoint radii, float x_axis_rotation, float theta_1, float theta_delta, Function<void(const FloatPoint&, const FloatPoint&)>&&);
LibGfx: Add Gfx::Path, a basic 2D path with <canvas> semantics This will be used to implement painting of 2D paths. This first patch adds support for line_to(), move_to() and close(). It will try to have the same semantics as the HTML <canvas> element. To stroke a Path, simply pass it to Painter::stroke_path().
2020-04-16 19:03:17 +00:00
void stroke_path(const Path&, Color, int thickness);
LibGfx: Implement filling paths There are some imperfections with intersecting edges (because the main algorithm used is scanline, and that is not geared towards drawing complex shapes), however, it behaves mostly fine for normal use :^)
2020-05-06 07:25:12 +00:00
enum class WindingRule {
Nonzero,
EvenOdd,
};
void fill_path(Path&, Color, WindingRule rule = WindingRule::Nonzero);
SharedGraphics: Give painter a state stack and save()/restore() operations. This will make some painting code a lot less confusing since there's no need to manually undo translations, clips, etc.
2019-03-09 15:48:02 +00:00
const Font& font() const { return *state().font; }
void set_font(const Font& font) { state().font = &font; }
Add a simple Font class.
2018-10-11 21:45:57 +00:00
Meta: Tweak .clang-format to not wrap braces after enums.
2019-06-07 15:13:23 +00:00
enum class DrawOp {
WindowServer: Clang-Format
2019-06-05 16:22:11 +00:00
Copy,
LibGfx: Add ability to draw inverted rectangles
2020-09-08 04:25:30 +00:00
Xor,
Invert
WindowServer: Clang-Format
2019-06-05 16:22:11 +00:00
};
SharedGraphics: Give painter a state stack and save()/restore() operations. This will make some painting code a lot less confusing since there's no need to manually undo translations, clips, etc.
2019-03-09 15:48:02 +00:00
void set_draw_op(DrawOp op) { state().draw_op = op; }
DrawOp draw_op() const { return state().draw_op; }
Hook up the PS2MouseDevice to the AbstractScreen+WindowManager. Render the mouse cursor by xor'ing the pixels. I don't know anything about hardware cursors yet and this way we don't need to recompose the window hierarchy every time you move the mouse. :^)
2019-01-11 02:52:09 +00:00
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void add_clip_rect(const IntRect& rect);
Let userland retain the window backing store while drawing into it. To start painting, call: gui$get_window_backing_store() Then finish up with: gui$release_window_backing_store() Process will retain the underlying GraphicsBitmap behind the scenes. This fixes racing between the WindowServer and GUI clients. This patch also adds a WSWindowLocker that is exactly what it sounds like.
2019-01-24 22:40:12 +00:00
void clear_clip_rect();
FontEditor: Minor UI improvements. - Implement focus for custom widgets. - Add two live demo labels with an English pangram in upper/lower case.
2019-02-04 14:37:23 +00:00
Revert "LibGfx: Add directional floating-point scaling to Painter" This reverts commit ff76a5b8d2e4dfe007c20a1376cb6862a2c2dbe0.
2021-05-03 14:37:05 +00:00
void translate(int dx, int dy) { translate({ dx, dy }); }
void translate(const IntPoint& delta) { state().translation.translate_by(delta); }
GTextEditor: Improvements to cursor rendering. The view now scrolls along with you as you move the cursor around.
2019-03-07 12:13:25 +00:00
LibDraw: Put all classes in the Gfx namespace I started adding things to a Draw namespace, but it somehow felt really wrong seeing Draw::Rect and Draw::Bitmap, etc. So instead, let's rename the library to LibGfx. :^)
2020-02-06 10:56:38 +00:00
Gfx::Bitmap* target() { return m_target.ptr(); }
Port Terminal to LibGUI. To facilitate listening for action on arbitrary file descriptors, I've added a GNotifier class. It's quite simple but very useful: GNotifier notifier(fd, GNotifier::Read); notifier.on_ready_to_read = [this] (GNotifier& fd) { // read from fd or whatever else you like :^) }; The callback will get invoked by GEventLoop when select() says we have something to read on the fd.
2019-02-10 13:28:39 +00:00
SharedGraphics: Give painter a state stack and save()/restore() operations. This will make some painting code a lot less confusing since there's no need to manually undo translations, clips, etc.
2019-03-09 15:48:02 +00:00
void save() { m_state_stack.append(m_state_stack.last()); }
WindowServer: Clang-Format
2019-06-05 16:22:11 +00:00
void restore()
{
Everywhere: Rename ASSERT => VERIFY (...and ASSERT_NOT_REACHED => VERIFY_NOT_REACHED) Since all of these checks are done in release builds as well, let's rename them to VERIFY to prevent confusion, as everyone is used to assertions being compiled out in release. We can introduce a new ASSERT macro that is specifically for debug checks, but I'm doing this wholesale conversion first since we've accumulated thousands of these already, and it's not immediately obvious which ones are suitable for ASSERT.
2021-02-23 19:42:32 +00:00
VERIFY(m_state_stack.size() > 1);
WindowServer: Clang-Format
2019-06-05 16:22:11 +00:00
m_state_stack.take_last();
}
SharedGraphics: Give painter a state stack and save()/restore() operations. This will make some painting code a lot less confusing since there's no need to manually undo translations, clips, etc.
2019-03-09 15:48:02 +00:00
LibGUI: Improve IconView rubberband performance Rather than invalidating the entire window, which is very expensive on the transparent desktop widget, just invalidate the areas that actually need updating.
2021-02-16 02:30:47 +00:00
IntRect clip_rect() const { return state().clip_rect; }
LibGUI: Add a GPainter class that inherits from Painter. This gets rid of the last little piece of LibGUI knowledge in Painter.
2019-03-28 16:19:56 +00:00
protected:
Revert "LibGfx: Add directional floating-point scaling to Painter" This reverts commit ff76a5b8d2e4dfe007c20a1376cb6862a2c2dbe0.
2021-05-03 14:37:05 +00:00
IntPoint translation() const { return state().translation; }
IntRect to_physical(const IntRect& r) const { return r.translated(translation()) * scale(); }
IntPoint to_physical(const IntPoint& p) const { return p.translated(translation()) * scale(); }
int scale() const { return state().scale; }
LibGfx: Make Painter::draw_rect() scale-aware Needed for the window server minimize animation. draw_rect() can't just call draw_line() because that isn't draw_op()-aware. The draw_op()-awareness in Painter looks a bit ad-hoc, but that's for another day.
2021-01-13 01:22:15 +00:00
void set_physical_pixel_with_draw_op(u32& pixel, const Color&);
void fill_physical_scanline_with_draw_op(int y, int x, int width, const Color& color);
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
void fill_rect_with_draw_op(const IntRect&, Color);
LibGfx: Enable Painter::blit to apply opacity and mix alpha channels This enables us to properly render windows that use both opacity and alpha channels.
2021-02-13 18:10:27 +00:00
void blit_with_opacity(const IntPoint&, const Gfx::Bitmap&, const IntRect& src_rect, float opacity, bool apply_alpha = true);
Revert "LibGfx: Add directional floating-point scaling to Painter" This reverts commit ff76a5b8d2e4dfe007c20a1376cb6862a2c2dbe0.
2021-05-03 14:37:05 +00:00
void draw_physical_pixel(const IntPoint&, Color, int thickness = 1);
Hook up the PS2MouseDevice to the AbstractScreen+WindowManager. Render the mouse cursor by xor'ing the pixels. I don't know anything about hardware cursors yet and this way we don't need to recompose the window hierarchy every time you move the mouse. :^)
2019-01-11 02:52:09 +00:00
SharedGraphics: Give painter a state stack and save()/restore() operations. This will make some painting code a lot less confusing since there's no need to manually undo translations, clips, etc.
2019-03-09 15:48:02 +00:00
struct State {
const Font* font;
Revert "LibGfx: Add directional floating-point scaling to Painter" This reverts commit ff76a5b8d2e4dfe007c20a1376cb6862a2c2dbe0.
2021-05-03 14:37:05 +00:00
IntPoint translation;
int scale = 1;
LibGfx/Painter: Keep translation and clip_rect in logical coordinates Moves Painter away from general affine transport support a bit, but this scale factor business does feel like it's a bit different. This is conceptually cleaner (everything should use logical coordinates as much as possible), and it means the code in GUI::Painter() will work without changes due to that, but the draw function implementations overall get a bit murkier (draw_rect() becomes nicer though). Still, feels like the right direction. No behavior change.
2021-01-20 14:59:22 +00:00
IntRect clip_rect;
SharedGraphics: Give painter a state stack and save()/restore() operations. This will make some painting code a lot less confusing since there's no need to manually undo translations, clips, etc.
2019-03-09 15:48:02 +00:00
DrawOp draw_op;
};
State& state() { return m_state_stack.last(); }
const State& state() const { return m_state_stack.last(); }
Revert "LibGfx: Add directional floating-point scaling to Painter" This reverts commit ff76a5b8d2e4dfe007c20a1376cb6862a2c2dbe0.
2021-05-03 14:37:05 +00:00
void fill_physical_rect(const IntRect&, Color);
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
IntRect m_clip_origin;
LibDraw: Put all classes in the Gfx namespace I started adding things to a Draw namespace, but it somehow felt really wrong seeing Draw::Rect and Draw::Bitmap, etc. So instead, let's rename the library to LibGfx. :^)
2020-02-06 10:56:38 +00:00
NonnullRefPtr<Gfx::Bitmap> m_target;
Sprinkle use of AK::Vector in various places. Some of these are less helpful than others. Avoiding a bunch of mallocs in the event loop wakeup code is definitely nice.
2019-04-20 12:02:19 +00:00
Vector<State, 4> m_state_stack;
Intense hacking on Widgets.
2018-10-10 14:49:36 +00:00
};
SharedGraphics: Add PainterStateSaver RAII helper and Point::operator-(). Two little things to help tidy up a bit in WSWindowManager.
2019-03-09 15:54:41 +00:00
class PainterStateSaver {
public:
SharedGraphics: Move PainterStateSaver out of line.
2019-04-15 23:01:03 +00:00
explicit PainterStateSaver(Painter&);
~PainterStateSaver();
SharedGraphics: Add PainterStateSaver RAII helper and Point::operator-(). Two little things to help tidy up a bit in WSWindowManager.
2019-03-09 15:54:41 +00:00
private:
Painter& m_painter;
};
LibDraw: Put all classes in the Gfx namespace I started adding things to a Draw namespace, but it somehow felt really wrong seeing Draw::Rect and Draw::Bitmap, etc. So instead, let's rename the library to LibGfx. :^)
2020-02-06 10:56:38 +00:00
LibGUI+LibGfx: Collapse the '&' from Alt shortcuts in tooltip texts Also resolve a FIXME about using GUI::Label auto-sizing since we're changing this code and it simplifies what we're doing. Fixes #6219.
2021-04-10 23:09:44 +00:00
String parse_ampersand_string(const StringView&, Optional<size_t>* underline_offset = nullptr);
LibDraw: Put all classes in the Gfx namespace I started adding things to a Draw namespace, but it somehow felt really wrong seeing Draw::Rect and Draw::Bitmap, etc. So instead, let's rename the library to LibGfx. :^)
2020-02-06 10:56:38 +00:00
}
Reference in a new issue Copy permalink