beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
ladybird/CMakeLists.txt

392 lines
16 KiB
Text
Raw Normal View History

Build: Allow using CMake 3.16 Because apparently that's what a lot of people have, and they report it works fine.
2020-05-15 07:52:37 +00:00
cmake_minimum_required(VERSION 3.16)
project(SerenityOS C CXX ASM)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
cmake: Make setting CMAKE_BUILD_TYPE an error. I tried setting it to Release, then noticed that it didn't build due to gcc's optimizer-level dependent warnings and -Werror, then started fixing the warnings for a bit (all false positives), then looked at the global CMakeLists.txt and realized that the default build is aleady using compiler optimizations. It looks like people aren't supposed to change this, so make that explicit to be friendly to people familiar with cmake but new to serenity.
2020-06-06 01:23:31 +00:00
if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "")
CMake: Fix message levels for error conditions during configuration Make messages which should be fatal, actually fail the build. - FATAL is not a valid mode keyword. The full list is available in the docs: https://cmake.org/cmake/help/v3.19/command/message.html - SEND_ERROR doesn't immediately stop processing, FATAL_ERROR does. We should immediately stop if the Toolchain is not present. - The app icon size validation was just a WARNING that is easy to overlook. We should promote it to a FATAL_ERROR so that people will not overlook the issue when adding a new application. We can only make the small icon message FATAL_ERROR, as there is currently one violation of the medium app icon validation.
2021-05-13 11:15:35 +00:00
message(FATAL_ERROR
cmake: Make setting CMAKE_BUILD_TYPE an error. I tried setting it to Release, then noticed that it didn't build due to gcc's optimizer-level dependent warnings and -Werror, then started fixing the warnings for a bit (all false positives), then looked at the global CMakeLists.txt and realized that the default build is aleady using compiler optimizations. It looks like people aren't supposed to change this, so make that explicit to be friendly to people familiar with cmake but new to serenity.
2020-06-06 01:23:31 +00:00
": Don't use CMAKE_BUILD_TYPE when building serenity.\n"
"The default build type is optimized with debug info and asserts enabled,\n"
"and that's all there is.")
endif()
CMake: Verify the GCC host version is new enough to build serenity There are lots of people who have issues building serenity because they don't read the build directions closely enough and have an unsupported GCC version as their host compiler. Instead of repeatedly having to answer these kinds of questions, lets just error out upfront.
2021-05-31 08:18:22 +00:00
if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 10.2)
message(FATAL_ERROR
"A GCC version less than 10.2 was detected (${CMAKE_CXX_COMPILER_VERSION}), this is unsupported.\n"
"Please re-read the build instructions documentation, and upgrade your host compiler.\n")
endif()
CMake: Make the install step more zen The "Installing $foo..." messages are just noise, so turn them off.
2020-06-19 14:52:39 +00:00
set(CMAKE_INSTALL_MESSAGE NEVER)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
enable_testing()
CMake: compile_commands.json output Problem: - CMake is not outputting `compile_commands.json`. - `compile_commands.json` is used by build integration tooling such as `clang-tidy`. Solution: - Enable `CMAKE_EXPORT_COMPILE_COMMANDS` option so that the file is output.
2020-11-11 22:59:06 +00:00
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
Build: Support non-i686 toolchains * Add SERENITY_ARCH option to CMake for selecting the target toolchain * Port all build scripts but continue to use i686 * Update GitHub Actions cache to include BuildIt.sh
2020-12-29 03:38:52 +00:00
set(SERENITY_ARCH "i686" CACHE STRING "Target architecture for SerenityOS.")
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
if("${SERENITY_ARCH}" STREQUAL "i686")
set(SERENITY_CLANG_ARCH "i386")
else()
set(SERENITY_CLANG_ARCH ${SERENITY_ARCH})
endif()
CMake: Add public cmake option to document ENABLE_ALL_THE_DEBUG_MACROS - Making this an option makes this option visible to users and tooling. - Rename `ALL_THE_DEBUG_MACROS` -> `ENABLE_ALL_THE_DEBUG_MACROS`.
2021-01-01 10:26:52 +00:00
# Central location for all custom options used in the Serenity build.
AK: Rename {DBGLN_NO => ENABLE}_COMPILETIME_FORMAT_CHECK This is no longer limited to dbgln(). Also invert it to match all the other ENABLE_FOO options.
2021-02-23 17:14:04 +00:00
option(ENABLE_ADDRESS_SANITIZER "Enable address sanitizer testing in gcc/clang" OFF)
option(ENABLE_KERNEL_ADDRESS_SANITIZER "Enable kernel address sanitizer testing in gcc/clang" OFF)
Kernel: Add option to build with coverage instrumentation and KCOV GCC and Clang allow us to inject a call to a function named __sanitizer_cov_trace_pc on every edge. This function has to be defined by us. By noting down the caller in that function we can trace the code we have encountered during execution. Such information is used by coverage guided fuzzers like AFL and LibFuzzer to determine if a new input resulted in a new code path. This makes fuzzing much more effective. Additionally this adds a basic KCOV implementation. KCOV is an API that allows user space to request the kernel to start collecting coverage information for a given user space thread. Furthermore KCOV then exposes the collected program counters to user space via a BlockDevice which can be mmaped from user space. This work is required to add effective support for fuzzing SerenityOS to the Syzkaller syscall fuzzer. :^) :^)
2021-06-06 23:15:07 +00:00
option(ENABLE_KERNEL_COVERAGE_COLLECTION "Enable KCOV and kernel coverage instrumentation in gcc/clang" OFF)
AK: Rename {DBGLN_NO => ENABLE}_COMPILETIME_FORMAT_CHECK This is no longer limited to dbgln(). Also invert it to match all the other ENABLE_FOO options.
2021-02-23 17:14:04 +00:00
option(ENABLE_MEMORY_SANITIZER "Enable memory sanitizer testing in gcc/clang" OFF)
option(ENABLE_UNDEFINED_SANITIZER "Enable undefined behavior sanitizer testing in gcc/clang" OFF)
option(ENABLE_FUZZER_SANITIZER "Enable fuzzer sanitizer testing in clang" OFF)
Kernel: Add ENABLE_EXTRA_KERNEL_DEBUG_SYMBOLS option to set Og and ggdb3 When debugging kernel code, it's necessary to set extra flags. Normal advice is to set -ggdb3. Sometimes that still doesn't provide enough debugging information for complex functions that still get optimized. Compiling with -Og gives the best optimizations for debugging, but can sometimes be broken by changes that are innocuous when the compiler gets more of a chance to look at them. The new CMake option enables both compile options for kernel code.
2021-05-23 20:20:22 +00:00
option(ENABLE_EXTRA_KERNEL_DEBUG_SYMBOLS "Enable -Og and -ggdb3 options for Kernel code for easier debugging" OFF)
AK: Rename {DBGLN_NO => ENABLE}_COMPILETIME_FORMAT_CHECK This is no longer limited to dbgln(). Also invert it to match all the other ENABLE_FOO options.
2021-02-23 17:14:04 +00:00
option(ENABLE_ALL_THE_DEBUG_MACROS "Enable all debug macros to validate they still compile" OFF)
Meta/CI: Add ENABLE_ALL_DEBUG_FACILITIES CMake option This option replaces the use of ENABLE_ALL_THE_DEBUG_MACROS in CI runs, and enables all debug options that might be broken by developers unintentionally that are only used in specific debugging situations.
2021-05-23 21:33:52 +00:00
option(ENABLE_ALL_DEBUG_FACILITIES "Enable all noisy debug symbols and options. Not recommended for normal developer use" OFF)
Build: Add ENABLE_PCI_IDS_DOWNLOAD CMake option This allows disabling the download of the pci.ids database at build time. Addresses concerns raised in #5410.
2021-03-03 22:29:37 +00:00
option(ENABLE_COMPILETIME_FORMAT_CHECK "Enable compiletime format string checks" ON)
option(ENABLE_PCI_IDS_DOWNLOAD "Enable download of the pci.ids database at build time" ON)
Userland/Libraries: Add LibUSBDB library Simple clone of LibPCIDB to support USB IDs instead of PCI ones. The format is basically identical, besides a few changes of the double tab fields.
2021-06-09 14:24:04 +00:00
option(ENABLE_USB_IDS_DOWNLOAD "Enable download of the usb.ids database at build time" ON)
AK: Rename {DBGLN_NO => ENABLE}_COMPILETIME_FORMAT_CHECK This is no longer limited to dbgln(). Also invert it to match all the other ENABLE_FOO options.
2021-02-23 17:14:04 +00:00
option(BUILD_LAGOM "Build parts of the system targeting the host OS for fuzzing/testing" OFF)
Kernel: Add a CMake flag to enable LTO for the kernel
2021-04-29 13:25:31 +00:00
option(ENABLE_KERNEL_LTO "Build the kernel with link-time optimization" OFF)
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
option(USE_CLANG_TOOLCHAIN "Build the kernel with the experimental Clang toolchain" OFF)
Meta: Run the Wasm spec tests in CI Since LibWasm is still not capable of passing all of the spec tests, ignore failing tests, only fail the build if some segfault/abort/etc occurs.
2021-05-26 18:34:52 +00:00
include(Meta/CMake/wasm_spec_tests.cmake)
CMake: Consolidate all options to the root of the project
2021-01-01 10:19:48 +00:00
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
add_custom_target(run
Meta: Run 64-bit kernels with qemu-system-x86_64
2021-06-24 10:52:27 +00:00
COMMAND ${CMAKE_COMMAND} -E env "SERENITY_ARCH=${SERENITY_ARCH}" ${CMAKE_SOURCE_DIR}/Meta/run.sh
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
USES_TERMINAL
)
CMake: Add 'setup-and-run' target to perform all prereqs and run the image Running 'ninja install && ninja image && ninja run` is kind of annoying. I got tired, and came up with this instead, which does the right thing and I don't have to type out the incantation.
2021-02-14 23:59:20 +00:00
# This can currently only be implemented by ordered commands
# as cmake doesn't support inter dependency ordering, and we
# would like to avoid inject dependencies on the existing
# custom commands to allow people to run commands adhoc with
# out forcing re-builds when they might not want them.
add_custom_target(setup-and-run
COMMAND ${CMAKE_MAKE_PROGRAM} install
COMMAND ${CMAKE_MAKE_PROGRAM} image
COMMAND ${CMAKE_MAKE_PROGRAM} run
USES_TERMINAL
)
Build: rename `image` target => `qemu-image` Also add a new `image` target which is just an alias to `qemu-image`. This makes the CMakeLists.txt file more readable in my opinion.
2020-06-20 01:04:42 +00:00
add_custom_target(image
DEPENDS qemu-image
)
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
set(GCC_VERSION 11.2.0)
set(LLVM_VERSION 12.0.1)
Build: rename `image` target => `qemu-image` Also add a new `image` target which is just an alias to `qemu-image`. This makes the CMakeLists.txt file more readable in my opinion.
2020-06-20 01:04:42 +00:00
add_custom_target(qemu-image
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
COMMAND ${CMAKE_COMMAND} -E env "SERENITY_SOURCE_DIR=${CMAKE_SOURCE_DIR}" "SERENITY_ARCH=${SERENITY_ARCH}" "USE_CLANG_TOOLCHAIN=$<BOOL:${USE_CLANG_TOOLCHAIN}>" "LLVM_VERSION=${LLVM_VERSION}" ${CMAKE_SOURCE_DIR}/Meta/build-image-qemu.sh
Build: rename `image` target => `qemu-image` Also add a new `image` target which is just an alias to `qemu-image`. This makes the CMakeLists.txt file more readable in my opinion.
2020-06-20 01:04:42 +00:00
BYPRODUCTS ${CMAKE_BINARY_DIR}/_disk_image
USES_TERMINAL
)
Build: Add grub-image target to CMake
2020-05-26 21:51:18 +00:00
add_custom_target(grub-image
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
COMMAND ${CMAKE_COMMAND} -E env "SERENITY_SOURCE_DIR=${CMAKE_SOURCE_DIR}" "SERENITY_ARCH=${SERENITY_ARCH}" "USE_CLANG_TOOLCHAIN=$<BOOL:${USE_CLANG_TOOLCHAIN}>" "LLVM_VERSION=${LLVM_VERSION}" ${CMAKE_SOURCE_DIR}/Meta/build-image-grub.sh
Build: Use a separate byproduct name for the GRUB disk image (#2424) The grub-image target no longer conflicts with normal image target. This unbreaks using CMake with Ninja. Fixes #2423.
2020-05-28 08:08:38 +00:00
BYPRODUCTS ${CMAKE_BINARY_DIR}/grub_disk_image
Build: Add grub-image target to CMake
2020-05-26 21:51:18 +00:00
USES_TERMINAL
)
Build: Add extlinux-image target to CMake
2021-05-08 11:02:36 +00:00
add_custom_target(extlinux-image
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
COMMAND ${CMAKE_COMMAND} -E env "SERENITY_SOURCE_DIR=${CMAKE_SOURCE_DIR}" "SERENITY_ARCH=${SERENITY_ARCH}" "USE_CLANG_TOOLCHAIN=$<BOOL:${USE_CLANG_TOOLCHAIN}>" "LLVM_VERSION=${LLVM_VERSION}" ${CMAKE_SOURCE_DIR}/Meta/build-image-extlinux.sh
Build: Add extlinux-image target to CMake
2021-05-08 11:02:36 +00:00
BYPRODUCTS ${CMAKE_BINARY_DIR}/extlinux_disk_image
USES_TERMINAL
)
Build: Add grub-image target to CMake
2020-05-26 21:51:18 +00:00
CMake: Add convenience targets to run lint-shell-scripts and check-style
2020-05-28 19:06:44 +00:00
add_custom_target(lint-shell-scripts
COMMAND ${CMAKE_SOURCE_DIR}/Meta/lint-shell-scripts.sh
USES_TERMINAL
)
add_custom_target(check-style
COMMAND ${CMAKE_SOURCE_DIR}/Meta/check-style.sh
USES_TERMINAL
)
Meta: Add install-ports CMake target install-ports copys the necessary files from Ports/ to /usr/Ports. Also refactor the compiler and destiation variables from .port_include.sh into .hosted_defs.sh. .hosted_defs.sh does not exists when ports are built in serenity
2021-04-03 03:53:41 +00:00
add_custom_target(install-ports
Everywhere: Replace SERENITY_ROOT with SERENITY_SOURCE_DIR
2021-04-20 00:51:04 +00:00
COMMAND ${CMAKE_COMMAND} -E env "SERENITY_SOURCE_DIR=${CMAKE_SOURCE_DIR}" "SERENITY_ARCH=${SERENITY_ARCH}" ${CMAKE_SOURCE_DIR}/Meta/install-ports-tree.sh
Meta: Add install-ports CMake target install-ports copys the necessary files from Ports/ to /usr/Ports. Also refactor the compiler and destiation variables from .port_include.sh into .hosted_defs.sh. .hosted_defs.sh does not exists when ports are built in serenity
2021-04-03 03:53:41 +00:00
USES_TERMINAL
)
Meta: Add the ConfigureComponents utility This adds a utility program which is essentially a command generator for CMake. It reads the 'components.ini' file generated by CMake in the build directory, prompts the user to select a build type and optionally customize it, generates and runs a CMake command as well as 'ninja clean' and 'rm -rf Root', which are needed to properly remove system components. The program uses whiptail(1) for user interaction.
2021-06-20 12:54:45 +00:00
add_custom_target(configure-components
COMMAND ConfigureComponents
DEPENDS ConfigureComponents
USES_TERMINAL
)
CMake: Set C++20 mode in canonical cmake Problem: - Setting `CMAKE_CXX_FLAGS` directly to effect the version of the C++ standard being used is no longer the recommended best practice. Solution: - Set C++20 mode in the compiler by setting `CMAKE_CXX_STANDARD`. - Force the build system generator not to fallback to the latest standard supported by the compiler by enabling `CMAKE_CXX_STANDARD_REQUIRED`. This shouldn't ever be a problem though since the toolchain is tightly controlled. - Disable GNU compiler extensions by disabling `CMAKE_CXX_EXTENSIONS` to preserve the previous flags.
2020-12-22 00:47:47 +00:00
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
Build: Add -fsized-deallocation to global CXXFLAGS This is enabled by default for GCC (>=C++14) but apparently not for Clang, which has been causing CLion to get confused about kernel code.
2021-08-07 19:29:39 +00:00
add_compile_options(-fsized-deallocation)
cmake: Hotfix the broken build This regressed in #6000 and started complaining about bad literal suffixes, so here's a quick and dirty partial revert to make things build again.
2021-03-28 19:32:28 +00:00
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
Meta: Remove obsolete `-fconcepts` CFLAG The GCC documentation says that since it's officially a part of C++20, this flag does nothing. Clang, however, does complain that it does not recognize it, so it's better to just remove it.
2021-07-12 17:51:19 +00:00
add_compile_options(-Wno-literal-suffix)
CMake: Fix building with AppleClang compiler
2021-04-30 03:04:59 +00:00
elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang$")
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
add_compile_options(-Wno-overloaded-virtual)
add_compile_options(-Wno-user-defined-literals)
add_compile_options(-fconstexpr-steps=16777216)
cmake: Hotfix the broken build This regressed in #6000 and started complaining about bad literal suffixes, so here's a quick and dirty partial revert to make things build again.
2021-03-28 19:32:28 +00:00
endif()
Meta/CI: Add ENABLE_ALL_DEBUG_FACILITIES CMake option This option replaces the use of ENABLE_ALL_THE_DEBUG_MACROS in CI runs, and enables all debug options that might be broken by developers unintentionally that are only used in specific debugging situations.
2021-05-23 21:33:52 +00:00
if (ENABLE_ALL_DEBUG_FACILITIES)
set(ENABLE_ALL_THE_DEBUG_MACROS ON)
set(ENABLE_EXTRA_KERNEL_DEBUG_SYMBOLS ON)
CMake: Hide KMALLOC_VERIFY_NO_SPINLOCK_HELD so folks don't find it Since I introduced this functionality there has been a steady stream of people building with `ALL_THE_DEBUG_MACROS` and trying to boot the system, and immediately hitting this assert. I have no idea why people try to build with all the debugging enabled, but I'm tired of seeing the bug reports about asserts we know are going to happen at this point. So I'm hiding this value under the new ENABLE_ALL_DEBUG_FACILITIES flag instead. This is only set by CI, and hopefully no-one will try to build with this thing (It's documented as not recommended). Fixes: #7527
2021-05-31 09:38:50 +00:00
# Immediately finds violations during boot, shouldn't be discoverable
# by people who aren't working on fixing issues. Use this check to make
# sure this code continues to build instead of all_debug_macros to avoid
# people filing bugs.
set(KMALLOC_VERIFY_NO_SPINLOCK_HELD ON)
Kernel: Add option to build with coverage instrumentation and KCOV GCC and Clang allow us to inject a call to a function named __sanitizer_cov_trace_pc on every edge. This function has to be defined by us. By noting down the caller in that function we can trace the code we have encountered during execution. Such information is used by coverage guided fuzzers like AFL and LibFuzzer to determine if a new input resulted in a new code path. This makes fuzzing much more effective. Additionally this adds a basic KCOV implementation. KCOV is an API that allows user space to request the kernel to start collecting coverage information for a given user space thread. Furthermore KCOV then exposes the collected program counters to user space via a BlockDevice which can be mmaped from user space. This work is required to add effective support for fuzzing SerenityOS to the Syzkaller syscall fuzzer. :^) :^)
2021-06-06 23:15:07 +00:00
# Enables KCOV API and injects kernel coverage instrumentation via
# -fsanitize-coverage=trace-pc. Mostly here to ensure that the CI catches
# commits breaking this flag.
set(ENABLE_KERNEL_COVERAGE_COLLECTION ON)
Meta/CI: Add ENABLE_ALL_DEBUG_FACILITIES CMake option This option replaces the use of ENABLE_ALL_THE_DEBUG_MACROS in CI runs, and enables all debug options that might be broken by developers unintentionally that are only used in specific debugging situations.
2021-05-23 21:33:52 +00:00
endif()
CMake: Add public cmake option to document ENABLE_ALL_THE_DEBUG_MACROS - Making this an option makes this option visible to users and tooling. - Rename `ALL_THE_DEBUG_MACROS` -> `ENABLE_ALL_THE_DEBUG_MACROS`.
2021-01-01 10:26:52 +00:00
if (ENABLE_ALL_THE_DEBUG_MACROS)
CMake: Decouple cmake utility functions from top-level CMakeLists.txt Problem: - These utility functions are only used in `AK`, but are being defined in the top-level. This clutters the top-level. Solution: - Move the utility functions to `Meta/CMake/utils.cmake` and include where needed. - Also, move `all_the_debug_macros.cmake` into `Meta/CMake` directory to consolidate the location of `*.cmake` script files.
2020-12-23 17:07:22 +00:00
include(${CMAKE_SOURCE_DIR}/Meta/CMake/all_the_debug_macros.cmake)
CMake: Add public cmake option to document ENABLE_ALL_THE_DEBUG_MACROS - Making this an option makes this option visible to users and tooling. - Rename `ALL_THE_DEBUG_MACROS` -> `ENABLE_ALL_THE_DEBUG_MACROS`.
2021-01-01 10:26:52 +00:00
endif(ENABLE_ALL_THE_DEBUG_MACROS)
Meta: Provide option to build with ALL debug macros
2020-08-26 22:59:36 +00:00
Everywhere: Use CMake to generate AK/Debug.h. This was done with the help of several scripts, I dump them here to easily find them later: awk '/#ifdef/ { print "#cmakedefine01 "$2 }' AK/Debug.h.in for debug_macro in $(awk '/#ifdef/ { print $2 }' AK/Debug.h.in) do find . \( -name '*.cpp' -o -name '*.h' -o -name '*.in' \) -not -path './Toolchain/*' -not -path './Build/*' -exec sed -i -E 's/#ifdef '$debug_macro'/#if '$debug_macro'/' {} \; done # Remember to remove WRAPPER_GERNERATOR_DEBUG from the list. awk '/#cmake/ { print "set("$2" ON)" }' AK/Debug.h.in
2021-01-23 22:29:11 +00:00
configure_file(AK/Debug.h.in AK/Debug.h @ONLY)
Meta: Split debug defines into multiple headers. The following script was used to make these changes: #!/bin/bash set -e tmp=$(mktemp -d) echo "tmp=$tmp" find Kernel \( -name '*.cpp' -o -name '*.h' \) | sort > $tmp/Kernel.files find . \( -path ./Toolchain -prune -o -path ./Build -prune -o -path ./Kernel -prune \) -o \( -name '*.cpp' -o -name '*.h' \) -print | sort > $tmp/EverythingExceptKernel.files cat $tmp/Kernel.files | xargs grep -Eho '[A-Z0-9_]+_DEBUG' | sort | uniq > $tmp/Kernel.macros cat $tmp/EverythingExceptKernel.files | xargs grep -Eho '[A-Z0-9_]+_DEBUG' | sort | uniq > $tmp/EverythingExceptKernel.macros comm -23 $tmp/Kernel.macros $tmp/EverythingExceptKernel.macros > $tmp/Kernel.unique comm -1 $tmp/Kernel.macros $tmp/EverythingExceptKernel.macros > $tmp/EverythingExceptKernel.unique cat $tmp/Kernel.unique | awk '{ print "#cmakedefine01 "$1 }' > $tmp/Kernel.header cat $tmp/EverythingExceptKernel.unique | awk '{ print "#cmakedefine01 "$1 }' > $tmp/EverythingExceptKernel.header for macro in $(cat $tmp/Kernel.unique) do cat $tmp/Kernel.files | xargs grep -l $macro >> $tmp/Kernel.new-includes ||: done cat $tmp/Kernel.new-includes | sort > $tmp/Kernel.new-includes.sorted for macro in $(cat $tmp/EverythingExceptKernel.unique) do cat $tmp/Kernel.files | xargs grep -l $macro >> $tmp/Kernel.old-includes ||: done cat $tmp/Kernel.old-includes | sort > $tmp/Kernel.old-includes.sorted comm -23 $tmp/Kernel.new-includes.sorted $tmp/Kernel.old-includes.sorted > $tmp/Kernel.includes.new comm -13 $tmp/Kernel.new-includes.sorted $tmp/Kernel.old-includes.sorted > $tmp/Kernel.includes.old comm -12 $tmp/Kernel.new-includes.sorted $tmp/Kernel.old-includes.sorted > $tmp/Kernel.includes.mixed for file in $(cat $tmp/Kernel.includes.new) do sed -i -E 's/#include <AK\/Debug\.h>/#include <Kernel\/Debug\.h>/' $file done for file in $(cat $tmp/Kernel.includes.mixed) do echo "mixed include in $file, requires manual editing." done
2021-01-25 15:07:10 +00:00
configure_file(Kernel/Debug.h.in Kernel/Debug.h @ONLY)
Everywhere: Use CMake to generate AK/Debug.h. This was done with the help of several scripts, I dump them here to easily find them later: awk '/#ifdef/ { print "#cmakedefine01 "$2 }' AK/Debug.h.in for debug_macro in $(awk '/#ifdef/ { print $2 }' AK/Debug.h.in) do find . \( -name '*.cpp' -o -name '*.h' -o -name '*.in' \) -not -path './Toolchain/*' -not -path './Build/*' -exec sed -i -E 's/#ifdef '$debug_macro'/#if '$debug_macro'/' {} \; done # Remember to remove WRAPPER_GERNERATOR_DEBUG from the list. awk '/#cmake/ { print "set("$2" ON)" }' AK/Debug.h.in
2021-01-23 22:29:11 +00:00
Libraries: Move to Userland/Libraries/
2021-01-12 11:17:30 +00:00
include_directories(Userland/Libraries)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
include_directories(.)
Everywhere: Use CMake to generate AK/Debug.h. This was done with the help of several scripts, I dump them here to easily find them later: awk '/#ifdef/ { print "#cmakedefine01 "$2 }' AK/Debug.h.in for debug_macro in $(awk '/#ifdef/ { print $2 }' AK/Debug.h.in) do find . \( -name '*.cpp' -o -name '*.h' -o -name '*.in' \) -not -path './Toolchain/*' -not -path './Build/*' -exec sed -i -E 's/#ifdef '$debug_macro'/#if '$debug_macro'/' {} \; done # Remember to remove WRAPPER_GERNERATOR_DEBUG from the list. awk '/#cmake/ { print "set("$2" ON)" }' AK/Debug.h.in
2021-01-23 22:29:11 +00:00
include_directories(${CMAKE_BINARY_DIR})
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
Meta: Add LibUnicode (and its tests) to Lagom This is primarily to allow using LibUnicode within LibJS and its REPL. Note: this seems to be the first time that a Lagom dependency requires generated source files. For this to work, some of Lagom's CMakeLists.txt commands needed to be re-organized to include the CMake files that fetch and parse UnicodeData.txt. The paths required to invoke the generator also differ depending on what is currently building (SerenityOS vs. Lagom as part of the Serenity build vs. a standalone Lagom build).
2021-07-25 19:15:47 +00:00
set(write_if_different ${CMAKE_SOURCE_DIR}/Meta/write-only-on-difference.sh)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
add_subdirectory(Meta/Lagom)
Userland: Port UBSAN implementation to userspace Take Kernel/UBSanitizer.cpp and make a copy in LibSanitizer. We can use LibSanitizer to hold other sanitizers as people implement them :^). To enable UBSAN for LibC, DynamicLoader, and other low level system libraries, LibUBSanitizer is built as a serenity_libc, and has a static version for LibCStatic to use. The approach is the same as that taken in Note that this means now UBSAN is enabled for code generators, Lagom, Kernel, and Userspace with -DENABLE_UNDEFINED_SANTIZER=ON. In userspace however, UBSAN is not deadly (yet). Co-authored-by: ForLoveOfCats <ForLoveOfCats@vivaldi.net>
2021-05-24 01:40:22 +00:00
if (ENABLE_UNDEFINED_SANITIZER)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined")
endif()
DevTools: Move to Userland/DevTools/
2021-01-12 11:18:55 +00:00
add_subdirectory(Userland/DevTools/IPCCompiler)
DevTools: Add StateMachineGenerator utility This program turns a description of a state machine that takes its input byte-by-byte into C++ code. The state machine is described in a custom format as specified below: ``` // Comments are started by two slashes, and cause the rest of the line // to be ignored @name ExampleStateMachine // sets the name of the generated class @namespace Test // sets the namespace (optional) @begin Begin // sets the state the parser will start in // The rest of the file contains one or more states and an optional // @anywhere directive. Each of these is a curly bracket delimited set // of state transitions. State transitions contain a selector, the // literal "=>" and a (new_state, action) tuple. Examples: // 0x0a => (Begin, PrintLine) // [0x00..0x1f] => (_, Warn) // '_' means no change // [0x41..0x5a] => (BeginWord, _) // '_' means no action // Rules common to all states. These take precedence over rules in the // specific states. @anywhere { 0x0a => (Begin, PrintLine) [0x00..0x1f] => (_, Warn) } Begin { [0x41..0x5a] => (Word, _) [0x61..0x7a] => (Word, _) // For missing values, the transition (_, _) is implied } Word { // The entry action is run when we transition to this state from a // *different* state. @anywhere can't have this @entry IncreaseWordCount 0x09 => (Begin, _) 0x20 => (Begin, _) // The exit action is run before we transition to any *other* state // from here. @anywhere can't have this @exit EndOfWord } ``` The generated code consists of a single class which takes a `Function<Action, u8>` as a parameter in its constructor. This gets called whenever an action is to be done. This is because some input might not produce an action, but others might produce up to 3 (exit, state transition, entry). The actions allow us to build a more advanced parser over the simple state machine. The sole public method, `void advance(u8)`, handles the input byte-by-byte, managing the state changes and requesting the appropriate Action from the handler. Internally, the state transitions are resolved via a lookup table. This is a bit wasteful for more complex state machines, therefore the generator is designed to be easily extendable with a switch-based resolver; only the private `lookup_state_transition` method needs to be re-implemented. My goal for this tool is to use it for implementing a standard-compliant ANSI escape sequence parser for LibVT, as described on <https://vt100.net/emu/dec_ansi_parser>
2021-05-08 07:53:49 +00:00
add_subdirectory(Userland/DevTools/StateMachineGenerator)
LibUnicode: Introduce a Unicode library for interacting with UCD files The Unicode standard publishes the Unicode Character Database (UCD) with information about every code point, such as each code point's upper case mapping. LibUnicode exists to download and parse UCD files at build time and to provide accessors to that data. As a start, LibUnicode includes upper- and lower-case code point converters.
2021-07-25 19:10:51 +00:00
add_subdirectory(Userland/Libraries/LibUnicode/CodeGenerators)
Libraries: Move to Userland/Libraries/
2021-01-12 11:17:30 +00:00
add_subdirectory(Userland/Libraries/LibWeb/CodeGenerators)
Meta: Add the ConfigureComponents utility This adds a utility program which is essentially a command generator for CMake. It reads the 'components.ini' file generated by CMake in the build directory, prompts the user to select a build type and optionally customize it, generates and runs a CMake command as well as 'ninja clean' and 'rm -rf Root', which are needed to properly remove system components. The program uses whiptail(1) for user interaction.
2021-06-20 12:54:45 +00:00
add_subdirectory(Meta/CMake/ConfigureComponents)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
find_program(CCACHE_PROGRAM ccache)
if(CCACHE_PROGRAM)
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CCACHE_PROGRAM}")
endif()
unset(CMAKE_SYSROOT)
set(CMAKE_STAGING_PREFIX ${CMAKE_BINARY_DIR}/Root)
set(CMAKE_INSTALL_PREFIX ${CMAKE_BINARY_DIR}/Root)
set(CMAKE_INSTALL_DATAROOTDIR ${CMAKE_BINARY_DIR}/Root/res)
Toolchain+Ports: Update GCC to version 11.1.0
2021-04-22 14:38:20 +00:00
Meta: Make it possible to (somewhat) build the system inside Serenity This removes some hard references to the toolchain, some unnecessary uses of an external install command, and disables a -Werror flag (for the time being) - only if run inside serenity. With this, we can build and link the kernel :^)
2021-02-14 21:49:25 +00:00
if (${CMAKE_HOST_SYSTEM_NAME} MATCHES SerenityOS)
message("Good job on building cmake!")
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
elseif(USE_CLANG_TOOLCHAIN)
set(TOOLCHAIN_ROOT ${CMAKE_SOURCE_DIR}/Toolchain/Local/clang/${SERENITY_ARCH}/)
set(TOOLCHAIN_PATH ${TOOLCHAIN_ROOT}/bin)
set(CMAKE_C_COMPILER ${TOOLCHAIN_PATH}/clang)
set(CMAKE_CXX_COMPILER ${TOOLCHAIN_PATH}/clang++)
set(CMAKE_ASM_COMPILER ${TOOLCHAIN_PATH}/clang)
set(CMAKE_LINKER ${TOOLCHAIN_PATH}/ld.lld)
set(CMAKE_RANLIB ${TOOLCHAIN_PATH}/llvm-ranlib)
set(CMAKE_STRIP ${TOOLCHAIN_PATH}/llvm-strip)
set(CMAKE_AR ${TOOLCHAIN_PATH}/llvm-ar)
set(CMAKE_CXXFILT ${TOOLCHAIN_PATH}/llvm-cxxfilt)
# FIXME: Persuade LLVM maintainers to add `--update-section` to llvm-objcopy, as it's required for the kernel symbol map.
set(CMAKE_OBJCOPY ${TOOLCHAIN_ROOT}/binutils/bin/${SERENITY_ARCH}-pc-serenity-objcopy)
Meta: Make it possible to (somewhat) build the system inside Serenity This removes some hard references to the toolchain, some unnecessary uses of an external install command, and disables a -Werror flag (for the time being) - only if run inside serenity. With this, we can build and link the kernel :^)
2021-02-14 21:49:25 +00:00
else()
Build: Use variables when concatenating Toolchain paths. Make this stuff a bit easier to maintain by using the root level variables to build up the Toolchain paths. Also leave a note for future editors of BuildIt.sh to give them warning about the other changes they'll need to make.
2021-04-27 07:25:02 +00:00
set(TOOLCHAIN_ROOT ${CMAKE_SOURCE_DIR}/Toolchain/Local/${SERENITY_ARCH}/)
set(TOOLCHAIN_PATH ${TOOLCHAIN_ROOT}/bin)
Meta: Make it possible to (somewhat) build the system inside Serenity This removes some hard references to the toolchain, some unnecessary uses of an external install command, and disables a -Werror flag (for the time being) - only if run inside serenity. With this, we can build and link the kernel :^)
2021-02-14 21:49:25 +00:00
set(TOOLCHAIN_PREFIX ${TOOLCHAIN_PATH}/${SERENITY_ARCH}-pc-serenity-)
set(CMAKE_C_COMPILER ${TOOLCHAIN_PREFIX}gcc)
set(CMAKE_CXX_COMPILER ${TOOLCHAIN_PREFIX}g++)
set(CMAKE_ASM_COMPILER ${TOOLCHAIN_PREFIX}gcc)
set(CMAKE_LINKER ${TOOLCHAIN_PREFIX}ld)
Kernel: Add a CMake flag to enable LTO for the kernel
2021-04-29 13:25:31 +00:00
set(CMAKE_RANLIB ${TOOLCHAIN_PREFIX}gcc-ranlib)
Meta: Make it possible to (somewhat) build the system inside Serenity This removes some hard references to the toolchain, some unnecessary uses of an external install command, and disables a -Werror flag (for the time being) - only if run inside serenity. With this, we can build and link the kernel :^)
2021-02-14 21:49:25 +00:00
set(CMAKE_STRIP ${TOOLCHAIN_PREFIX}strip)
Kernel: Add a CMake flag to enable LTO for the kernel
2021-04-29 13:25:31 +00:00
set(CMAKE_AR ${TOOLCHAIN_PREFIX}gcc-ar)
Kernel: Make new kernel build process work on macOS Use objcopy from the toolchain so that the changes introduced in 7236584 will succeed on macOS. Fixes #8768.
2021-07-15 08:17:58 +00:00
set(CMAKE_OBJCOPY ${TOOLCHAIN_PREFIX}objcopy)
Kernel: Use our toolchain's c++filt tool for the kernel map The host's version of c++filt might not work on some operating systems, e.g. macOS.
2021-07-29 06:48:47 +00:00
set(CMAKE_CXXFILT ${TOOLCHAIN_PREFIX}c++filt)
Meta: Make it possible to (somewhat) build the system inside Serenity This removes some hard references to the toolchain, some unnecessary uses of an external install command, and disables a -Werror flag (for the time being) - only if run inside serenity. With this, we can build and link the kernel :^)
2021-02-14 21:49:25 +00:00
endif()
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
Toolchain: Allow building using CMake on macOS
2020-07-08 21:57:51 +00:00
foreach(lang ASM C CXX OBJC OBJCXX)
unset(CMAKE_${lang}_OSX_COMPATIBILITY_VERSION_FLAG)
unset(CMAKE_${lang}_OSX_CURRENT_VERSION_FLAG)
unset(CMAKE_${lang}_LINK_FLAGS)
unset(CMAKE_SHARED_LIBRARY_CREATE_${lang}_FLAGS)
unset(CMAKE_SHARED_MODULE_CREATE_${lang}_FLAGS)
unset(CMAKE_SHARED_MODULE_LOADER_${lang}_FLAG )
unset(CMAKE_${lang}_OSX_DEPLOYMENT_TARGET_FLAG)
unset(CMAKE_${lang}_SYSROOT_FLAG)
CMake: Only enable "MacOS workaround" on MacOS This was preventing ports from building on Linux.
2021-01-07 10:39:24 +00:00
if (CMAKE_SYSTEM_NAME MATCHES Darwin)
CMake: Fix building libraries on macOS When building libraries on macOS they'd be missing the SONAME attribute which causes the linker to embed relative paths into other libraries and executables: Dynamic section at offset 0x52794 contains 28 entries: Type Name/Value (NEEDED) Shared library: [libgcc_s.so] (NEEDED) Shared library: [Userland/Libraries/LibCrypt/libcrypt.so] (NEEDED) Shared library: [Userland/Libraries/LibCrypto/libcrypto.so] (NEEDED) Shared library: [Userland/Libraries/LibC/libc.so] (NEEDED) Shared library: [libsystem.so] (NEEDED) Shared library: [libm.so] (NEEDED) Shared library: [libc.so] The dynamic linker then fails to load those libraries which makes the system unbootable.
2021-04-29 20:58:05 +00:00
## macOS workaround. Use GNU ld flags for SONAMEs.
CMake: Only enable "MacOS workaround" on MacOS This was preventing ports from building on Linux.
2021-01-07 10:39:24 +00:00
set(CMAKE_${lang}_CREATE_SHARED_LIBRARY
CMake: Fix building libraries on macOS When building libraries on macOS they'd be missing the SONAME attribute which causes the linker to embed relative paths into other libraries and executables: Dynamic section at offset 0x52794 contains 28 entries: Type Name/Value (NEEDED) Shared library: [libgcc_s.so] (NEEDED) Shared library: [Userland/Libraries/LibCrypt/libcrypt.so] (NEEDED) Shared library: [Userland/Libraries/LibCrypto/libcrypto.so] (NEEDED) Shared library: [Userland/Libraries/LibC/libc.so] (NEEDED) Shared library: [libsystem.so] (NEEDED) Shared library: [libm.so] (NEEDED) Shared library: [libc.so] The dynamic linker then fails to load those libraries which makes the system unbootable.
2021-04-29 20:58:05 +00:00
"<CMAKE_${lang}_COMPILER> <LANGUAGE_COMPILE_FLAGS> <CMAKE_SHARED_LIBRARY_CREATE_${lang}_FLAGS> <LINK_FLAGS> <SONAME_FLAG><TARGET_SONAME> -o <TARGET> <OBJECTS> <LINK_LIBRARIES>")
set(CMAKE_SHARED_LIBRARY_SONAME_${lang}_FLAG "-Wl,-soname,")
CMake: Only enable "MacOS workaround" on MacOS This was preventing ports from building on Linux.
2021-01-07 10:39:24 +00:00
endif()
Toolchain: Allow building using CMake on macOS
2020-07-08 21:57:51 +00:00
endforeach()
Meta: Disable rpath generation for MacOS
2020-12-27 23:04:29 +00:00
set(CMAKE_INSTALL_NAME_TOOL "")
Toolchain: Allow building using CMake on macOS
2020-07-08 21:57:51 +00:00
set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")
Build: Enable --noexecstack Build ELF executables with a zero length `GNU_STACK` program header flagged non-executable. The stack is never executable on SerenityOS regardless of whether the `GNU_STACK` header is specified. Specifically defining this header is more explicit, as absence of this header implies an executable stack on other systems (Linux).
2021-03-19 05:47:23 +00:00
set(CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS "-shared -Wl,--hash-style=gnu,-z,relro,-z,now,-z,noexecstack")
Userland: Set linker max page size to 4096 Neither the kernel nor LibELF support loading libraries with larger PT_LOAD alignment. The default on x86 is 4096 while it's 2MiB on x86_64. This changes the alignment to 4096 on all platforms.
2021-06-28 15:19:18 +00:00
set(CMAKE_CXX_LINK_FLAGS "-Wl,--hash-style=gnu,-z,relro,-z,now,-z,noexecstack,-z,max-page-size=0x1000")
Toolchain: Allow building using CMake on macOS
2020-07-08 21:57:51 +00:00
CMake: set CMAKE_SKIP_RPATH everywhere Else, there's tons of "-- Set runtime path of" spam at build time, with apparently no way of disabling the build noise other than turning of rpaths. If the dynamic loader uses them at some point, we probably want to set them through cflags/ldflags instead of through cmake's built-in thing anyways, for that reason.
2021-01-06 23:55:01 +00:00
# We disable it completely because it makes cmake very spammy.
Meta: Disable rpath generation for MacOS
2020-12-27 23:04:29 +00:00
# This will need to be revisited when the Loader supports RPATH/RUN_PATH.
CMake: set CMAKE_SKIP_RPATH everywhere Else, there's tons of "-- Set runtime path of" spam at build time, with apparently no way of disabling the build noise other than turning of rpaths. If the dynamic loader uses them at some point, we probably want to set them through cflags/ldflags instead of through cmake's built-in thing anyways, for that reason.
2021-01-06 23:55:01 +00:00
set(CMAKE_SKIP_RPATH TRUE)
Meta: Disable rpath generation for MacOS
2020-12-27 23:04:29 +00:00
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wformat=2)
add_compile_options(-fdiagnostics-color=always)
if (NOT ${CMAKE_HOST_SYSTEM_NAME} MATCHES SerenityOS)
cmake: Group compile options together.
2021-03-28 14:43:05 +00:00
# FIXME: Something makes this go crazy and flag unused variables that aren't flagged as such when building with the toolchain.
# Disable -Werror for now.
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Werror)
cmake: Group compile options together.
2021-03-28 14:43:05 +00:00
endif()
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wall)
add_compile_options(-Wextra)
Everywhere: Add "free" warnings The following warnings do not occur anywhere in the codebase and so enabling them is effectivly free: * `-Wcast-align` * `-Wduplicated-cond` * `-Wformat=2` * `-Wlogical-op` * `-Wmisleading-indentation` * `-Wunused` These are taken as a strict subset of the list in #5487.
2021-04-15 07:07:44 +00:00
# The following warnings are sorted by the "base" name (the part excluding the initial Wno or W).
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wno-address-of-packed-member)
add_compile_options(-Wcast-qual)
add_compile_options(-Wno-deprecated-copy)
Everywhere: Add "free" warnings The following warnings do not occur anywhere in the codebase and so enabling them is effectivly free: * `-Wcast-align` * `-Wduplicated-cond` * `-Wformat=2` * `-Wlogical-op` * `-Wmisleading-indentation` * `-Wunused` These are taken as a strict subset of the list in #5487.
2021-04-15 07:07:44 +00:00
add_compile_options(-Wduplicated-cond)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wno-expansion-to-defined)
Everywhere: Add "free" warnings The following warnings do not occur anywhere in the codebase and so enabling them is effectivly free: * `-Wcast-align` * `-Wduplicated-cond` * `-Wformat=2` * `-Wlogical-op` * `-Wmisleading-indentation` * `-Wunused` These are taken as a strict subset of the list in #5487.
2021-04-15 07:07:44 +00:00
add_compile_options(-Wformat=2)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wimplicit-fallthrough)
Everywhere: Add "free" warnings The following warnings do not occur anywhere in the codebase and so enabling them is effectivly free: * `-Wcast-align` * `-Wduplicated-cond` * `-Wformat=2` * `-Wlogical-op` * `-Wmisleading-indentation` * `-Wunused` These are taken as a strict subset of the list in #5487.
2021-04-15 07:07:44 +00:00
add_compile_options(-Wlogical-op)
add_compile_options(-Wmisleading-indentation)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wmissing-declarations)
Everything: Add `-Wnon-virtual-dtor` flag This flag warns on classes which have `virtual` functions but do not have a `virtual` destructor. This patch adds both the flag and missing destructors. The access level of the destructors was determined by a two rules of thumb: 1. A destructor should have a similar or lower access level to that of a constructor. 2. Having a `private` destructor implicitly deletes the default constructor, which is probably undesirable for "interface" types (classes with only virtual functions and no data). In short, most of the added destructors are `protected`, unless the compiler complained about access.
2021-04-15 17:43:29 +00:00
add_compile_options(-Wnon-virtual-dtor)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wno-unknown-warning-option)
add_compile_options(-Wundef)
Everywhere: Add "free" warnings The following warnings do not occur anywhere in the codebase and so enabling them is effectivly free: * `-Wcast-align` * `-Wduplicated-cond` * `-Wformat=2` * `-Wlogical-op` * `-Wmisleading-indentation` * `-Wunused` These are taken as a strict subset of the list in #5487.
2021-04-15 07:07:44 +00:00
add_compile_options(-Wunused)
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
add_compile_options(-Wno-unused-private-field)
add_compile_options(-Wno-unused-const-variable)
add_compile_options(-Wno-unused-command-line-argument)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-Wwrite-strings)
Meta: Disable -Wmaybe-uninitialized It's prone to finding "technically uninitialized but can never happen" cases, particularly in Optional<T> and Variant<Ts...>. The general case seems to be that it cannot infer the dependency between Variant's index (or Optional's boolean state) and a particular alternative (or Optional's buffer) being untouched. So it can flag cases like this: ```c++ if (index == StaticIndexForF) new (new_buffer) F(move(*bit_cast<F*>(old_buffer))); ``` The code in that branch can _technically_ make a partially initialized `F`, but that path can never be taken since the buffer holding an object of type `F` and the condition being true are correlated, and so will never be taken _unless_ the buffer holds an object of type `F`. This commit also removed the various 'diagnostic ignored' pragmas used to work around this warning, as they no longer do anything.
2021-06-09 15:51:17 +00:00
add_compile_options(-Wno-maybe-uninitialized)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
CMake: Use add_compile_options instead of appending to CMAKE_CXX_FLAGS Problem: - Appending to CMAKE_CXX_FLAGS for everything is cumbersome. Solution: - Use the `add_compile_options` built-in function to handle adding compiler options (and even de-duplicating).
2020-12-22 01:04:46 +00:00
add_compile_options(-ffile-prefix-map=${CMAKE_SOURCE_DIR}=.)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-fno-exceptions)
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
add_compile_options(-ftls-model=initial-exec)
add_compile_options(-fno-semantic-interposition)
add_compile_options(-fstack-clash-protection)
cmake: Tidy compiler options. Prior to this patch there was some long line of unreadable compiler options. Now the long lines are deduplicated and there is only one option per line to ease reading/maintenance.
2021-03-28 14:48:37 +00:00
add_compile_options(-fstack-protector-strong)
add_compile_options(-g1)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
if (USE_CLANG_TOOLCHAIN)
add_compile_options(-Wno-atomic-alignment)
add_compile_options(-Wno-c99-designator)
add_compile_options(-Wno-implicit-const-int-float-conversion)
add_compile_options(-Wno-inconsistent-missing-override)
add_compile_options(-Wno-tautological-constant-out-of-range-compare)
add_compile_options(-Wno-unneeded-internal-declaration)
add_compile_options(-Wno-unused-function)
add_compile_options(-Wno-user-defined-literals)
# Without the 'SHELL' prefix, this would get removed through de-duplication with the flags set for the host compiler.
# Then, that would come before '-Wextra', so it would not negate the '-Woverloaded-virtual' set by '-Wextra'.
add_compile_options(SHELL:-Wno-overloaded-virtual)
add_compile_options(--sysroot=${CMAKE_BINARY_DIR}/Root)
add_compile_options(--target=${SERENITY_CLANG_ARCH}-pc-serenity)
add_compile_options(-fno-aligned-allocation)
add_compile_options(-fconstexpr-steps=16777216)
add_compile_options(-gdwarf-4)
# FIXME: Why is Clang not picking up this path?
link_directories(${TOOLCHAIN_ROOT}/lib/clang/${LLVM_VERSION}/lib/serenity)
add_link_options(LINKER:--allow-shlib-undefined)
else()
add_compile_options(-Wcast-align)
add_compile_options(-Wdouble-promotion)
endif()
Meta+LibC: Don't allow text relocations in SerenityOS libraries The `-z,text` linker flag causes the linker to reject shared libraries and PIE executables that have textrels. Our code mostly did not use these except in one place in LibC, which is changed in this commit. This makes GNU ld match LLD's behavior, which has this option enabled by default. TEXTRELs pose a security risk, as performing these relocations require executable pages to be written to by the dynamic linker. This can significantly weaken W^X hardening mitigations. Note that after this change, TEXTRELs can still be used in ports, as the dynamic loader code is not changed. There are also uses of it in the kernel, removing which are outside the scope of this PR. To allow those, `-z,notext` is added.
2021-08-18 15:39:04 +00:00
add_link_options(LINKER:-z,text)
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
if("${SERENITY_ARCH}" STREQUAL "i686")
add_compile_options(-march=i686)
else()
add_compile_options(-march=x86-64)
Build: Only use -fstack-clash-protection with GCC This is not yet supported by Clang, so let's disable it for non-GCC compilers for now. (CLion was whining about it.)
2021-02-23 13:15:26 +00:00
endif()
Meta+Documentation: Remove unused -DDEBUG from build
2021-07-12 07:31:47 +00:00
add_compile_definitions(SANITIZE_PTRS)
Toolchain: Fix usage of libgcc_s & build PIE executables by default We can now build the porst with the shared libraries toolchain.
2020-12-11 13:44:08 +00:00
set(CMAKE_CXX_FLAGS_STATIC "${CMAKE_CXX_FLAGS} -static")
Toolchain+LibC: Fix usage of crt files We now configure the gcc spec files to use a different crt files for static & PIE binaries. This relieves us from the need to explicitly specify the desired crt0 file in cmake scripts.
2020-12-20 20:32:10 +00:00
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pie -fpic")
CMake: Remove some trailing whitespace from a few CMakeLists.txt files
2021-01-01 10:20:55 +00:00
AK: Rename {DBGLN_NO => ENABLE}_COMPILETIME_FORMAT_CHECK This is no longer limited to dbgln(). Also invert it to match all the other ENABLE_FOO options.
2021-02-23 17:14:04 +00:00
if (ENABLE_COMPILETIME_FORMAT_CHECK)
add_compile_definitions(ENABLE_COMPILETIME_FORMAT_CHECK)
Build: Allow setting DBGLN_NO_COMPILETIME_FORMAT_CHECK via CMake flag
2021-02-08 17:26:28 +00:00
endif()
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
add_link_options(--sysroot ${CMAKE_BINARY_DIR}/Root)
Meta: Add Clang support to the CMake build scripts
2021-07-13 14:43:45 +00:00
add_link_options(-Wno-unused-command-line-argument)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
Libraries: Move to Userland/Libraries/
2021-01-12 11:17:30 +00:00
include_directories(Userland/Libraries/LibC)
LibC: Move crypt() and crypt_r() to the right header file According to POSIX.1 these should be in <crypt.h>.
2021-05-01 09:38:19 +00:00
include_directories(Userland/Libraries/LibCrypt)
Libraries: Move to Userland/Libraries/
2021-01-12 11:17:30 +00:00
include_directories(Userland/Libraries/LibM)
LibC: Move crypt() and crypt_r() to the right header file According to POSIX.1 these should be in <crypt.h>.
2021-05-01 09:38:19 +00:00
include_directories(Userland/Libraries/LibPthread)
Userland: Add LibSystem and funnel all syscalls through it This achieves two things: - Programs can now intentionally perform arbitrary syscalls by calling syscall(). This allows us to work on things like syscall fuzzing. - It restricts the ability of userspace to make syscalls to a single 4KB page of code. In order to call the kernel directly, an attacker must now locate this page and call through it.
2021-02-05 11:16:30 +00:00
include_directories(Userland/Libraries/LibSystem)
Services: Move to Userland/Services/
2021-01-12 11:23:01 +00:00
include_directories(Userland/Services)
Shell: Move to Userland/Shell/
2021-01-12 10:53:14 +00:00
include_directories(Userland)
TextEditor: Move the main window UI to JSON This is our first client of the new JSON GUI declaration thingy. The skeleton of the TextEditor app GUI is now declared separately from the C++ logic, and we use the Core::Object::name() of widgets to locate them once they have been instantiated by the GUI builder.
2020-09-14 10:51:12 +00:00
include_directories(${CMAKE_CURRENT_BINARY_DIR})
Services: Move to Userland/Services/
2021-01-12 11:23:01 +00:00
include_directories(${CMAKE_CURRENT_BINARY_DIR}/Userland/Services)
Libraries: Move to Userland/Libraries/
2021-01-12 11:17:30 +00:00
include_directories(${CMAKE_CURRENT_BINARY_DIR}/Userland/Libraries)
Shell: Move to Userland/Shell/
2021-01-12 10:53:14 +00:00
include_directories(${CMAKE_CURRENT_BINARY_DIR}/Userland)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
Userland: Port UBSAN implementation to userspace Take Kernel/UBSanitizer.cpp and make a copy in LibSanitizer. We can use LibSanitizer to hold other sanitizers as people implement them :^). To enable UBSAN for LibC, DynamicLoader, and other low level system libraries, LibUBSanitizer is built as a serenity_libc, and has a static version for LibCStatic to use. The approach is the same as that taken in Note that this means now UBSAN is enabled for code generators, Lagom, Kernel, and Userspace with -DENABLE_UNDEFINED_SANTIZER=ON. In userspace however, UBSAN is not deadly (yet). Co-authored-by: ForLoveOfCats <ForLoveOfCats@vivaldi.net>
2021-05-24 01:40:22 +00:00
# FIXME: vptr sanitizing requires.. intense ABI wrangling of std::type_info
# And would be better served by porting ubsan_type_hash_itanium.cpp from compiler-rt
# We don't set this along with the original fsanitize=undefined because for host tools, we can rely on
# the host's libubsan to provide the ABI-specific vptr type cache.
# This is not a problem for the Kernel, because it does not have RTTI enabled :^)
if (ENABLE_UNDEFINED_SANITIZER)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize=vptr")
endif()
Meta: Add support for declaring components Components are a group of build targets that can be built and installed separately. Whether a component should be built can be configured with CMake arguments: -DBUILD_<NAME>=ON|OFF, where <NAME> is the name of the component (in all caps). Components can be marked as REQUIRED if they're necessary for a minimally functional base system or they can be marked as RECOMMENDED if they're not strictly necessary but are useful for most users. A component can have an optional description which isn't used by the build system but may be useful for a configuration UI. Components specify the TARGETS which should be built when the component is enabled. They can also specify other components which they depend on (with DEPENDS). This also adds the BUILD_EVERYTHING CMake variable which lets the user build all optional components. For now this defaults to ON to make the transition to the components-based build system easier. The list of components is exported as an INI file in the build directory (e.g. Build/i686/components.ini). Fixes #8048.
2021-06-15 13:07:25 +00:00
add_custom_target(components ALL)
option(BUILD_EVERYTHING "Build all optional components" ON)
include(${CMAKE_SOURCE_DIR}/Meta/CMake/utils.cmake)
serenity_component(
Tests
RECOMMENDED
)
Ports: Fix CMake-based ports The SDL port failed to build because the CMake toolchain filed pointed to the old root. Now the toolchain file assumes that the Root is in Build/Root. Additionally, the AK/ and Kernel/ headers need to be installed in the root too.
2020-05-26 18:20:24 +00:00
add_subdirectory(AK)
Build: Switch to CMake :^) Closes https://github.com/SerenityOS/serenity/issues/2080
2020-05-06 15:40:06 +00:00
add_subdirectory(Kernel)
add_subdirectory(Userland)
Tests: Establish root Tests directory, move Userland/Tests there With the goal of centralizing all tests in the system, this is a first step to establish a Tests sub-tree. It will contain all of the unit tests and test harnesses for the various components in the system.
2021-05-06 08:14:50 +00:00
add_subdirectory(Tests)
Base: Remove /res/pci.ids and download at build time instead This is an external file from https://pci-ids.ucw.cz that's being updated daily, which was imported a while ago but probably shouldn't live in the SerenityOS repository in the first place (or else would need manual maintenance). The legal aspects of redistributing this file as we currently do are not quite clear to me, they require either GPL (version 2 or later) or 3-clause BSD - Serenity is 2-clause BSD... The current version we use is 2019.08.08, so quite outdated - and while most of these devices are obviously not supported, we're still capable of *listing* them, so having an up-to-date version with recent additions and fixes would be nice. This updates the root CMakeLists.txt to check for existence of the file and download it if not found - effectively on every fresh build. Do note that this is not a critical file, and the system runs just fine should this ever fail. :^)
2021-02-06 23:52:40 +00:00
Meta: Add support for declaring components Components are a group of build targets that can be built and installed separately. Whether a component should be built can be configured with CMake arguments: -DBUILD_<NAME>=ON|OFF, where <NAME> is the name of the component (in all caps). Components can be marked as REQUIRED if they're necessary for a minimally functional base system or they can be marked as RECOMMENDED if they're not strictly necessary but are useful for most users. A component can have an optional description which isn't used by the build system but may be useful for a configuration UI. Components specify the TARGETS which should be built when the component is enabled. They can also specify other components which they depend on (with DEPENDS). This also adds the BUILD_EVERYTHING CMake variable which lets the user build all optional components. For now this defaults to ON to make the transition to the components-based build system easier. The list of components is exported as an INI file in the build directory (e.g. Build/i686/components.ini). Fixes #8048.
2021-06-15 13:07:25 +00:00
export_components("${CMAKE_BINARY_DIR}/components.ini")
Build: Download and uncompress gzipped version of pci.ids Partially addresses #5611.
2021-03-03 22:50:25 +00:00
set(PCI_IDS_GZ_URL https://pci-ids.ucw.cz/v2.2/pci.ids.gz)
set(PCI_IDS_GZ_PATH ${CMAKE_BINARY_DIR}/pci.ids.gz)
set(PCI_IDS_PATH ${CMAKE_BINARY_DIR}/pci.ids)
set(PCI_IDS_INSTALL_PATH ${CMAKE_INSTALL_DATAROOTDIR}/pci.ids)
if(ENABLE_PCI_IDS_DOWNLOAD AND NOT EXISTS ${PCI_IDS_GZ_PATH})
message(STATUS "Downloading PCI ID database from ${PCI_IDS_GZ_URL}...")
file(DOWNLOAD ${PCI_IDS_GZ_URL} ${PCI_IDS_GZ_PATH} INACTIVITY_TIMEOUT 10)
endif()
if(EXISTS ${PCI_IDS_GZ_PATH} AND NOT EXISTS ${PCI_IDS_INSTALL_PATH})
message(STATUS "Extracting PCI ID database from ${PCI_IDS_GZ_PATH}...")
execute_process(COMMAND gzip -k -d ${PCI_IDS_GZ_PATH})
file(MAKE_DIRECTORY ${CMAKE_INSTALL_DATAROOTDIR})
file(RENAME ${PCI_IDS_PATH} ${PCI_IDS_INSTALL_PATH})
Base: Remove /res/pci.ids and download at build time instead This is an external file from https://pci-ids.ucw.cz that's being updated daily, which was imported a while ago but probably shouldn't live in the SerenityOS repository in the first place (or else would need manual maintenance). The legal aspects of redistributing this file as we currently do are not quite clear to me, they require either GPL (version 2 or later) or 3-clause BSD - Serenity is 2-clause BSD... The current version we use is 2019.08.08, so quite outdated - and while most of these devices are obviously not supported, we're still capable of *listing* them, so having an up-to-date version with recent additions and fixes would be nice. This updates the root CMakeLists.txt to check for existence of the file and download it if not found - effectively on every fresh build. Do note that this is not a critical file, and the system runs just fine should this ever fail. :^)
2021-02-06 23:52:40 +00:00
endif()
Userland/Libraries: Add LibUSBDB library Simple clone of LibPCIDB to support USB IDs instead of PCI ones. The format is basically identical, besides a few changes of the double tab fields.
2021-06-09 14:24:04 +00:00
set(USB_IDS_GZ_URL http://www.linux-usb.org/usb.ids.gz)
set(USB_IDS_GZ_PATH ${CMAKE_BINARY_DIR}/usb.ids.gz)
set(USB_IDS_PATH ${CMAKE_BINARY_DIR}/usb.ids)
set(USB_IDS_INSTALL_PATH ${CMAKE_INSTALL_DATAROOTDIR}/usb.ids)
if(ENABLE_USB_IDS_DOWNLOAD AND NOT EXISTS ${USB_IDS_GZ_PATH})
message(STATUS "Downloading USB ID database from ${USB_IDS_GZ_URL}...")
file(DOWNLOAD ${USB_IDS_GZ_URL} ${USB_IDS_GZ_PATH} INACTIVITY_TIMEOUT 10)
endif()
if(EXISTS ${USB_IDS_GZ_PATH} AND NOT EXISTS ${USB_IDS_INSTALL_PATH})
message(STATUS "Extracting USB ID database from ${USB_IDS_GZ_PATH}...")
execute_process(COMMAND gzip -k -d ${USB_IDS_GZ_PATH})
file(MAKE_DIRECTORY ${CMAKE_INSTALL_DATAROOTDIR})
file(RENAME ${USB_IDS_PATH} ${USB_IDS_INSTALL_PATH})
endif()
Reference in a new issue Copy permalink