This is part 1 of general fixes to get the Photos desktop app back up
and building after moving to this monorepo. The main change in this PR
is to reformat the source to match the prettier config for the other
JS/TS (web/, docs/) code. And a few other fixes.
It still doesn't build, and there are a few eslint errors too. Those
will come in a subsequent PR.
- to the web alias for shared albums during nightly deployments
- Remove duplicate favicon link
- Capitalize Ente
- Document translation
- Remove the unnecessary console warning
## Description
Changed,
1. Section title in the discovery page
2. Page title in the page that pops up on tapping the > next to the
header on the discovery page
for Location and Description section.
This flow probably got broken when the select-all-for-a-day
functionality got added in https://github.com/ente-io/ente/pull/674
(haven't dug into this, I'm just guessing since that's where this all
got touched).
Thank you to @Bramas on our Discord for pointing this out, and also
providing the fix:
https://github.com/ente-io/ente/compare/main...Bramas:ente:fix-error-on-shared-album
Tested by
---------
Run normal web app on one terminal
NEXT_PUBLIC_ENTE_ENDPOINT=http://localhost:8080
NEXT_PUBLIC_ENTE_ALBUMS_ENDPOINT=http://localhost:3002 yarn dev
Run the albums listener on another port (need to do this since we're
running on localhost, and need to bind to a different origin):
NEXT_PUBLIC_ENTE_ENDPOINT=http://localhost:8080
NEXT_PUBLIC_ENTE_ALBUMS_ENDPOINT=http://localhost:3002 yarn dev:albums
Create a shared album, copy its public link, and verify that
- Before the fix we were getting an error (trying to access properties
of `galleryContext.selectedFile`)
- After the fix the shared album is visible
This flow probably got broken when the select-all-for-a-day functionality got
added in https://github.com/ente-io/ente/pull/674 (haven't dug into this, I'm
just guessing since that's where this all got touched).
Thank you to @Bramas on our Discord for pointing this out, and also providing the fix:
https://github.com/ente-io/ente/compare/main...Bramas:ente:fix-error-on-shared-album
Tested by
---------
Run normal web app on one terminal
NEXT_PUBLIC_ENTE_ENDPOINT=http://localhost:8080 NEXT_PUBLIC_ENTE_ALBUMS_ENDPOINT=http://localhost:3002 yarn dev
Run the albums listener on another port (need to do this since we're running on
localhost, and need to bind to a different origin):
NEXT_PUBLIC_ENTE_ENDPOINT=http://localhost:8080 NEXT_PUBLIC_ENTE_ALBUMS_ENDPOINT=http://localhost:3002 yarn dev:albums
Create a shared album, copy its public link, and verify that
- Before the fix we were getting an error (trying to access properties of `galleryContext.selectedFile`)
- After the fix the shared album is visible
## Description
After this commit https://github.com/ente-io/ente/pull/430 those 6 icons
I tried to add do not shows the icon or default letter, but icon is
filled with hexcolor, so I guess hexcolor is not needed.
After this commit https://github.com/ente-io/ente/pull/430 those 6 icons I tried to add do not shows the icon or default letter, but icon is filled with hexcolor, so I guess hexcolor is not needed.
