This reverts commit 4ed194f397.
@daviddeepan I had to revert your PR unfortunately.
Two main functional issues was:
- When trying to upload files, if I would search something without
results, the dialog would just close instantly.
- As a user, I expect to be able to move out of the search bar with
escape. However, pressing escape closes the whole dialog, causing the
user's drag and dropped or selected files to be lost. This is not
specifically a problem with the code added in this commit, however this
UX will need to be fixed in some way before introducing the search bar.
One medium issue:
- The dialog box kept changing size when I searched. This is visually
jarring.
Other minor issues:
- The input element did not match the look and feel for the rest of the
search input elements in the app. Aligning the search bar to the left
and right of the album thumbnails and using the MUI Input element (as
our code uses MUI elements in other places) might've fixed it.
- There were various debugging console.logs left over, once of which
even seemed like a case we need to handle.
- The strings were not localized.
---
Again, I appreciate your effort, but I think let us leave this for now,
we can come back to it in the future after having thought more about the
UX.
This reverts commit 4ed194f397.
Two main functional issues was:
- When trying to upload files, if I would search something without results, the
dialog would just close.
- As a user, I expect to be able to move out of the search bar with
escape. However, pressing escape closes the whole dialog, causing the user's
drag and dropped or selected files to be lost. This is not specifically a
problem with the code added in this commit, however this UX will need to be
fixed in some way before introducing the search bar.
One medium issue:
- The dialog box kept changing size when I searched. This is visually jarring.
Other minor issues:
- The input element did not match the look and feel for the rest of the search
input elements in the app. Aligning the search bar to the left and right of
the album thumbnails and using the MUI Input element (as our code uses MUI
elements in other places) might've fixed it.
- There were various debugging console.logs left over, once of which even seemed
like a case we need to handle.
- The strings were not localized.
See:
https://github.com/ente-io/ente/discussions/1449#discussioncomment-9255346
I'm not yet sure what was the case why it was not initialized, hoping to
get some logs for the error when initializing the cache to see how we
got to this state. But meanwhile, ensure that the code works even
without the cache.
See: https://github.com/ente-io/ente/discussions/1449#discussioncomment-9255346
I'm not yet sure what was the case why it was not initialized, hoping to get
some logs for the error when initializing the cache to see how we got to this
state. But meanwhile, ensure that the code works even without the cache.
