[ci skip]
These were half-baked and mostly badly-designed. The Unit Box theme was never finished, is completely broken,
and if we were to do a major theme refresh we'd probably go in another direction. The Widescreen theme was a
legacy experiment that was never adopted and as of now is basically alsp completely broken.
@mattsc spotted that attack prediction sometimes gives incorrect results
for chance to stay unscathed when the other unit can die during the battle.
The old calculation algorithm worked by determining the chance that the
unit survives each unit unscathed, and multiplying the probabilities
together.
However, that method of probability calculations works only if the
attacks are independent, i.e. the probability of surviving *this* attack
unscathed doesn't depend on the chance of being already unscathed. And
that's not the case if either combatant can kill the other one.
If combatant A has killed combatant B, combatant B can't strike it any more
and therefore combatant A is more likely to *be* unscathed. Inversely, if A
is unscathed, it's more likely that B is dead. As a result, if A is
unscathed, A is also more likely to *stay* unscathed. The old method
couldn't take that into account and therefore produced incorrect results.
In my local tests, this new algorithm appears to produce correct results.
Only rounding errors (and drain ability) separate it from the HP
distribution tables.
* Overrule any CSS clear properties set by the stylesheet since they do
not play well with the page's use of a floated TOC.
* Use em dashes instead of hyphens for entry comments.
* Refer to the main contributors as Core Contributors instead of simply
Contributors, and add a custom heading for localization entries so it
doesn't become just "Core" after the folder name.
* Additional styling on file paths.
[ci skip]
args.loc is the location we use for 'filter as if the unit woudl be there', still the unit is curently at args.u.get_location() so to make scoped_xy_unit find the unit we have to give args.u.get_location()
Backslashes only work on Windows. A UMC author may accidentally use them in
their add-on that won't then work properly on GNU/Linux and macOS.
Just disallow them on all platforms to avoid problems.
GUI2 no longer needs this. An empty icon is simply not drawn, and the addon list widget forces
72x72 size for all icons so it's not even needed to size the image column. The image-not-found
image is also handled elsewhere (the general image loading code) and isn't needed here.