* Detail the `GNUInstallDirs` changes
* Non-Windows builds now use the absolute path for all
data paths. This is less brittle, as relative path
lookup in Unix always depends on the current value of
the PWD environmental variable.
* GNUInstallDirs is the only Kitware-supported
way to change the default directories. Most
distributions have hooks for changing these
directories, which makes integrating wesnoth
easier and more consistent with the rest of
the CMake ecosystem.
* Make build system perfectly out-of-source
compatible. The build system should never
touch files in the source tree.
@newfrenchy83 said that the build is failing:
37225d24ea (commitcomment-25629052)
It looks like TDM-GCC uses Windows XP development headers, unfortunately.
However, the problem is easy to work around by simply #defining the missing
value ourselves. We should consider dropping TDM-GCC support after the 1.14
release, though.
* The dialog now owns its own create_engine object. Previously, it was created immediately
adjacent to the dialog object and passed in by reference, which made no sense.
* The create_engine also no longer takes a CVideo reference and instead initializes its CVideo
member from the singleton.
* The 'Registered Users Only' toggle is now disabled if the host isn't registered themselves
(fixes#2206)
* The above setting, along with Observers, Strict Sync, and Game Password, are disabled in local
mode. These don't really make sense when not playing a networked game.
Taking an argument, especially by reference, does not require a full type.
Including unit.hpp in make.hpp utterly defeats the point of make.hpp's existence.
Previously, there was temptation for players to ditch all of their
undead before leaving the land of the dead scenarios so they had
Delfador instead of the undead able to kill Iliah-Malal.
PR #1725 moved the compiled translations from the translations directory to the po directory.
I would have noticed sooner if Git had not been told to ignore virtually all MO files.
* Detail the `GNUInstallDirs` changes
* Non-Windows builds now use the absolute path for all
data paths. This is less brittle, as relative path
lookup in Unix always depends on the current value of
the PWD environmental variable.
* GNUInstallDirs is the only Kitware-supported
way to change the default directories. Most
distributions have hooks for changing these
directories, which makes integrating wesnoth
easier and more consistent with the rest of
the CMake ecosystem.
* Make build system perfectly out-of-source
compatible. The build system should never
touch files in the source tree.
@newfrenchy83 said that the build is failing:
37225d24ea (commitcomment-25629052)
It looks like TDM-GCC uses Windows XP development headers, unfortunately.
However, the problem is easy to work around by simply #defining the missing
value ourselves. We should consider dropping TDM-GCC support after the 1.14
release, though.
