dawn.png was leftover from the Time of Day being shown with an overlay
image; 074e157400 removed dusk.png and
night.png. The image itself should be a transparent blue hexagon, but
the alpha channel was corrupted, and so it appeared completely
transparent.
In copyrights.csv, make the capitalisation of Kitty's name consistent,
and attribute the orb-disengaged.png image.
Map/Scenario Editor
* Rename Load Map to Load Map/Scenario (since it can load both), Edit Scenario to Edit Scenario Settings, Save Map to just Save.
* Rearrange menu order
* Add icon for the preferences menu item (used the preexisting settings.png icon)
* Open folder correctly at Add-on's scenario directory instead of editor/scenarios. (#8910)
* Show Save Scenario As only for Scenarios
* Use the settings.png icon for Preferences menu item
* Add functionality to "Loyal" checkbox (Unit tool -> Place unit -> Right click menu) (#8445)
* Show warning when maps are saved in scenarios folder or vice versa (#8911)
* Unit List moved to Units menu from File menu to reduce some pressure from the latter.
* Status Table menu item disabled since it does nothing. (Should be reenabled once the functionality has been added.)
* Improve reload functionality in Editor (F5). Reload happens directly from memory and no temp files are needed. Also, the undo/redo stacks will be preserved. (#9024)
Time Schedule Editor
* Browse buttons now set wesnoth style paths instead of just pasting the absolute path returned by the file dialog
* Change text boxes from inactive to uneditable.
* Code generation improvements
* Add copyright notice to tod_new_schedule
* Confirmation messages
* Preview buttons for image and sound files and new icons for the preview button (2 sets : preview image and preview sound)
Unit Type Editor
* Confirmation messages
* New icons for the preview button (2 sets : preview image and preview sound)
Add-on menu
* Two new menu entries for (1) opening the Add-on selection dialog, (2) opening the folder corresponding to the Add-on
The open add-on folder option shows a GUI2 file dialog at the add-on's folder which can be used to open any file. If it is a loadable map/scenario it will be opened in the editor, otherwise the OS's default application for that file will be opened.
File Dialog
* Redesigned with new icons
* New Open External button that opens selected file/folder in the platform's default application (independently of what pressing Open would do). This could be used to quickly open a folder or preview the file before actually selecting it.
* Extension checking and filename validation. (See #8911)
* Redesigned the version dialog to serve as a general purpose About dialog.
* Credits button removed from title screen
* Moved community dialog contents to about dialog as new tab
Co-Authored-By: Pentarctagon
* Bugfixes to the tab_container widget
* Success indication mechanism on copy buttons
Derived from the core water-plant.png and water-plant2.png images.
Copyright attribution updates by octalot:
They've been darkened since the original commit, but the swamp water
tiles in data/core/images/terrain/swamp are clearly Tommy(yobbo)'s
images originally added in f7cc2f1079.
The current water-tile.png seems to be a later addition, so I've
left it attributed to "unknown".
Co-authored-by: Steve Cotton <steve@octalot.co.uk>
This should prevent accidental uses of commas in fields without quotes.
It would have caught the previous issue of str.join() not quoting fields
that contain commas. For now though, it found a different issue: three
rows added in commit c631345314 had duplicated MD5 fields.
str.join() isn't smart enough to quote CSV fields when necessary, so
a field containing field separators (commas) would get parsed by the
second update_copyrights run as multiple fields. Upon finding some rows
containing an extra field, the csv.reader() object then added an extra
blank field to each of all the other rows.
Use csv.writer() instead of str.join() to write proper CSV output.
This commit also undoes the removal of commas from fields that was
necessary in commit 676c1fa2b9.
Commit 97c8feb8ca (pull #7903) specified for 58 of LordBob's portraits
a license of "GNU GPL v2+;CC BY-SA 4.0". I don't know if the semicolon
is supposed to mean "and" or "or".
"And" (e.g. a GNU GPL v2+ file with CC BY-SA 4.0 modifications) isn't
legally possible. "Or" appears incorrect, because LordBob [licensed][1]
his portraits under "the GNU GPL" and I can't find any evidence of him
also licensing them under CC BY-SA 4.0.
Also make update_copyrights check for possibly invalid licenses like
"GNU GPL v2+;CC BY-SA 4.0".
[1]: https://forums.wesnoth.org/viewtopic.php?p=329342#p329342
Commit 97c8feb8ca (pull #7903) included a comma in the "Notes" field
of four files, which instead of being enclosed in quotes, overflowed
into the "Needs Update" field. So if those files are updated,
update_copyrights would clobber part of the notes.
Commit 1ecd4f4d59 (pull #8195) updated the "Date" field but didn't
clear "Needs Update" after update_copyrights set "Needs Update" and
"MD5" for data/core/images/units/monsters/raven/harbinger.png.
Make update_copyrights check for and warn about "Needs Update" instead
of clobbering it. This should trigger CI failures if someone forgets
to update a row or accidentally puts into the "Needs Update" field
important information that shouldn't be clobbered on future updates.
* various minor monster sprite updates
* small fixes to wolf portraits, jumping spider portraits
* NE anims for jumping spider
* adding zombie fish, zombie bug
* portrait for elder falcon
* elder falcon attack anims
* fix a couple typos in Falcon attack anim
* elder falcon defense anims
* update copyrights.csv (twice, as per the new policy)
When the tool finds new or changed files, it puts them at the top of
the output .csv file for easy editing. However, this means that those
lines move when update_copyrights is run again. It also means that any
two PRs touching images are likely to have merge conflicts, as they'll
change line 2 of copyrights.csv.
Make the CI fail unless the file has been sorted again after editing.
* fix raven SE sprite wings
* revisions to fire ant sprites to make more distinct from each other
* fix flame positioning
* minor soldier ant sprite update
* add IPF arg to MISSILE_FRAME_FIRE_BREATH for use in fire ants
* update copyrights.csv
