0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove history expansion

Browse source 
It's rarely useful and just gets in the way. Fixes #3328.
This commit is contained in:
Gunter Labes 2024-04-22 14:46:05 +02:00
parent c7be17bb76
commit de92a87419
No known key found for this signature in database
GPG key ID: C0C7B971CC910216
1 changed files with 0 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/gui/dialogs/lua_interpreter.cpp
View file

@ -315,31 +315,6 @@ public:
return "History is disabled, you did not compile with GNU history support.";
#endif
}
// Does history expansion in a command line. A return value of true indicates an error,
// the error message will be returned in the string argument. A return value of false
// indicates success and that execution should proceed.
bool do_history_expansion ([[maybe_unused]] std::string & cmd) {
#ifdef HAVE_HISTORY
// Do history expansions
std::unique_ptr<char[]> cmd_cstr(new char[cmd.length()+1]);
strcpy (cmd_cstr.get(), cmd.c_str());
char * expansion;
int result = history_expand(cmd_cstr.get(), &expansion);
if (result < 0 || result == 2) {
cmd = expansion; // return error message in cmd var
free(expansion);
return true;
}
cmd = expansion;
free(expansion);
#endif
return false;
}
};
/**
@ -557,12 +532,6 @@ void lua_interpreter::controller::execute()
return;
}
if (input_model_->do_history_expansion(cmd)) {
lua_model_->add_dialog_message(cmd);
update_view();
return;
}
if (lua_model_->execute(cmd)) {
input_model_->add_to_history(cmd);
text_entry->set_value("");