0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

eclipse plugin: Use a StringBuilder instead of simple...

Browse source 
...string concatenation.

Issue found by "FindBugs"
This commit is contained in:
Timotei Dolean 2011-04-10 10:33:15 +00:00
parent 118be9d89d
commit d35b6f9c51
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
utils/java/org.wesnoth/src/org/wesnoth/schema/SchemaParser.java
View file

@ -153,35 +153,37 @@ public class SchemaParser
else if (tagStack.peek().equals("description")) //$NON-NLS-1$
{
String[] tokens = line.trim().split("="); //$NON-NLS-1$
String value = ""; //$NON-NLS-1$
StringBuilder value = new StringBuilder(); //$NON-NLS-1$
// this *should* happen only in [description]
// multi-line string
if (StringUtils.countOf(tokens[1], '"') % 2 != 0)
{
value = tokens[1] + "\n"; //$NON-NLS-1$
value.append(tokens[1] + "\n"); //$NON-NLS-1$
++index;
while (StringUtils.countOf(lines[index], '"') % 2 == 0 &&
!StringUtils.startsWith(lines[index], "#") && //$NON-NLS-1$
index < lines.length)
{
value += (lines[index] + "\n"); //$NON-NLS-1$
value.append(lines[index] + "\n"); //$NON-NLS-1$
++index;
}
value += lines[index];
value.append(lines[index]);
}
else
{
value = tokens[1];
value.append(tokens[1]);
}
// get rid of the quotes
if (value.length() >= 2)
{
value = value.substring(1, value.length() - 1);
value = new StringBuilder(value.substring(1, value.length() - 1));
}
currentTag.setDescription(new Tag(Messages.SchemaParser_25, '?'));
currentTag.getDescription().getKeyChildren().add(
new TagKey(tokens[0], '?', "", value, true)); //$NON-NLS-1$
new TagKey(tokens[0], '?', "", value.toString(), true)); //$NON-NLS-1$
}
else
{