0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

eclipse plugin: Use the entrySet iterator instead of keySet...

Browse source 
...instead of looking up the value by key, since we use both key and
value.

Issue found by "FindBugs"
This commit is contained in:
Timotei Dolean 2011-04-10 10:32:57 +00:00
parent dd5f575196
commit 118be9d89d
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
utils/java/org.wesnoth/src/org/wesnoth/utils/AntUtils.java
View file

@ -13,6 +13,7 @@ import java.io.File;
import java.io.PrintStream;
import java.util.Iterator;
import java.util.Map;
import java.util.Map.Entry;
import org.apache.tools.ant.BuildLogger;
import org.apache.tools.ant.DefaultLogger;
@ -50,12 +51,11 @@ public class AntUtils
File buildFile = new File(antFile);
ProjectHelper.configureProject(project, buildFile);
Iterator<String> iterator = properties.keySet().iterator();
Iterator<Entry<String, String>> iterator = properties.entrySet().iterator();
while (iterator.hasNext())
{
String key = iterator.next();
String value = properties.get(key);
project.setUserProperty(key, value);
Entry<String, String> key = iterator.next();
project.setUserProperty(key.getKey(), key.getValue());
}
project.executeTarget(project.getDefaultTarget());