0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix TestInvalidRemoteDriver() to check underlying error

Browse source 
commit b1a3fe4934 changed how the error was
returned (which is now wrapped), causing the test to fail:

    === RUN   TestInvalidRemoteDriver
        libnetwork_test.go:1289: Did not fail with expected error. Actual error: Plugin does not implement the requested driver: plugin="invalid-network-driver", requested implementation="NetworkDriver"
    --- FAIL: TestInvalidRemoteDriver (0.01s)

Changing the test to use errors.Is()

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2021-10-25 14:57:18 +02:00
parent 4283e93e64
commit eadf839530
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 2 additions and 1 deletions

3
libnetwork/libnetwork_test.go
View file

@ -4,6 +4,7 @@
package libnetwork_test
import (
"errors"
"fmt"
"net"
"net/http"
@ -1285,7 +1286,7 @@ func TestInvalidRemoteDriver(t *testing.T) {
t.Fatal("Expected to fail. But instead succeeded")
}
if err != plugins.ErrNotImplements {
if !errors.Is(err, plugins.ErrNotImplements) {
t.Fatalf("Did not fail with expected error. Actual error: %v", err)
}
}