c0952e3670
We are currently allocating in Set's constructor to create the set's underlying Map. This can cause GC to occur before the member is actually initialized, thus we will crash in Set::visit_edges trying to visit a member that does not exist. Instead, create the Map in Set::initialize, where we can allocate. Also change Map to be stored as a normal JS heap-allocated object, rather than as a stack variable.
32 lines
533 B
C++
32 lines
533 B
C++
/*
|
|
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/Runtime/Set.h>
|
|
|
|
namespace JS {
|
|
|
|
Set* Set::create(Realm& realm)
|
|
{
|
|
return realm.heap().allocate<Set>(realm, *realm.intrinsics().set_prototype());
|
|
}
|
|
|
|
Set::Set(Object& prototype)
|
|
: Object(prototype)
|
|
{
|
|
}
|
|
|
|
void Set::initialize(Realm& realm)
|
|
{
|
|
m_values = Map::create(realm);
|
|
}
|
|
|
|
void Set::visit_edges(Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_values);
|
|
}
|
|
|
|
}
|