0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2
ladybird/Userland/Libraries/LibWeb/CSS/StyleValues
History
Aliaksandr Kalenik 707ca984bd LibWeb: Fix memory leak in CSS::ImageStyleValue 
Before this change, whenever ImageStyleValue had a non-null
`m_image_request`, it was always leaked along with everything related
to the document to which this value belongs. The issue arises due to
the use of `JS::Handle` for the image request, as it introduces a
cyclic dependency where `ImageRequest` prevents the `CSSStyleSheet`,
that owns `ImageStyleValue`, from being deallocated:
- ImageRequest
- FetchController
- FetchParams
- Window
- HTMLDocument
- HTMLHtmlElement
- HTMLBodyElement
- Text
- HTMLHeadElement
- Text
- HTMLMetaElement
- Text
- HTMLTitleElement
- Text
- HTMLStyleElement
- CSSStyleSheet

This change solves this by visiting `m_image_request` from
`visit_edges` instead of introducing new heap root by using
`JS::Handle`.
2023-09-25 04:16:36 +02:00
..
AbstractImageStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
AngleStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
AngleStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
BackgroundRepeatStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
BackgroundRepeatStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
BackgroundSizeStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
BackgroundSizeStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
BorderRadiusStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
BorderRadiusStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
CalculatedStyleValue.cpp LibWeb: Mark CalculatedStyleValue::resolve_integer() as const 2023-09-11 17:03:22 +01:00
CalculatedStyleValue.h LibWeb: Mark CalculatedStyleValue::resolve_integer() as const 2023-09-11 17:03:22 +01:00
ColorStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ColorStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ConicGradientStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ConicGradientStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ContentStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ContentStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
CustomIdentStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
DisplayStyleValue.cpp LibWeb: Make StyleValue constructors infallible 2023-08-19 17:34:22 +02:00
DisplayStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
EasingStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
EasingStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
EdgeStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
EdgeStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
FilterValueListStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
FilterValueListStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
FrequencyStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridAutoFlowStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridAutoFlowStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridTemplateAreaStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridTemplateAreaStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridTrackPlacementStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridTrackPlacementStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridTrackSizeListStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
GridTrackSizeListStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
IdentifierStyleValue.cpp LibWeb: Remove FrameLoader 2023-09-20 18:29:17 +02:00
IdentifierStyleValue.h LibWeb: Deduplicate "ident is color" check 2023-08-25 20:30:20 +01:00
ImageStyleValue.cpp LibWeb: Change viewport ownership from BrowsingContext to Navigable 2023-09-16 16:53:32 +02:00
ImageStyleValue.h LibWeb: Fix memory leak in CSS::ImageStyleValue 2023-09-25 04:16:36 +02:00
InheritStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
InitialStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
IntegerStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
IntegerStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
LengthStyleValue.cpp LibWeb: Make absolutizing StyleValues infallible 2023-08-19 17:34:22 +02:00
LengthStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
LinearGradientStyleValue.cpp AK: Add to_radians and to_degrees math functions 2023-09-10 08:38:29 +01:00
LinearGradientStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
MathDepthStyleValue.cpp LibWeb: Implement the math-depth CSS property 2023-09-11 17:03:22 +01:00
MathDepthStyleValue.h LibWeb: Implement the math-depth CSS property 2023-09-11 17:03:22 +01:00
NumberStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
NumberStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
PercentageStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
PositionStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
PositionStyleValue.h LibWeb: Fix "egde" typo 2023-09-25 00:46:21 +01:00
RadialGradientStyleValue.cpp LibWeb: Use CSSPixels only when calculating radial gradient sizes 2023-09-09 13:03:11 +02:00
RadialGradientStyleValue.h LibWeb: Use CSSPixels only when calculating radial gradient sizes 2023-09-09 13:03:11 +02:00
RatioStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
RectStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
RectStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ResolutionStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
RevertStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ShadowStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ShadowStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
ShorthandStyleValue.cpp LibWeb: Replace OverflowStyleValue with ShorthandStyleValue 2023-09-25 00:46:21 +01:00
ShorthandStyleValue.h LibWeb: Replace FlexStyleValue with ShorthandStyleValue 2023-09-20 12:17:16 +01:00
StringStyleValue.h LibWeb: Serialize StringStyleValue with quotes 2023-09-12 14:29:21 +01:00
StyleValueList.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
StyleValueList.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
TimeStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
TransformationStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
TransformationStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
UnresolvedStyleValue.cpp LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
UnresolvedStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
UnsetStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00
URLStyleValue.h LibWeb: Make StyleValue::to_string() infallible 2023-08-22 17:51:48 +01:00