LibWeb: Always allow scripting in workers for now

Workers don't have a document, so we can't ask them if scripting is enabled or not. This is not the right long-term fix, but it fixes an assertion when trying to query the missing responsible document of a web worker.
Author: https://github.com/awesomekling Commit: https://github.com/SerenityOS/serenity/commit/cb15132146 Pull-request: https://github.com/SerenityOS/serenity/pull/14816 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/linusg ✅
2022-09-05 12:21:48 +02:00 · 2022-09-05 12:21:48 +02:00 · cb15132146 · 2024-07-17 07:23:39 +09:00
commit cb15132146
parent e97cc671ea
1 changed files with 4 additions and 0 deletions
--- a/Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp
+++ b/Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp
@ -244,6 +244,10 @@ bool EnvironmentSettingsObject::is_scripting_enabled() const
    // The user agent supports scripting.
    // NOTE: This is always true in LibWeb :^)

+    // FIXME: Do the right thing for workers.
+    if (!is<HTML::Window>(m_realm_execution_context->realm->global_object()))
+        return true;
+
    // The user has not disabled scripting for settings at this time. (User agents may provide users with the option to disable scripting globally, or in a finer-grained manner, e.g., on a per-origin basis, down to the level of individual environment settings objects.)
    auto document = const_cast<EnvironmentSettingsObject&>(*this).responsible_document();
    VERIFY(document);