0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-14 18:30:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Use length() getter in CharacterData algorithms

Browse source 
Closer matching spec text, as well as pre-existing use in
CharacterData::substring_data. This helps in porting of this file over
to new String which has no length member function.
This commit is contained in:
Shannon Booth 2023-09-07 19:54:28 +12:00 committed by Sam Atkins
parent e8f14f8cd0
commit b2f3aa1c76
Notes: sideshowbarker 2024-07-17 07:31:31 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/b2f3aa1c76
Pull-request: https://github.com/SerenityOS/serenity/pull/21024
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/CharacterData.cpp
View file

@ -33,7 +33,7 @@ void CharacterData::set_data(DeprecatedString data)
// NOTE: Since the offset is 0, it can never be above data's length, so this can never throw.
// NOTE: Setting the data to the same value as the current data still causes a mutation observer callback.
// FIXME: Figure out a way to make this a no-op again if the passed in data is the same as the current data.
MUST(replace_data(0, m_data.length(), data));
MUST(replace_data(0, this->length(), data));
}
// https://dom.spec.whatwg.org/#concept-cd-substring
@ -124,7 +124,7 @@ WebIDL::ExceptionOr<void> CharacterData::replace_data(size_t offset, size_t coun
WebIDL::ExceptionOr<void> CharacterData::append_data(DeprecatedString const& data)
{
// The appendData(data) method steps are to replace data with node this, offset this’s length, count 0, and data data.
return replace_data(m_data.length(), 0, data);
return replace_data(this->length(), 0, data);
}
// https://dom.spec.whatwg.org/#dom-characterdata-insertdata