Parcourir la source

LibWeb: Use length() getter in CharacterData algorithms

Closer matching spec text, as well as pre-existing use in
CharacterData::substring_data. This helps in porting of this file over
to new String which has no length member function.
Shannon Booth il y a 1 an
Parent
commit
b2f3aa1c76
1 fichiers modifiés avec 2 ajouts et 2 suppressions
  1. 2 2
      Userland/Libraries/LibWeb/DOM/CharacterData.cpp

+ 2 - 2
Userland/Libraries/LibWeb/DOM/CharacterData.cpp

@@ -33,7 +33,7 @@ void CharacterData::set_data(DeprecatedString data)
     // NOTE: Since the offset is 0, it can never be above data's length, so this can never throw.
     // NOTE: Since the offset is 0, it can never be above data's length, so this can never throw.
     // NOTE: Setting the data to the same value as the current data still causes a mutation observer callback.
     // NOTE: Setting the data to the same value as the current data still causes a mutation observer callback.
     // FIXME: Figure out a way to make this a no-op again if the passed in data is the same as the current data.
     // FIXME: Figure out a way to make this a no-op again if the passed in data is the same as the current data.
-    MUST(replace_data(0, m_data.length(), data));
+    MUST(replace_data(0, this->length(), data));
 }
 }
 
 
 // https://dom.spec.whatwg.org/#concept-cd-substring
 // https://dom.spec.whatwg.org/#concept-cd-substring
@@ -124,7 +124,7 @@ WebIDL::ExceptionOr<void> CharacterData::replace_data(size_t offset, size_t coun
 WebIDL::ExceptionOr<void> CharacterData::append_data(DeprecatedString const& data)
 WebIDL::ExceptionOr<void> CharacterData::append_data(DeprecatedString const& data)
 {
 {
     // The appendData(data) method steps are to replace data with node this, offset this’s length, count 0, and data data.
     // The appendData(data) method steps are to replace data with node this, offset this’s length, count 0, and data data.
-    return replace_data(m_data.length(), 0, data);
+    return replace_data(this->length(), 0, data);
 }
 }
 
 
 // https://dom.spec.whatwg.org/#dom-characterdata-insertdata
 // https://dom.spec.whatwg.org/#dom-characterdata-insertdata