LibCrypto: Don't return reference to stack frame in PBKDF

A reference to the current stack frame becomes invalid after returning, so returning Bytes is pointless. I don't understand why this wasn't discovered earlier, but it caused some CI problems for me, so I fixed it. Don't take this as encouragement to break master! :^)
Author: https://github.com/BenWiederhake Commit: https://github.com/SerenityOS/serenity/commit/968f2b3eeb Pull-request: https://github.com/SerenityOS/serenity/pull/19211 Reviewed-by: https://github.com/gmta
2023-06-01 20:52:24 +02:00 · 2023-06-01 20:52:24 +02:00 · 968f2b3eeb · 2024-07-16 23:44:30 +09:00
commit 968f2b3eeb
parent 522809032a
1 changed files with 1 additions and 1 deletions
--- a/Userland/Libraries/LibCrypto/Hash/PBKDF2.h
+++ b/Userland/Libraries/LibCrypto/Hash/PBKDF2.h
@ -15,7 +15,7 @@ namespace Crypto::Hash {
 class PBKDF2 {
 public:
    template<typename PRF>
-    static ErrorOr<Bytes> derive_key(ReadonlyBytes password, ReadonlyBytes salt, u32 iterations, u32 key_length_bytes)
+    static ErrorOr<ByteBuffer> derive_key(ReadonlyBytes password, ReadonlyBytes salt, u32 iterations, u32 key_length_bytes)
    requires requires(PRF t) {
                 t.digest_size();
             }