瀏覽代碼

LibCrypto: Don't return reference to stack frame in PBKDF

A reference to the current stack frame becomes invalid after returning,
so returning Bytes is pointless.

I don't understand why this wasn't discovered earlier, but it caused
some CI problems for me, so I fixed it.

Don't take this as encouragement to break master! :^)
Ben Wiederhake 2 年之前
父節點
當前提交
968f2b3eeb
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      Userland/Libraries/LibCrypto/Hash/PBKDF2.h

+ 1 - 1
Userland/Libraries/LibCrypto/Hash/PBKDF2.h

@@ -15,7 +15,7 @@ namespace Crypto::Hash {
 class PBKDF2 {
 class PBKDF2 {
 public:
 public:
     template<typename PRF>
     template<typename PRF>
-    static ErrorOr<Bytes> derive_key(ReadonlyBytes password, ReadonlyBytes salt, u32 iterations, u32 key_length_bytes)
+    static ErrorOr<ByteBuffer> derive_key(ReadonlyBytes password, ReadonlyBytes salt, u32 iterations, u32 key_length_bytes)
     requires requires(PRF t) {
     requires requires(PRF t) {
                  t.digest_size();
                  t.digest_size();
              }
              }