Remove migration code

lib/services/files_service.dart

@@ -42,6 +42,8 @@ class FilesService {
     }
   }
 
+  // Note: this method is not used anywhere, but it is kept for future
+  // reference when we add bulk EditTime feature
   Future<void> bulkEditTime(
     List<File> files,
     EditTimeSource source,

lib/services/local_file_update_service.dart

@@ -2,21 +2,12 @@ import 'dart:async';
 import 'dart:core';
 import 'dart:io';
 
-import "package:collection/collection.dart";
 import 'package:flutter/foundation.dart';
 import 'package:logging/logging.dart';
-import 'package:photos/core/configuration.dart';
-import 'package:photos/core/constants.dart';
 import 'package:photos/core/errors.dart';
 import 'package:photos/db/file_updation_db.dart';
 import 'package:photos/db/files_db.dart';
-import 'package:photos/extensions/stop_watch.dart';
 import 'package:photos/models/file.dart' as ente;
-import "package:photos/models/location/location.dart";
-import "package:photos/models/magic_metadata.dart";
-import "package:photos/services/file_magic_service.dart";
-import 'package:photos/services/files_service.dart';
-import "package:photos/utils/exif_util.dart";
 import 'package:photos/utils/file_uploader_util.dart';
 import 'package:photos/utils/file_util.dart';
 import 'package:shared_preferences/shared_preferences.dart';
@@ -27,15 +18,14 @@ class LocalFileUpdateService {
   late FileUpdationDB _fileUpdationDB;
   late SharedPreferences _prefs;
   late Logger _logger;
-  static const isBadCreationTimeImportDone = 'fm_badCreationTime';
-  static const isBadCreationTimeMigrationComplete =
-      'fm_badCreationTimeCompleted';
-  static const isMissingLocationV2ImportDone = "fm_missingLocationV2ImportDone";
-  static const isMissingLocationV2MigrationDone =
-      "fm_missingLocationV2MigrationDone";
-
-  static const isBadLocationCordImportDone = "fm_badLocationImportDone";
-  static const isBadLocationCordMigrationDone = "fm_badLocationMigrationDone";
+  final List<String> _oldMigrationKeys = [
+    'fm_badCreationTime',
+    'fm_badCreationTimeCompleted',
+    'fm_missingLocationV2ImportDone',
+    'fm_missingLocationV2MigrationDone',
+    'fm_badLocationImportDone',
+    'fm_badLocationMigrationDone',
+  ];
 
   Completer<void>? _existingMigration;
 
@@ -51,10 +41,6 @@ class LocalFileUpdateService {
   static LocalFileUpdateService instance =
       LocalFileUpdateService._privateConstructor();
 
-  bool isBadCreationMigrationCompleted() {
-    return (_prefs.getBool(isBadCreationTimeMigrationComplete) ?? false);
-  }
-
   Future<void> markUpdatedFilesForReUpload() async {
     if (_existingMigration != null) {
       _logger.info("migration is already in progress, skipping");
@@ -64,9 +50,7 @@ class LocalFileUpdateService {
     try {
       await _markFilesWhichAreActuallyUpdated();
       if (Platform.isAndroid) {
-        await _migrationForFixingBadCreationTime();
-        await _migrationFilesWithMissingLocationV2();
-        await _migrationFilesWithBadLocationCord();
+        _cleanUpOlderMigration();
       }
     } catch (e, s) {
       _logger.severe('failed to perform migration', e, s);
@@ -76,6 +60,22 @@ class LocalFileUpdateService {
     }
   }
 
+  void _cleanUpOlderMigration() {
+    // check if any old_migration_keys are present in shared preferences
+    bool hasOldMigrationKey = false;
+    for (String key in _oldMigrationKeys) {
+      if (_prefs.containsKey(key)) {
+        hasOldMigrationKey = true;
+        break;
+      }
+    }
+    if (hasOldMigrationKey) {
+      for (var element in _oldMigrationKeys) {
+        _prefs.remove(element);
+      }
+    }
+  }
+
   // This method analyses all of local files for which the file
   // modification/update time was changed. It checks if the existing fileHash
   // is different from the hash of uploaded file. If fileHash are different,
@@ -162,241 +162,4 @@ class LocalFileUpdateService {
     }
     return mediaUploadData;
   }
-
-  Future<void> _migrationForFixingBadCreationTime() async {
-    if (_prefs.containsKey(isBadCreationTimeMigrationComplete)) {
-      return;
-    }
-    await _importFilesWithBadCreationTime();
-    const int singleRunLimit = 100;
-    try {
-      final generatedIDs =
-          await _fileUpdationDB.getLocalIDsForPotentialReUpload(
-        singleRunLimit,
-        FileUpdationDB.badCreationTime,
-      );
-      if (generatedIDs.isNotEmpty) {
-        final List<int> genIdIntList = [];
-        for (String genIdString in generatedIDs) {
-          final int? genIdInt = int.tryParse(genIdString);
-          if (genIdInt != null) {
-            genIdIntList.add(genIdInt);
-          }
-        }
-
-        final filesWithBadTime =
-            (await FilesDB.instance.getFilesFromGeneratedIDs(genIdIntList))
-                .values
-                .toList();
-        filesWithBadTime.removeWhere(
-          (e) => e.isUploaded && e.pubMagicMetadata?.editedTime != null,
-        );
-        await FilesService.instance
-            .bulkEditTime(filesWithBadTime, EditTimeSource.fileName);
-      } else {
-        // everything is done
-        await _prefs.setBool(isBadCreationTimeMigrationComplete, true);
-      }
-      await _fileUpdationDB.deleteByLocalIDs(
-        generatedIDs,
-        FileUpdationDB.badCreationTime,
-      );
-    } catch (e) {
-      _logger.severe("Failed to fix bad creationTime", e);
-    }
-  }
-
-  Future<void> _importFilesWithBadCreationTime() async {
-    if (_prefs.containsKey(isBadCreationTimeImportDone)) {
-      return;
-    }
-    _logger.info('_importFilesWithBadCreationTime');
-    final EnteWatch watch = EnteWatch("_importFilesWithBadCreationTime");
-    final int ownerID = Configuration.instance.getUserID()!;
-    final filesGeneratedID = await FilesDB.instance
-        .getGeneratedIDForFilesOlderThan(jan011981Time, ownerID);
-    await _fileUpdationDB.insertMultiple(
-      filesGeneratedID,
-      FileUpdationDB.badCreationTime,
-    );
-    watch.log("imported ${filesGeneratedID.length} files");
-    _prefs.setBool(isBadCreationTimeImportDone, true);
-  }
-
-  Future<void> _migrationFilesWithMissingLocationV2() async {
-    if (_prefs.containsKey(isMissingLocationV2MigrationDone)) {
-      return;
-    }
-    await _importForMissingLocationV2();
-    const int singleRunLimit = 10;
-    final List<String> processedIDs = [];
-    try {
-      final localIDs = await _fileUpdationDB.getLocalIDsForPotentialReUpload(
-        singleRunLimit,
-        FileUpdationDB.missingLocationV2,
-      );
-      if (localIDs.isEmpty) {
-        // everything is done
-        await _prefs.setBool(isMissingLocationV2MigrationDone, true);
-        return;
-      }
-
-      final List<ente.File> enteFiles = await FilesDB.instance
-          .getFilesForLocalIDs(localIDs, Configuration.instance.getUserID()!);
-      // fine localIDs which are not present in enteFiles
-      final List<String> missingLocalIDs = [];
-      for (String localID in localIDs) {
-        if (enteFiles.firstWhereOrNull((e) => e.localID == localID) == null) {
-          missingLocalIDs.add(localID);
-        }
-      }
-      processedIDs.addAll(missingLocalIDs);
-
-      final List<ente.File> remoteFilesToUpdate = [];
-      final Map<int, Map<String, double>> fileIDToUpdateMetadata = {};
-
-      for (ente.File file in enteFiles) {
-        final Location? location = await tryLocationFromExif(file);
-        if (location != null && Location.isValidLocation(location)) {
-          remoteFilesToUpdate.add(file);
-          fileIDToUpdateMetadata[file.uploadedFileID!] = {
-            pubMagicKeyLat: location.latitude!,
-            pubMagicKeyLong: location.longitude!
-          };
-        } else if (file.localID != null) {
-          processedIDs.add(file.localID!);
-        }
-      }
-      if (remoteFilesToUpdate.isNotEmpty) {
-        await FileMagicService.instance.updatePublicMagicMetadata(
-          remoteFilesToUpdate,
-          null,
-          metadataUpdateMap: fileIDToUpdateMetadata,
-        );
-        for (ente.File file in remoteFilesToUpdate) {
-          if (file.localID != null) {
-            processedIDs.add(file.localID!);
-          }
-        }
-      }
-    } catch (e) {
-      _logger.severe("Failed to fix bad creationTime", e);
-    } finally {
-      await _fileUpdationDB.deleteByLocalIDs(
-        processedIDs,
-        FileUpdationDB.missingLocationV2,
-      );
-    }
-  }
-
-  Future<void> _importForMissingLocationV2() async {
-    if (_prefs.containsKey(isMissingLocationV2ImportDone)) {
-      return;
-    }
-    _logger.info('_importForMissingLocationV2');
-    final EnteWatch watch = EnteWatch("_importForMissingLocationV2");
-    final int ownerID = Configuration.instance.getUserID()!;
-    final List<String> localIDs =
-        await FilesDB.instance.getLocalIDsForFilesWithoutLocation(ownerID);
-
-    await _fileUpdationDB.insertMultiple(
-      localIDs,
-      FileUpdationDB.missingLocationV2,
-    );
-    watch.log("imported ${localIDs.length} files");
-    await _prefs.setBool(isMissingLocationV2ImportDone, true);
-  }
-
-  Future<void> _migrationFilesWithBadLocationCord() async {
-    if (_prefs.containsKey(isBadLocationCordMigrationDone)) {
-      return;
-    }
-    await _importForBadLocationCord();
-    const int singleRunLimit = 10;
-    final List<String> processedIDs = [];
-    try {
-      final localIDs = await _fileUpdationDB.getLocalIDsForPotentialReUpload(
-        singleRunLimit,
-        FileUpdationDB.badLocationCord,
-      );
-      if (localIDs.isEmpty) {
-        // everything is done
-        await _prefs.setBool(isBadLocationCordMigrationDone, true);
-        return;
-      }
-
-      final List<ente.File> enteFiles = await FilesDB.instance
-          .getFilesForLocalIDs(localIDs, Configuration.instance.getUserID()!);
-      // fine localIDs which are not present in enteFiles
-      final List<String> missingLocalIDs = [];
-      for (String localID in localIDs) {
-        if (enteFiles.firstWhereOrNull((e) => e.localID == localID) == null) {
-          missingLocalIDs.add(localID);
-        }
-      }
-      processedIDs.addAll(missingLocalIDs);
-
-      final List<ente.File> remoteFilesToUpdate = [];
-      final Map<int, Map<String, double>> fileIDToUpdateMetadata = {};
-
-      for (ente.File file in enteFiles) {
-        final Location? location = await tryLocationFromExif(file);
-        if (location != null &&
-            (location.latitude ?? 0) != 0.0 &&
-            (location.longitude ?? 0) != 0.0) {
-          // check if the location is already correct
-          if (file.location != null &&
-              file.location?.longitude == location.latitude &&
-              file.location?.longitude == location.longitude) {
-            processedIDs.add(file.localID!);
-          } else {
-            remoteFilesToUpdate.add(file);
-            fileIDToUpdateMetadata[file.uploadedFileID!] = {
-              pubMagicKeyLat: location.latitude!,
-              pubMagicKeyLong: location.longitude!
-            };
-          }
-        } else if (file.localID != null) {
-          processedIDs.add(file.localID!);
-        }
-      }
-      if (remoteFilesToUpdate.isNotEmpty) {
-        await FileMagicService.instance.updatePublicMagicMetadata(
-          remoteFilesToUpdate,
-          null,
-          metadataUpdateMap: fileIDToUpdateMetadata,
-        );
-        for (ente.File file in remoteFilesToUpdate) {
-          if (file.localID != null) {
-            processedIDs.add(file.localID!);
-          }
-        }
-      }
-    } catch (e) {
-      _logger.severe("Failed to fix bad location cord", e);
-    } finally {
-      await _fileUpdationDB.deleteByLocalIDs(
-        processedIDs,
-        FileUpdationDB.badLocationCord,
-      );
-    }
-  }
-
-  Future<void> _importForBadLocationCord() async {
-    if (_prefs.containsKey(isBadLocationCordImportDone)) {
-      return;
-    }
-    _logger.info('_importForBadLocationCord');
-    final EnteWatch watch = EnteWatch("_importForBadLocationCord");
-    final int ownerID = Configuration.instance.getUserID()!;
-    final List<String> localIDs = await FilesDB.instance
-        .getFilesWithLocationUploadedBtw20AprTo15May2023(ownerID);
-
-    await _fileUpdationDB.insertMultiple(
-      localIDs,
-      FileUpdationDB.badLocationCord,
-    );
-    watch.log("imported ${localIDs.length} files");
-    await _prefs.setBool(isBadLocationCordImportDone, true);
-  }
 }