0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Perf: Only refresh cache for fetched collections (#1136)

Browse source
This commit is contained in:
Neeraj Gupta 2023-05-24 08:38:31 +05:30 • committed by GitHub
commit d41e974657
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/services/collections_service.dart
View file

@ -108,13 +108,13 @@ class CollectionsService {
final updatedCollections = <Collection>[];
int maxUpdationTime = lastCollectionUpdationTime;
final ownerID = _config.getUserID();
bool fireEventForCollectionDeleted = false;
bool shouldFireDeleteEvent = false;
for (final collection in fetchedCollections) {
if (collection.isDeleted) {
await _filesDB.deleteCollection(collection.id);
await setCollectionSyncTime(collection.id, null);
if (_collectionIDToCollections.containsKey(collection.id)) {
fireEventForCollectionDeleted = true;
shouldFireDeleteEvent = true;
}
}
// remove reference for incoming collections when unshared/deleted
@ -129,7 +129,7 @@ class CollectionsService {
? collection.updationTime
: maxUpdationTime;
}
if (fireEventForCollectionDeleted) {
if (shouldFireDeleteEvent) {
Bus.instance.fire(
LocalPhotosUpdatedEvent(
List<File>.empty(),
@ -140,12 +140,11 @@ class CollectionsService {
await _updateDB(updatedCollections);
_prefs.setInt(_collectionsSyncTimeKey, maxUpdationTime);
watch.logAndReset("till DB insertion ${updatedCollections.length}");
final collections = await _db.getAllCollections();
for (final collection in collections) {
for (final collection in fetchedCollections) {
_cacheCollectionAttributes(collection);
}
_logger.info("Collections synced");
watch.log("collection cache refresh");
watch.log("${fetchedCollections.length} collection cached refreshed ");
if (fetchedCollections.isNotEmpty) {
Bus.instance.fire(
CollectionUpdatedEvent(