|
@@ -20,25 +20,23 @@ ld.lld: error: undefined symbol: notifier::NotifierOptions::NotifierOptions()
|
|
|
chrome/android/java/AndroidManifest.xml | 28 ------
|
|
|
.../android/java/res/xml/main_preferences.xml | 14 ---
|
|
|
.../chrome/browser/ChromeActivity.java | 34 -------
|
|
|
- .../browser/preferences/MainPreferences.java | 86 +-----------------
|
|
|
+ .../browser/settings/MainPreferences.java | 86 +-----------------
|
|
|
.../DataReductionPreferenceFragment.java | 24 ++---
|
|
|
- .../privacy/PrivacyPreferences.java | 7 --
|
|
|
+ .../settings/privacy/PrivacyPreferences.java | 7 --
|
|
|
.../sync/SyncAndServicesPreferences.java | 8 --
|
|
|
.../chrome/browser/signin/SigninManager.java | 71 ++-------------
|
|
|
- .../java/strings/android_chrome_strings.grd | 18 ----
|
|
|
.../android/signin/signin_manager_android.cc | 1 -
|
|
|
- .../impl/invalidation_service_util.cc | 21 -----
|
|
|
- .../impl/invalidation_service_util.h | 6 +-
|
|
|
+ .../strings/android_chrome_strings.grd | 18 ----
|
|
|
.../signin/SystemAccountManagerDelegate.java | 38 +-------
|
|
|
.../components/sync/AndroidSyncSettings.java | 24 +----
|
|
|
.../net/HttpNegotiateAuthenticator.java | 88 +------------------
|
|
|
.../chromoting/base/OAuthTokenFetcher.java | 2 -
|
|
|
- 17 files changed, 26 insertions(+), 447 deletions(-)
|
|
|
+ 15 files changed, 25 insertions(+), 421 deletions(-)
|
|
|
|
|
|
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
|
|
|
--- a/chrome/android/BUILD.gn
|
|
|
+++ b/chrome/android/BUILD.gn
|
|
|
-@@ -1136,8 +1136,7 @@ jinja_template_resources("chrome_public_apk_template_resources") {
|
|
|
+@@ -1114,8 +1114,7 @@ jinja_template_resources("chrome_public_apk_template_resources") {
|
|
|
resources = [
|
|
|
"java/res_template/xml/file_paths.xml",
|
|
|
"java/res_template/xml/launchershortcuts.xml",
|
|
@@ -83,7 +81,7 @@ diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/Andro
|
|
|
{% block extra_uses_permissions %}
|
|
|
{% endblock %}
|
|
|
|
|
|
-@@ -960,16 +952,6 @@ by a child template that "extends" this file.
|
|
|
+@@ -978,16 +970,6 @@ by a child template that "extends" this file.
|
|
|
android:resource="@xml/file_paths" />
|
|
|
</provider>
|
|
|
|
|
@@ -100,7 +98,7 @@ diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/Andro
|
|
|
<!-- Broadcast receiver that will be notified of account changes -->
|
|
|
<receiver android:name="org.chromium.chrome.browser.services.AccountsChangedReceiver">
|
|
|
<intent-filter>
|
|
|
-@@ -1077,16 +1059,6 @@ by a child template that "extends" this file.
|
|
|
+@@ -1095,16 +1077,6 @@ by a child template that "extends" this file.
|
|
|
<service android:name="org.chromium.chrome.browser.services.gcm.InvalidationGcmUpstreamSender"
|
|
|
android:exported="false"/>
|
|
|
|
|
@@ -128,7 +126,7 @@ diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/j
|
|
|
- android:key="account_section"
|
|
|
- android:order="0"
|
|
|
- android:title="@string/prefs_section_account"/>
|
|
|
-- <org.chromium.chrome.browser.preferences.sync.SignInPreference
|
|
|
+- <org.chromium.chrome.browser.settings.sync.SignInPreference
|
|
|
- android:key="sign_in"
|
|
|
- android:order="1"
|
|
|
- android:title="@string/sign_in_to_chrome"/>
|
|
@@ -140,27 +138,27 @@ diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/j
|
|
|
android:key="languages"
|
|
|
android:order="16"
|
|
|
android:title="@string/prefs_languages"/>
|
|
|
-- <org.chromium.chrome.browser.preferences.ChromeBasePreference
|
|
|
-- android:fragment="org.chromium.chrome.browser.preferences.datareduction.DataReductionPreferenceFragment"
|
|
|
+- <org.chromium.chrome.browser.settings.ChromeBasePreference
|
|
|
+- android:fragment="org.chromium.chrome.browser.settings.datareduction.DataReductionPreferenceFragment"
|
|
|
- android:key="data_reduction"
|
|
|
- android:order="17"
|
|
|
- android:title="@string/data_reduction_title_lite_mode"/>
|
|
|
- <org.chromium.chrome.browser.preferences.ChromeBasePreference
|
|
|
- android:fragment="org.chromium.chrome.browser.preferences.download.DownloadPreferences"
|
|
|
+ <org.chromium.chrome.browser.settings.ChromeBasePreference
|
|
|
+ android:fragment="org.chromium.chrome.browser.settings.download.DownloadPreferences"
|
|
|
android:key="downloads"
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
|
|
|
-@@ -129,8 +129,6 @@ import org.chromium.chrome.browser.share.ShareMenuActionHandler;
|
|
|
+@@ -131,8 +131,6 @@ import org.chromium.chrome.browser.share.ShareDelegateImpl;
|
|
|
import org.chromium.chrome.browser.snackbar.BottomContainer;
|
|
|
import org.chromium.chrome.browser.snackbar.SnackbarManager;
|
|
|
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;
|
|
|
-import org.chromium.chrome.browser.sync.ProfileSyncService;
|
|
|
-import org.chromium.chrome.browser.sync.SyncController;
|
|
|
import org.chromium.chrome.browser.tab.Tab;
|
|
|
- import org.chromium.chrome.browser.tab.TabBrowserControlsState;
|
|
|
- import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;
|
|
|
-@@ -268,9 +266,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+ import org.chromium.chrome.browser.tab.TabBrowserControlsConstraintsHelper;
|
|
|
+ import org.chromium.chrome.browser.tab.TabImpl;
|
|
|
+@@ -255,9 +253,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
@SuppressLint("NewApi")
|
|
|
private TouchExplorationStateChangeListener mTouchExplorationStateChangeListener;
|
|
|
|
|
@@ -170,7 +168,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.
|
|
|
@Nullable
|
|
|
private ChromeFullscreenManager mFullscreenManager;
|
|
|
|
|
|
-@@ -919,28 +914,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+@@ -870,28 +865,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
private void createContextReporterIfNeeded() {
|
|
|
if (!mStarted) return; // Sync state reporting should work only in started state.
|
|
|
if (mContextReporter != null || getActivityTab() == null) return;
|
|
@@ -199,7 +197,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.
|
|
|
}
|
|
|
|
|
|
@Override
|
|
|
-@@ -1008,13 +981,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
+@@ -963,13 +936,6 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
|
|
|
if (GSAState.getInstance(this).isGsaAvailable() && !SysUtils.isLowEndDevice()) {
|
|
|
GSAAccountChangeListener.getInstance().disconnect();
|
|
|
}
|
|
@@ -213,24 +211,26 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.
|
|
|
if (mContextReporter != null) mContextReporter.disable();
|
|
|
|
|
|
super.onStopWithNative();
|
|
|
-diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
|
|
|
---- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
|
|
|
-+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
|
|
|
-@@ -17,13 +17,11 @@ import org.chromium.base.ContextUtils;
|
|
|
- import org.chromium.base.VisibleForTesting;
|
|
|
+diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/MainPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/MainPreferences.java
|
|
|
+--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/MainPreferences.java
|
|
|
++++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/MainPreferences.java
|
|
|
+@@ -19,7 +19,6 @@ import org.chromium.base.ContextUtils;
|
|
|
import org.chromium.chrome.R;
|
|
|
import org.chromium.chrome.browser.ChromeFeatureList;
|
|
|
+ import org.chromium.chrome.browser.flags.FeatureUtilities;
|
|
|
-import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
|
|
|
import org.chromium.chrome.browser.night_mode.NightModeUtils;
|
|
|
import org.chromium.chrome.browser.offlinepages.prefetch.PrefetchConfiguration;
|
|
|
import org.chromium.chrome.browser.partnercustomizations.HomepageManager;
|
|
|
- import org.chromium.chrome.browser.password_manager.ManagePasswordsReferrer;
|
|
|
- import org.chromium.chrome.browser.preferences.autofill_assistant.AutofillAssistantPreferences;
|
|
|
--import org.chromium.chrome.browser.preferences.datareduction.DataReductionPreferenceFragment;
|
|
|
- import org.chromium.chrome.browser.preferences.developer.DeveloperPreferences;
|
|
|
- import org.chromium.chrome.browser.preferences.sync.SignInPreference;
|
|
|
- import org.chromium.chrome.browser.preferences.sync.SyncPreferenceUtils;
|
|
|
-@@ -42,16 +40,11 @@ import java.util.Map;
|
|
|
+@@ -27,7 +26,6 @@ import org.chromium.chrome.browser.password_manager.ManagePasswordsReferrer;
|
|
|
+ import org.chromium.chrome.browser.password_manager.PasswordManagerLauncher;
|
|
|
+ import org.chromium.chrome.browser.search_engines.TemplateUrlServiceFactory;
|
|
|
+ import org.chromium.chrome.browser.settings.autofill_assistant.AutofillAssistantPreferences;
|
|
|
+-import org.chromium.chrome.browser.settings.datareduction.DataReductionPreferenceFragment;
|
|
|
+ import org.chromium.chrome.browser.settings.developer.DeveloperSettings;
|
|
|
+ import org.chromium.chrome.browser.settings.sync.SignInPreference;
|
|
|
+ import org.chromium.chrome.browser.settings.sync.SyncPreferenceUtils;
|
|
|
+@@ -44,16 +42,11 @@ import java.util.Map;
|
|
|
* The main settings screen, shown when the user first opens Settings.
|
|
|
*/
|
|
|
public class MainPreferences extends PreferenceFragmentCompat
|
|
@@ -248,7 +248,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
public static final String PREF_NOTIFICATIONS = "notifications";
|
|
|
public static final String PREF_LANGUAGES = "languages";
|
|
|
public static final String PREF_DOWNLOADS = "downloads";
|
|
|
-@@ -65,7 +58,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -67,7 +60,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
|
|
|
private final ManagedPreferenceDelegate mManagedPreferenceDelegate;
|
|
|
private final Map<String, Preference> mAllPreferences = new HashMap<>();
|
|
@@ -256,7 +256,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
|
|
|
public MainPreferences() {
|
|
|
setHasOptionsMenu(true);
|
|
|
-@@ -88,35 +80,16 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -90,35 +82,16 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
@Override
|
|
|
public void onDestroy() {
|
|
|
super.onDestroy();
|
|
@@ -292,8 +292,8 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
}
|
|
|
|
|
|
@Override
|
|
|
-@@ -129,12 +102,9 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
- PreferenceUtils.addPreferencesFromResource(this, R.xml.main_preferences);
|
|
|
+@@ -131,12 +104,9 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+ SettingsUtils.addPreferencesFromResource(this, R.xml.main_preferences);
|
|
|
cachePreferences();
|
|
|
|
|
|
- mSignInPreference.setOnStateChangedCallback(this::onSignInPreferenceStateChanged);
|
|
@@ -305,7 +305,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
|
|
|
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
|
|
|
// If we are on Android O+ the Notifications preference should lead to the Android
|
|
|
-@@ -188,7 +158,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -190,7 +160,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
Preference preference = getPreferenceScreen().getPreference(index);
|
|
|
mAllPreferences.put(preference.getKey(), preference);
|
|
|
}
|
|
@@ -313,7 +313,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
}
|
|
|
|
|
|
private void setManagedPreferenceDelegateForPreference(String key) {
|
|
|
-@@ -197,13 +166,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -199,13 +168,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
}
|
|
|
|
|
|
private void updatePreferences() {
|
|
@@ -327,7 +327,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
updateSearchEnginePreference();
|
|
|
|
|
|
Preference homepagePref = addPreferenceIfAbsent(PREF_HOMEPAGE);
|
|
|
-@@ -220,10 +182,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -222,10 +184,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
} else {
|
|
|
removePreferenceIfPresent(PREF_DEVELOPER);
|
|
|
}
|
|
@@ -338,7 +338,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
}
|
|
|
|
|
|
private Preference addPreferenceIfAbsent(String key) {
|
|
|
-@@ -237,13 +195,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -239,13 +197,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
if (preference != null) getPreferenceScreen().removePreference(preference);
|
|
|
}
|
|
|
|
|
@@ -352,7 +352,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
private void updateSearchEnginePreference() {
|
|
|
if (!TemplateUrlServiceFactory.get().isLoaded()) {
|
|
|
ChromeBasePreference searchEnginePref =
|
|
|
-@@ -275,28 +226,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -277,28 +228,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
pref.setSummary(isOn ? R.string.text_on : R.string.text_off);
|
|
|
}
|
|
|
|
|
@@ -381,7 +381,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
// TemplateUrlService.LoadListener implementation.
|
|
|
@Override
|
|
|
public void onTemplateUrlServiceLoaded() {
|
|
|
-@@ -304,11 +233,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -306,11 +235,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
updateSearchEnginePreference();
|
|
|
}
|
|
|
|
|
@@ -393,7 +393,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
@VisibleForTesting
|
|
|
ManagedPreferenceDelegate getManagedPreferenceDelegateForTest() {
|
|
|
return mManagedPreferenceDelegate;
|
|
|
-@@ -318,9 +242,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -320,9 +244,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
return new ManagedPreferenceDelegate() {
|
|
|
@Override
|
|
|
public boolean isPreferenceControlledByPolicy(Preference preference) {
|
|
@@ -403,7 +403,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
if (PREF_SEARCH_ENGINE.equals(preference.getKey())) {
|
|
|
return TemplateUrlServiceFactory.get().isDefaultSearchManaged();
|
|
|
}
|
|
|
-@@ -329,11 +250,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
+@@ -331,11 +252,6 @@ public class MainPreferences extends PreferenceFragmentCompat
|
|
|
|
|
|
@Override
|
|
|
public boolean isPreferenceClickDisabledByPolicy(Preference preference) {
|
|
@@ -415,12 +415,12 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Mai
|
|
|
if (PREF_SEARCH_ENGINE.equals(preference.getKey())) {
|
|
|
return TemplateUrlServiceFactory.get().isDefaultSearchManaged();
|
|
|
}
|
|
|
-diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferenceFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferenceFragment.java
|
|
|
---- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferenceFragment.java
|
|
|
-+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferenceFragment.java
|
|
|
+diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java
|
|
|
+--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java
|
|
|
++++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/datareduction/DataReductionPreferenceFragment.java
|
|
|
@@ -50,10 +50,10 @@ public class DataReductionPreferenceFragment extends PreferenceFragmentCompat {
|
|
|
public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
|
|
|
- PreferenceUtils.addPreferencesFromResource(this, R.xml.data_reduction_preferences);
|
|
|
+ SettingsUtils.addPreferencesFromResource(this, R.xml.data_reduction_preferences);
|
|
|
getActivity().setTitle(R.string.data_reduction_title_lite_mode);
|
|
|
- boolean isEnabled = DataReductionProxySettings.getInstance().isDataReductionProxyEnabled();
|
|
|
- mIsEnabled = !isEnabled;
|
|
@@ -456,17 +456,17 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/dat
|
|
|
}
|
|
|
|
|
|
/**
|
|
|
-diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
|
|
|
---- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
|
|
|
-+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
|
|
|
-@@ -23,7 +23,6 @@ import org.chromium.chrome.browser.preferences.Pref;
|
|
|
- import org.chromium.chrome.browser.preferences.PrefServiceBridge;
|
|
|
- import org.chromium.chrome.browser.preferences.PreferenceUtils;
|
|
|
- import org.chromium.chrome.browser.preferences.PreferencesLauncher;
|
|
|
--import org.chromium.chrome.browser.preferences.sync.SyncAndServicesPreferences;
|
|
|
- import org.chromium.chrome.browser.profiles.Profile;
|
|
|
+diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/privacy/PrivacyPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/privacy/PrivacyPreferences.java
|
|
|
+--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/privacy/PrivacyPreferences.java
|
|
|
++++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/privacy/PrivacyPreferences.java
|
|
|
+@@ -24,7 +24,6 @@ import org.chromium.chrome.browser.settings.ChromeBaseCheckBoxPreference;
|
|
|
+ import org.chromium.chrome.browser.settings.ManagedPreferenceDelegate;
|
|
|
+ import org.chromium.chrome.browser.settings.PreferencesLauncher;
|
|
|
+ import org.chromium.chrome.browser.settings.SettingsUtils;
|
|
|
+-import org.chromium.chrome.browser.settings.sync.SyncAndServicesPreferences;
|
|
|
import org.chromium.chrome.browser.usage_stats.UsageStatsConsentDialog;
|
|
|
import org.chromium.ui.text.NoUnderlineClickableSpan;
|
|
|
+ import org.chromium.ui.text.SpanApplier;
|
|
|
@@ -39,9 +38,6 @@ public class PrivacyPreferences
|
|
|
private static final String PREF_NETWORK_PREDICTIONS = "preload_pages";
|
|
|
private static final String PREF_DO_NOT_TRACK = "do_not_track";
|
|
@@ -487,10 +487,10 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/pri
|
|
|
ChromeBaseCheckBoxPreference searchSuggestionsPref =
|
|
|
(ChromeBaseCheckBoxPreference) findPreference(PREF_SEARCH_SUGGESTIONS);
|
|
|
searchSuggestionsPref.setOnPreferenceChangeListener(this);
|
|
|
-diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/sync/SyncAndServicesPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/sync/SyncAndServicesPreferences.java
|
|
|
---- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/sync/SyncAndServicesPreferences.java
|
|
|
-+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/sync/SyncAndServicesPreferences.java
|
|
|
-@@ -167,15 +167,7 @@ public class SyncAndServicesPreferences extends PreferenceFragmentCompat
|
|
|
+diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/sync/SyncAndServicesPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/sync/SyncAndServicesPreferences.java
|
|
|
+--- a/chrome/android/java/src/org/chromium/chrome/browser/settings/sync/SyncAndServicesPreferences.java
|
|
|
++++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/sync/SyncAndServicesPreferences.java
|
|
|
+@@ -175,15 +175,7 @@ public class SyncAndServicesPreferences extends PreferenceFragmentCompat
|
|
|
|
|
|
mPrivacyPrefManager.migrateNetworkPredictionPreferences();
|
|
|
|
|
@@ -504,23 +504,22 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/syn
|
|
|
- RecordUserAction.record("Signin_Signin_ShowAdvancedSyncSettings");
|
|
|
- }
|
|
|
|
|
|
- PreferenceUtils.addPreferencesFromResource(this, R.xml.sync_and_services_preferences);
|
|
|
+ SettingsUtils.addPreferencesFromResource(this, R.xml.sync_and_services_preferences);
|
|
|
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
|
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
|
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
|
|
|
-@@ -23,10 +23,7 @@ import org.chromium.base.metrics.RecordHistogram;
|
|
|
+@@ -22,9 +22,6 @@ import org.chromium.base.metrics.RecordHistogram;
|
|
|
import org.chromium.base.metrics.RecordUserAction;
|
|
|
import org.chromium.base.task.PostTask;
|
|
|
import org.chromium.chrome.browser.externalauth.ExternalAuthUtils;
|
|
|
-import org.chromium.components.signin.AccountIdProvider;
|
|
|
- import org.chromium.components.signin.AccountManagerFacade;
|
|
|
-import org.chromium.components.signin.AccountTrackerService;
|
|
|
-import org.chromium.components.signin.ChromeSigninController;
|
|
|
import org.chromium.components.signin.identitymanager.ClearAccountsAction;
|
|
|
import org.chromium.components.signin.identitymanager.CoreAccountInfo;
|
|
|
import org.chromium.components.signin.identitymanager.IdentityManager;
|
|
|
-@@ -52,7 +49,7 @@ import java.util.List;
|
|
|
+@@ -50,7 +47,7 @@ import java.util.List;
|
|
|
* See chrome/browser/signin/signin_manager_android.h for more details.
|
|
|
*/
|
|
|
public class SigninManager
|
|
@@ -571,9 +570,9 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninMa
|
|
|
|
|
|
- mAccountTrackerService.addSystemAccountsSeededListener(this);
|
|
|
mIdentityManager.addObserver(this);
|
|
|
- }
|
|
|
|
|
|
-@@ -241,7 +234,6 @@ public class SigninManager
|
|
|
+ reloadAllAccountsFromSystem();
|
|
|
+@@ -243,7 +236,6 @@ public class SigninManager
|
|
|
@CalledByNative
|
|
|
public void destroy() {
|
|
|
mIdentityManager.removeObserver(this);
|
|
@@ -581,7 +580,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninMa
|
|
|
mNativeSigninManagerAndroid = 0;
|
|
|
}
|
|
|
|
|
|
-@@ -285,8 +277,7 @@ public class SigninManager
|
|
|
+@@ -282,8 +274,7 @@ public class SigninManager
|
|
|
* Returns true if signin can be started now.
|
|
|
*/
|
|
|
public boolean isSignInAllowed() {
|
|
@@ -591,7 +590,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninMa
|
|
|
}
|
|
|
|
|
|
/**
|
|
|
-@@ -342,27 +333,6 @@ public class SigninManager
|
|
|
+@@ -339,27 +330,6 @@ public class SigninManager
|
|
|
});
|
|
|
}
|
|
|
|
|
@@ -619,7 +618,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninMa
|
|
|
/**
|
|
|
* Starts the sign-in flow, and executes the callback when finished.
|
|
|
*
|
|
|
-@@ -418,14 +388,8 @@ public class SigninManager
|
|
|
+@@ -407,14 +377,8 @@ public class SigninManager
|
|
|
}
|
|
|
|
|
|
private void progressSignInFlowSeedSystemAccounts() {
|
|
@@ -636,9 +635,9 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninMa
|
|
|
}
|
|
|
|
|
|
/**
|
|
|
-@@ -459,18 +423,6 @@ public class SigninManager
|
|
|
- // This method should be called at most once per sign-in flow.
|
|
|
- assert mSignInState != null && mSignInState.mCoreAccountInfo != null;
|
|
|
+@@ -451,18 +415,6 @@ public class SigninManager
|
|
|
+ // The user should not be already signed in
|
|
|
+ assert !mIdentityManager.hasPrimaryAccount();
|
|
|
|
|
|
- if (!mIdentityMutator.setPrimaryAccount(mSignInState.mCoreAccountInfo.getId())) {
|
|
|
- Log.w(TAG, "Failed to set the PrimaryAccount in IdentityManager, aborting signin");
|
|
@@ -680,10 +679,21 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninMa
|
|
|
private void disableSyncAndWipeData(
|
|
|
boolean shouldWipeUserData, final Runnable wipeDataCallback) {
|
|
|
mAndroidSyncSettings.updateAccount(null);
|
|
|
-diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
---- a/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
-+++ b/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
-@@ -339,24 +339,12 @@ CHAR-LIMIT guidelines:
|
|
|
+diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc
|
|
|
+--- a/chrome/browser/android/signin/signin_manager_android.cc
|
|
|
++++ b/chrome/browser/android/signin/signin_manager_android.cc
|
|
|
+@@ -138,7 +138,6 @@ SigninManagerAndroid::SigninManagerAndroid(
|
|
|
+
|
|
|
+ java_signin_manager_ = Java_SigninManager_create(
|
|
|
+ base::android::AttachCurrentThread(), reinterpret_cast<intptr_t>(this),
|
|
|
+- identity_manager_->LegacyGetAccountTrackerServiceJavaObject(),
|
|
|
+ identity_manager_->GetJavaObject(),
|
|
|
+ identity_manager_->GetIdentityMutatorJavaObject());
|
|
|
+ }
|
|
|
+diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
|
+--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
|
++++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
|
+@@ -369,24 +369,12 @@ CHAR-LIMIT guidelines:
|
|
|
</message>
|
|
|
|
|
|
<!-- Sign-in, sync and personalization preferences -->
|
|
@@ -708,7 +718,7 @@ diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/and
|
|
|
<message name="IDS_SIGN_IN_TO_CHROME_DISABLED_SUMMARY" desc="A descriptive line of text that appears under the 'Sign in to Chrome' option, in Chrome Settings on Android. The text explains why 'Sign in to Chrome' is disabled. 'Administrator' refers to the IT administrator of the company/organization that owns the user’s device.">
|
|
|
Disabled by the administrator of this device
|
|
|
</message>
|
|
|
-@@ -406,9 +394,6 @@ CHAR-LIMIT guidelines:
|
|
|
+@@ -436,9 +424,6 @@ CHAR-LIMIT guidelines:
|
|
|
<message name="IDS_URL_KEYED_ANONYMIZED_DATA_SUMMARY" desc="Summary for a checkbox in Settings that controls non-personalized URL collection and informs the user about the data shared by this feature.">
|
|
|
Sends URLs of pages you visit to Google
|
|
|
</message>
|
|
@@ -718,7 +728,7 @@ diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/and
|
|
|
<message name="IDS_CANCEL_SYNC_DIALOG_TITLE" desc="The title of a dialog that is shown when users tries closing 'Sync and Google services' preferences without confirming the changes.">
|
|
|
Cancel sync?
|
|
|
</message>
|
|
|
-@@ -1265,9 +1250,6 @@ Your Google account may have other forms of browsing history like searches and a
|
|
|
+@@ -1294,9 +1279,6 @@ Your Google account may have other forms of browsing history like searches and a
|
|
|
<message name="IDS_DATA_REDUCTION_DESCRIPTION_LITE_MODE" desc="Text describing how the Lite mode feature works. Seen only before the user has enabled the feature.">
|
|
|
When Lite mode is on, Chrome uses Google servers to make pages load faster. Lite mode rewrites very slow pages to load only essential content. Lite mode does not apply to Incognito tabs.
|
|
|
</message>
|
|
@@ -728,71 +738,6 @@ diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/and
|
|
|
<message name="IDS_DATA_REDUCTION_SAVINGS_LABEL" desc="Data Reduction statistics label that states the amount of mobile data that was saved by Lite mode. Lite mode allows users to to reduce their mobile data usage by compressing network traffic.">
|
|
|
data saved
|
|
|
</message>
|
|
|
-diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc
|
|
|
---- a/chrome/browser/android/signin/signin_manager_android.cc
|
|
|
-+++ b/chrome/browser/android/signin/signin_manager_android.cc
|
|
|
-@@ -138,7 +138,6 @@ SigninManagerAndroid::SigninManagerAndroid(
|
|
|
-
|
|
|
- java_signin_manager_ = Java_SigninManager_create(
|
|
|
- base::android::AttachCurrentThread(), reinterpret_cast<intptr_t>(this),
|
|
|
-- identity_manager_->LegacyGetAccountTrackerServiceJavaObject(),
|
|
|
- identity_manager_->GetJavaObject(),
|
|
|
- identity_manager_->GetIdentityMutatorJavaObject());
|
|
|
- }
|
|
|
-diff --git a/components/invalidation/impl/invalidation_service_util.cc b/components/invalidation/impl/invalidation_service_util.cc
|
|
|
---- a/components/invalidation/impl/invalidation_service_util.cc
|
|
|
-+++ b/components/invalidation/impl/invalidation_service_util.cc
|
|
|
-@@ -12,27 +12,6 @@
|
|
|
-
|
|
|
- namespace invalidation {
|
|
|
-
|
|
|
--notifier::NotifierOptions ParseNotifierOptions(
|
|
|
-- const base::CommandLine& command_line) {
|
|
|
-- notifier::NotifierOptions notifier_options;
|
|
|
--
|
|
|
-- if (command_line.HasSwitch(switches::kSyncNotificationHostPort)) {
|
|
|
-- notifier_options.xmpp_host_port =
|
|
|
-- net::HostPortPair::FromString(
|
|
|
-- command_line.GetSwitchValueASCII(
|
|
|
-- switches::kSyncNotificationHostPort));
|
|
|
-- DVLOG(1) << "Using " << notifier_options.xmpp_host_port.ToString()
|
|
|
-- << " for test sync notification server.";
|
|
|
-- }
|
|
|
--
|
|
|
-- notifier_options.allow_insecure_connection =
|
|
|
-- command_line.HasSwitch(switches::kSyncAllowInsecureXmppConnection);
|
|
|
-- DVLOG_IF(1, notifier_options.allow_insecure_connection)
|
|
|
-- << "Allowing insecure XMPP connections.";
|
|
|
--
|
|
|
-- return notifier_options;
|
|
|
--}
|
|
|
--
|
|
|
- std::string GenerateInvalidatorClientId() {
|
|
|
- // Generate a GUID with 128 bits worth of base64-encoded randomness.
|
|
|
- // This format is similar to that of sync's cache_guid.
|
|
|
-diff --git a/components/invalidation/impl/invalidation_service_util.h b/components/invalidation/impl/invalidation_service_util.h
|
|
|
---- a/components/invalidation/impl/invalidation_service_util.h
|
|
|
-+++ b/components/invalidation/impl/invalidation_service_util.h
|
|
|
-@@ -5,7 +5,7 @@
|
|
|
- #ifndef COMPONENTS_INVALIDATION_IMPL_INVALIDATION_SERVICE_UTIL_H_
|
|
|
- #define COMPONENTS_INVALIDATION_IMPL_INVALIDATION_SERVICE_UTIL_H_
|
|
|
-
|
|
|
--#include "jingle/notifier/base/notifier_options.h"
|
|
|
-+#include <string>
|
|
|
-
|
|
|
- namespace base {
|
|
|
- class CommandLine;
|
|
|
-@@ -13,10 +13,6 @@ class CommandLine;
|
|
|
-
|
|
|
- namespace invalidation {
|
|
|
-
|
|
|
--// Parses the given command line for notifier options.
|
|
|
--notifier::NotifierOptions ParseNotifierOptions(
|
|
|
-- const base::CommandLine& command_line);
|
|
|
--
|
|
|
- // Generates a unique client ID for the invalidator.
|
|
|
- std::string GenerateInvalidatorClientId();
|
|
|
-
|
|
|
diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
|
|
|
--- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
|
|
|
+++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
|
|
@@ -893,7 +838,7 @@ diff --git a/components/sync/android/java/src/org/chromium/components/sync/Andro
|
|
|
diff --git a/net/android/java/src/org/chromium/net/HttpNegotiateAuthenticator.java b/net/android/java/src/org/chromium/net/HttpNegotiateAuthenticator.java
|
|
|
--- a/net/android/java/src/org/chromium/net/HttpNegotiateAuthenticator.java
|
|
|
+++ b/net/android/java/src/org/chromium/net/HttpNegotiateAuthenticator.java
|
|
|
-@@ -97,54 +97,8 @@ public class HttpNegotiateAuthenticator {
|
|
|
+@@ -98,54 +98,8 @@ public class HttpNegotiateAuthenticator {
|
|
|
|
|
|
@Override
|
|
|
public void run(AccountManagerFuture<Account[]> future) {
|
|
@@ -950,7 +895,7 @@ diff --git a/net/android/java/src/org/chromium/net/HttpNegotiateAuthenticator.ja
|
|
|
}
|
|
|
}
|
|
|
|
|
|
-@@ -157,42 +111,8 @@ public class HttpNegotiateAuthenticator {
|
|
|
+@@ -158,42 +112,8 @@ public class HttpNegotiateAuthenticator {
|
|
|
|
|
|
@Override
|
|
|
public void run(AccountManagerFuture<Bundle> future) {
|