|
@@ -14,21 +14,21 @@ Completely remove contacts picker permission from the file dialog
|
|
.../browser/bookmarks/BookmarkDelegate.java | 10 +
|
|
.../browser/bookmarks/BookmarkDelegate.java | 10 +
|
|
.../browser/bookmarks/BookmarkManager.java | 20 ++
|
|
.../browser/bookmarks/BookmarkManager.java | 20 ++
|
|
.../browser/bookmarks/BookmarkPage.java | 1 +
|
|
.../browser/bookmarks/BookmarkPage.java | 1 +
|
|
- .../java/strings/android_chrome_strings.grd | 6 +
|
|
|
|
chrome/browser/BUILD.gn | 8 +-
|
|
chrome/browser/BUILD.gn | 8 +-
|
|
- .../android/bookmarks/bookmark_bridge.cc | 215 ++++++++++++++++++
|
|
|
|
|
|
+ .../android/bookmarks/bookmark_bridge.cc | 217 ++++++++++++++++++
|
|
.../android/bookmarks/bookmark_bridge.h | 20 +-
|
|
.../android/bookmarks/bookmark_bridge.h | 20 +-
|
|
chrome/browser/importer/profile_writer.cc | 12 +
|
|
chrome/browser/importer/profile_writer.cc | 12 +
|
|
chrome/browser/importer/profile_writer.h | 6 +
|
|
chrome/browser/importer/profile_writer.h | 6 +
|
|
|
|
+ .../strings/android_chrome_strings.grd | 6 +
|
|
chrome/common/BUILD.gn | 3 +
|
|
chrome/common/BUILD.gn | 3 +
|
|
chrome/utility/BUILD.gn | 7 +-
|
|
chrome/utility/BUILD.gn | 7 +-
|
|
.../utility/importer/bookmark_html_reader.cc | 27 ++-
|
|
.../utility/importer/bookmark_html_reader.cc | 27 ++-
|
|
- .../utility/importer/bookmark_html_reader.h | 9 +
|
|
|
|
|
|
+ .../utility/importer/bookmark_html_reader.h | 8 +
|
|
.../chromium/ui/base/SelectFileDialog.java | 18 +-
|
|
.../chromium/ui/base/SelectFileDialog.java | 18 +-
|
|
ui/shell_dialogs/select_file_dialog.h | 2 +
|
|
ui/shell_dialogs/select_file_dialog.h | 2 +
|
|
.../select_file_dialog_android.cc | 6 +
|
|
.../select_file_dialog_android.cc | 6 +
|
|
ui/shell_dialogs/select_file_dialog_android.h | 2 +
|
|
ui/shell_dialogs/select_file_dialog_android.h | 2 +
|
|
- 22 files changed, 447 insertions(+), 14 deletions(-)
|
|
|
|
|
|
+ 22 files changed, 448 insertions(+), 14 deletions(-)
|
|
|
|
|
|
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
|
|
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
|
|
--- a/chrome/android/java/AndroidManifest.xml
|
|
--- a/chrome/android/java/AndroidManifest.xml
|
|
@@ -111,7 +111,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
|
|
-@@ -12,6 +12,7 @@ import org.chromium.base.VisibleForTesting;
|
|
|
|
|
|
+@@ -13,6 +13,7 @@ import androidx.annotation.VisibleForTesting;
|
|
import org.chromium.chrome.browser.SnackbarActivity;
|
|
import org.chromium.chrome.browser.SnackbarActivity;
|
|
import org.chromium.chrome.browser.util.UrlConstants;
|
|
import org.chromium.chrome.browser.util.UrlConstants;
|
|
import org.chromium.components.bookmarks.BookmarkId;
|
|
import org.chromium.components.bookmarks.BookmarkId;
|
|
@@ -119,7 +119,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
|
|
|
|
/**
|
|
/**
|
|
* The activity that displays the bookmark UI on the phone. It keeps a {@link BookmarkManager}
|
|
* The activity that displays the bookmark UI on the phone. It keeps a {@link BookmarkManager}
|
|
-@@ -21,6 +22,7 @@ import org.chromium.components.bookmarks.BookmarkId;
|
|
|
|
|
|
+@@ -22,6 +23,7 @@ import org.chromium.components.bookmarks.BookmarkId;
|
|
public class BookmarkActivity extends SnackbarActivity {
|
|
public class BookmarkActivity extends SnackbarActivity {
|
|
|
|
|
|
private BookmarkManager mBookmarkManager;
|
|
private BookmarkManager mBookmarkManager;
|
|
@@ -127,7 +127,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
static final int EDIT_BOOKMARK_REQUEST_CODE = 14;
|
|
static final int EDIT_BOOKMARK_REQUEST_CODE = 14;
|
|
public static final String INTENT_VISIT_BOOKMARK_ID = "BookmarkEditActivity.VisitBookmarkId";
|
|
public static final String INTENT_VISIT_BOOKMARK_ID = "BookmarkEditActivity.VisitBookmarkId";
|
|
|
|
|
|
-@@ -32,6 +34,18 @@ public class BookmarkActivity extends SnackbarActivity {
|
|
|
|
|
|
+@@ -33,6 +35,18 @@ public class BookmarkActivity extends SnackbarActivity {
|
|
if (TextUtils.isEmpty(url)) url = UrlConstants.BOOKMARKS_URL;
|
|
if (TextUtils.isEmpty(url)) url = UrlConstants.BOOKMARKS_URL;
|
|
mBookmarkManager.updateForUrl(url);
|
|
mBookmarkManager.updateForUrl(url);
|
|
setContentView(mBookmarkManager.getView());
|
|
setContentView(mBookmarkManager.getView());
|
|
@@ -146,7 +146,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
}
|
|
}
|
|
|
|
|
|
@Override
|
|
@Override
|
|
-@@ -48,6 +62,7 @@ public class BookmarkActivity extends SnackbarActivity {
|
|
|
|
|
|
+@@ -49,6 +63,7 @@ public class BookmarkActivity extends SnackbarActivity {
|
|
@Override
|
|
@Override
|
|
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
|
|
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
|
|
super.onActivityResult(requestCode, resultCode, data);
|
|
super.onActivityResult(requestCode, resultCode, data);
|
|
@@ -169,7 +169,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
import android.support.annotation.Nullable;
|
|
import android.support.annotation.Nullable;
|
|
import android.text.TextUtils;
|
|
import android.text.TextUtils;
|
|
import android.util.Pair;
|
|
import android.util.Pair;
|
|
-@@ -23,6 +27,11 @@ import org.chromium.components.bookmarks.BookmarkType;
|
|
|
|
|
|
+@@ -25,6 +29,11 @@ import org.chromium.components.bookmarks.BookmarkType;
|
|
import org.chromium.components.url_formatter.UrlFormatter;
|
|
import org.chromium.components.url_formatter.UrlFormatter;
|
|
import org.chromium.content_public.browser.WebContents;
|
|
import org.chromium.content_public.browser.WebContents;
|
|
|
|
|
|
@@ -181,7 +181,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
import java.util.ArrayList;
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
import java.util.List;
|
|
|
|
|
|
-@@ -553,6 +562,24 @@ public class BookmarkBridge {
|
|
|
|
|
|
+@@ -572,6 +581,24 @@ public class BookmarkBridge {
|
|
mNativeBookmarkBridge, BookmarkBridge.this, id.getId(), id.getType());
|
|
mNativeBookmarkBridge, BookmarkBridge.this, id.getId(), id.getType());
|
|
}
|
|
}
|
|
|
|
|
|
@@ -206,7 +206,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
/**
|
|
/**
|
|
* Synchronously gets a list of bookmarks that match the specified search query.
|
|
* Synchronously gets a list of bookmarks that match the specified search query.
|
|
* @param query Keyword used for searching bookmarks.
|
|
* @param query Keyword used for searching bookmarks.
|
|
-@@ -914,6 +941,24 @@ public class BookmarkBridge {
|
|
|
|
|
|
+@@ -952,6 +979,24 @@ public class BookmarkBridge {
|
|
depthList.add(depth);
|
|
depthList.add(depth);
|
|
}
|
|
}
|
|
|
|
|
|
@@ -231,7 +231,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
private static List<Pair<Integer, Integer>> createPairsList(int[] left, int[] right) {
|
|
private static List<Pair<Integer, Integer>> createPairsList(int[] left, int[] right) {
|
|
List<Pair<Integer, Integer>> pairList = new ArrayList<Pair<Integer, Integer>>();
|
|
List<Pair<Integer, Integer>> pairList = new ArrayList<Pair<Integer, Integer>>();
|
|
for (int i = 0; i < left.length; i++) {
|
|
for (int i = 0; i < left.length; i++) {
|
|
-@@ -982,6 +1027,8 @@ public class BookmarkBridge {
|
|
|
|
|
|
+@@ -1020,6 +1065,8 @@ public class BookmarkBridge {
|
|
int getChildCount(long nativeBookmarkBridge, BookmarkBridge caller, long id, int type);
|
|
int getChildCount(long nativeBookmarkBridge, BookmarkBridge caller, long id, int type);
|
|
void getChildIDs(long nativeBookmarkBridge, BookmarkBridge caller, long id, int type,
|
|
void getChildIDs(long nativeBookmarkBridge, BookmarkBridge caller, long id, int type,
|
|
boolean getFolders, boolean getBookmarks, List<BookmarkId> bookmarksList);
|
|
boolean getFolders, boolean getBookmarks, List<BookmarkId> bookmarksList);
|
|
@@ -263,7 +263,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
|
|
-@@ -23,6 +23,7 @@ import org.chromium.chrome.R;
|
|
|
|
|
|
+@@ -24,6 +24,7 @@ import org.chromium.chrome.R;
|
|
import org.chromium.chrome.browser.ChromeFeatureList;
|
|
import org.chromium.chrome.browser.ChromeFeatureList;
|
|
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
|
|
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
|
|
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkModelObserver;
|
|
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkModelObserver;
|
|
@@ -271,7 +271,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
import org.chromium.chrome.browser.favicon.LargeIconBridge;
|
|
import org.chromium.chrome.browser.favicon.LargeIconBridge;
|
|
import org.chromium.chrome.browser.gesturenav.HistoryNavigationDelegate;
|
|
import org.chromium.chrome.browser.gesturenav.HistoryNavigationDelegate;
|
|
import org.chromium.chrome.browser.native_page.BasicNativePage;
|
|
import org.chromium.chrome.browser.native_page.BasicNativePage;
|
|
-@@ -35,6 +36,7 @@ import org.chromium.chrome.browser.widget.selection.SelectableListLayout;
|
|
|
|
|
|
+@@ -36,6 +37,7 @@ import org.chromium.chrome.browser.widget.selection.SelectableListLayout;
|
|
import org.chromium.chrome.browser.widget.selection.SelectableListToolbar.SearchDelegate;
|
|
import org.chromium.chrome.browser.widget.selection.SelectableListToolbar.SearchDelegate;
|
|
import org.chromium.chrome.browser.widget.selection.SelectionDelegate;
|
|
import org.chromium.chrome.browser.widget.selection.SelectionDelegate;
|
|
import org.chromium.components.bookmarks.BookmarkId;
|
|
import org.chromium.components.bookmarks.BookmarkId;
|
|
@@ -279,7 +279,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
|
|
|
|
import java.util.Stack;
|
|
import java.util.Stack;
|
|
|
|
|
|
-@@ -59,6 +61,7 @@ public class BookmarkManager
|
|
|
|
|
|
+@@ -60,6 +62,7 @@ public class BookmarkManager
|
|
private Activity mActivity;
|
|
private Activity mActivity;
|
|
private ViewGroup mMainView;
|
|
private ViewGroup mMainView;
|
|
private BookmarkModel mBookmarkModel;
|
|
private BookmarkModel mBookmarkModel;
|
|
@@ -287,7 +287,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
private BookmarkUndoController mUndoController;
|
|
private BookmarkUndoController mUndoController;
|
|
private final ObserverList<BookmarkUIObserver> mUIObservers = new ObserverList<>();
|
|
private final ObserverList<BookmarkUIObserver> mUIObservers = new ObserverList<>();
|
|
private BasicNativePage mNativePage;
|
|
private BasicNativePage mNativePage;
|
|
-@@ -374,6 +377,13 @@ public class BookmarkManager
|
|
|
|
|
|
+@@ -375,6 +378,13 @@ public class BookmarkManager
|
|
mSelectableListLayout.setHistoryNavigationDelegate(delegate);
|
|
mSelectableListLayout.setHistoryNavigationDelegate(delegate);
|
|
}
|
|
}
|
|
|
|
|
|
@@ -301,7 +301,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
/**
|
|
/**
|
|
* @return Current URL representing the UI state of bookmark manager. If no state has been shown
|
|
* @return Current URL representing the UI state of bookmark manager. If no state has been shown
|
|
* yet in this session, on phone return last used state stored in preference; on tablet
|
|
* yet in this session, on phone return last used state stored in preference; on tablet
|
|
-@@ -547,6 +557,16 @@ public class BookmarkManager
|
|
|
|
|
|
+@@ -548,6 +558,16 @@ public class BookmarkManager
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
@@ -321,7 +321,7 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
|
|
-@@ -35,6 +35,7 @@ public class BookmarkPage extends BasicNativePage {
|
|
|
|
|
|
+@@ -36,6 +36,7 @@ public class BookmarkPage extends BasicNativePage {
|
|
mManager = new BookmarkManager(
|
|
mManager = new BookmarkManager(
|
|
activity, false, ((SnackbarManageable) activity).getSnackbarManager());
|
|
activity, false, ((SnackbarManageable) activity).getSnackbarManager());
|
|
mManager.setBasicNativePage(this);
|
|
mManager.setBasicNativePage(this);
|
|
@@ -329,26 +329,10 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/Bookm
|
|
mManager.setHistoryNavigationDelegate(host.createHistoryNavigationDelegate());
|
|
mManager.setHistoryNavigationDelegate(host.createHistoryNavigationDelegate());
|
|
mTitle = activity.getString(R.string.bookmarks);
|
|
mTitle = activity.getString(R.string.bookmarks);
|
|
}
|
|
}
|
|
-diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
|
---- a/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
|
-+++ b/chrome/android/java/strings/android_chrome_strings.grd
|
|
|
|
-@@ -230,6 +230,12 @@ CHAR-LIMIT guidelines:
|
|
|
|
- <message name="IDS_SEARCH" desc="The label for a search button.">
|
|
|
|
- Search
|
|
|
|
- </message>
|
|
|
|
-+ <message name="IDS_IMPORT_BOOKMARKS" desc="The label for the import bookmarks button.">
|
|
|
|
-+ Import
|
|
|
|
-+ </message>
|
|
|
|
-+ <message name="IDS_EXPORT_BOOKMARKS" desc="The label for an export bookmarks button.">
|
|
|
|
-+ Export
|
|
|
|
-+ </message>
|
|
|
|
- <message name="IDS_SHOW_INFO" desc="The label for a info button to show info.">
|
|
|
|
- Show Info
|
|
|
|
- </message>
|
|
|
|
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
--- a/chrome/browser/BUILD.gn
|
|
--- a/chrome/browser/BUILD.gn
|
|
+++ b/chrome/browser/BUILD.gn
|
|
+++ b/chrome/browser/BUILD.gn
|
|
-@@ -163,6 +163,10 @@ jumbo_static_library("browser") {
|
|
|
|
|
|
+@@ -170,6 +170,10 @@ jumbo_static_library("browser") {
|
|
"bitmap_fetcher/bitmap_fetcher_service.h",
|
|
"bitmap_fetcher/bitmap_fetcher_service.h",
|
|
"bitmap_fetcher/bitmap_fetcher_service_factory.cc",
|
|
"bitmap_fetcher/bitmap_fetcher_service_factory.cc",
|
|
"bitmap_fetcher/bitmap_fetcher_service_factory.h",
|
|
"bitmap_fetcher/bitmap_fetcher_service_factory.h",
|
|
@@ -359,16 +343,16 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
"bookmarks/bookmark_model_factory.cc",
|
|
"bookmarks/bookmark_model_factory.cc",
|
|
"bookmarks/bookmark_model_factory.h",
|
|
"bookmarks/bookmark_model_factory.h",
|
|
"bookmarks/chrome_bookmark_client.cc",
|
|
"bookmarks/chrome_bookmark_client.cc",
|
|
-@@ -2953,8 +2957,6 @@ jumbo_static_library("browser") {
|
|
|
|
- "badging/badge_manager_factory.h",
|
|
|
|
- "banners/app_banner_manager_desktop.cc",
|
|
|
|
- "banners/app_banner_manager_desktop.h",
|
|
|
|
|
|
+@@ -3063,8 +3067,6 @@ jumbo_static_library("browser") {
|
|
|
|
+ "bluetooth/bluetooth_chooser_context.h",
|
|
|
|
+ "bluetooth/bluetooth_chooser_context_factory.cc",
|
|
|
|
+ "bluetooth/bluetooth_chooser_context_factory.h",
|
|
- "bookmarks/bookmark_html_writer.cc",
|
|
- "bookmarks/bookmark_html_writer.cc",
|
|
- "bookmarks/bookmark_html_writer.h",
|
|
- "bookmarks/bookmark_html_writer.h",
|
|
"certificate_viewer.h",
|
|
"certificate_viewer.h",
|
|
"chrome_browser_field_trials_desktop.cc",
|
|
"chrome_browser_field_trials_desktop.cc",
|
|
"chrome_browser_field_trials_desktop.h",
|
|
"chrome_browser_field_trials_desktop.h",
|
|
-@@ -3059,8 +3061,6 @@ jumbo_static_library("browser") {
|
|
|
|
|
|
+@@ -3174,8 +3176,6 @@ jumbo_static_library("browser") {
|
|
"importer/importer_uma.h",
|
|
"importer/importer_uma.h",
|
|
"importer/in_process_importer_bridge.cc",
|
|
"importer/in_process_importer_bridge.cc",
|
|
"importer/in_process_importer_bridge.h",
|
|
"importer/in_process_importer_bridge.h",
|
|
@@ -380,7 +364,15 @@ diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
|
|
diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browser/android/bookmarks/bookmark_bridge.cc
|
|
diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browser/android/bookmarks/bookmark_bridge.cc
|
|
--- a/chrome/browser/android/bookmarks/bookmark_bridge.cc
|
|
--- a/chrome/browser/android/bookmarks/bookmark_bridge.cc
|
|
+++ b/chrome/browser/android/bookmarks/bookmark_bridge.cc
|
|
+++ b/chrome/browser/android/bookmarks/bookmark_bridge.cc
|
|
-@@ -43,6 +43,21 @@
|
|
|
|
|
|
+@@ -34,6 +34,7 @@
|
|
|
|
+ #include "components/bookmarks/common/android/bookmark_type.h"
|
|
|
|
+ #include "components/bookmarks/common/bookmark_pref_names.h"
|
|
|
|
+ #include "components/bookmarks/managed/managed_bookmark_service.h"
|
|
|
|
++#include "components/favicon_base/favicon_usage_data.h"
|
|
|
|
+ #include "components/dom_distiller/core/url_utils.h"
|
|
|
|
+ #include "components/prefs/pref_service.h"
|
|
|
|
+ #include "components/query_parser/query_parser.h"
|
|
|
|
+@@ -43,6 +44,21 @@
|
|
#include "content/public/browser/browser_thread.h"
|
|
#include "content/public/browser/browser_thread.h"
|
|
#include "content/public/browser/web_contents.h"
|
|
#include "content/public/browser/web_contents.h"
|
|
|
|
|
|
@@ -402,7 +394,7 @@ diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browse
|
|
using base::android::AttachCurrentThread;
|
|
using base::android::AttachCurrentThread;
|
|
using base::android::ConvertUTF8ToJavaString;
|
|
using base::android::ConvertUTF8ToJavaString;
|
|
using base::android::ConvertUTF16ToJavaString;
|
|
using base::android::ConvertUTF16ToJavaString;
|
|
-@@ -60,6 +75,56 @@ using bookmarks::BookmarkPermanentNode;
|
|
|
|
|
|
+@@ -60,6 +76,56 @@ using bookmarks::BookmarkPermanentNode;
|
|
using bookmarks::BookmarkType;
|
|
using bookmarks::BookmarkType;
|
|
using content::BrowserThread;
|
|
using content::BrowserThread;
|
|
|
|
|
|
@@ -459,7 +451,7 @@ diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browse
|
|
namespace {
|
|
namespace {
|
|
|
|
|
|
const int kInvalidId = -1;
|
|
const int kInvalidId = -1;
|
|
-@@ -138,6 +203,10 @@ BookmarkBridge::~BookmarkBridge() {
|
|
|
|
|
|
+@@ -138,6 +204,10 @@ BookmarkBridge::~BookmarkBridge() {
|
|
bookmark_model_->RemoveObserver(this);
|
|
bookmark_model_->RemoveObserver(this);
|
|
if (partner_bookmarks_shim_)
|
|
if (partner_bookmarks_shim_)
|
|
partner_bookmarks_shim_->RemoveObserver(this);
|
|
partner_bookmarks_shim_->RemoveObserver(this);
|
|
@@ -470,7 +462,7 @@ diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browse
|
|
}
|
|
}
|
|
|
|
|
|
void BookmarkBridge::Destroy(JNIEnv*, const JavaParamRef<jobject>&) {
|
|
void BookmarkBridge::Destroy(JNIEnv*, const JavaParamRef<jobject>&) {
|
|
-@@ -524,6 +593,152 @@ jint BookmarkBridge::GetTotalBookmarkCount(
|
|
|
|
|
|
+@@ -542,6 +612,153 @@ jint BookmarkBridge::GetTotalBookmarkCount(
|
|
return count;
|
|
return count;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -585,14 +577,15 @@ diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browse
|
|
+ // the following import logic comes from BookmarksFileImporter class
|
|
+ // the following import logic comes from BookmarksFileImporter class
|
|
+ std::vector<ImportedBookmarkEntry> bookmarks;
|
|
+ std::vector<ImportedBookmarkEntry> bookmarks;
|
|
+ std::vector<importer::SearchEngineInfo> search_engines;
|
|
+ std::vector<importer::SearchEngineInfo> search_engines;
|
|
|
|
++ favicon_base::FaviconUsageDataList favicons;
|
|
+
|
|
+
|
|
+ bookmark_html_reader::ImportBookmarksFile(
|
|
+ bookmark_html_reader::ImportBookmarksFile(
|
|
+ base::Callback<bool(void)>(),
|
|
+ base::Callback<bool(void)>(),
|
|
-+ base::Bind(internal::CanImportURL),
|
|
|
|
|
|
++ base::BindRepeating(internal::CanImportURL),
|
|
+ contents,
|
|
+ contents,
|
|
+ &bookmarks,
|
|
+ &bookmarks,
|
|
+ &search_engines,
|
|
+ &search_engines,
|
|
-+ nullptr);
|
|
|
|
|
|
++ &favicons);
|
|
+
|
|
+
|
|
+ auto *writer = new ProfileWriter(profile_);
|
|
+ auto *writer = new ProfileWriter(profile_);
|
|
+
|
|
+
|
|
@@ -745,10 +738,26 @@ diff --git a/chrome/browser/importer/profile_writer.h b/chrome/browser/importer/
|
|
virtual void AddFavicons(const favicon_base::FaviconUsageDataList& favicons);
|
|
virtual void AddFavicons(const favicon_base::FaviconUsageDataList& favicons);
|
|
|
|
|
|
// Adds the TemplateURLs in |template_urls| to the local store.
|
|
// Adds the TemplateURLs in |template_urls| to the local store.
|
|
|
|
+diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
|
|
+--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
|
|
++++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
|
|
+@@ -257,6 +257,12 @@ CHAR-LIMIT guidelines:
|
|
|
|
+ <message name="IDS_SEARCH" desc="The label for a search button.">
|
|
|
|
+ Search
|
|
|
|
+ </message>
|
|
|
|
++ <message name="IDS_IMPORT_BOOKMARKS" desc="The label for the import bookmarks button.">
|
|
|
|
++ Import
|
|
|
|
++ </message>
|
|
|
|
++ <message name="IDS_EXPORT_BOOKMARKS" desc="The label for an export bookmarks button.">
|
|
|
|
++ Export
|
|
|
|
++ </message>
|
|
|
|
+ <message name="IDS_SHOW_INFO" desc="The label for a info button to show info.">
|
|
|
|
+ Show Info
|
|
|
|
+ </message>
|
|
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
|
|
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
|
|
--- a/chrome/common/BUILD.gn
|
|
--- a/chrome/common/BUILD.gn
|
|
+++ b/chrome/common/BUILD.gn
|
|
+++ b/chrome/common/BUILD.gn
|
|
-@@ -445,6 +445,9 @@ static_library("common") {
|
|
|
|
|
|
+@@ -426,6 +426,9 @@ static_library("common") {
|
|
sources += [
|
|
sources += [
|
|
"media/chrome_media_drm_bridge_client.cc",
|
|
"media/chrome_media_drm_bridge_client.cc",
|
|
"media/chrome_media_drm_bridge_client.h",
|
|
"media/chrome_media_drm_bridge_client.h",
|
|
@@ -761,7 +770,7 @@ diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
|
|
diff --git a/chrome/utility/BUILD.gn b/chrome/utility/BUILD.gn
|
|
diff --git a/chrome/utility/BUILD.gn b/chrome/utility/BUILD.gn
|
|
--- a/chrome/utility/BUILD.gn
|
|
--- a/chrome/utility/BUILD.gn
|
|
+++ b/chrome/utility/BUILD.gn
|
|
+++ b/chrome/utility/BUILD.gn
|
|
-@@ -66,8 +66,6 @@ static_library("utility") {
|
|
|
|
|
|
+@@ -70,8 +70,6 @@ static_library("utility") {
|
|
|
|
|
|
if (!is_android) {
|
|
if (!is_android) {
|
|
sources += [
|
|
sources += [
|
|
@@ -770,7 +779,7 @@ diff --git a/chrome/utility/BUILD.gn b/chrome/utility/BUILD.gn
|
|
"importer/bookmarks_file_importer.cc",
|
|
"importer/bookmarks_file_importer.cc",
|
|
"importer/bookmarks_file_importer.h",
|
|
"importer/bookmarks_file_importer.h",
|
|
"importer/edge_database_reader_win.cc",
|
|
"importer/edge_database_reader_win.cc",
|
|
-@@ -164,6 +162,11 @@ static_library("utility") {
|
|
|
|
|
|
+@@ -167,6 +165,11 @@ static_library("utility") {
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
@@ -811,21 +820,39 @@ diff --git a/chrome/utility/importer/bookmark_html_reader.cc b/chrome/utility/im
|
|
|
|
|
|
} // namespace
|
|
} // namespace
|
|
|
|
|
|
-@@ -108,12 +112,10 @@ static std::string stripDt(const std::string& lineDt) {
|
|
|
|
|
|
+@@ -106,14 +110,28 @@ static std::string stripDt(const std::string& lineDt) {
|
|
|
|
+ }
|
|
|
|
+
|
|
void ImportBookmarksFile(
|
|
void ImportBookmarksFile(
|
|
- const base::Callback<bool(void)>& cancellation_callback,
|
|
|
|
- const base::Callback<bool(const GURL&)>& valid_url_callback,
|
|
|
|
-- const base::FilePath& file_path,
|
|
|
|
-+ const std::string& content,
|
|
|
|
|
|
+- base::RepeatingCallback<bool(void)> cancellation_callback,
|
|
|
|
+- base::RepeatingCallback<bool(const GURL&)> valid_url_callback,
|
|
|
|
++ const base::RepeatingCallback<bool(void)> cancellation_callback,
|
|
|
|
++ const base::RepeatingCallback<bool(const GURL&)> valid_url_callback,
|
|
|
|
+ const base::FilePath& file_path,
|
|
std::vector<ImportedBookmarkEntry>* bookmarks,
|
|
std::vector<ImportedBookmarkEntry>* bookmarks,
|
|
std::vector<importer::SearchEngineInfo>* search_engines,
|
|
std::vector<importer::SearchEngineInfo>* search_engines,
|
|
favicon_base::FaviconUsageDataList* favicons) {
|
|
favicon_base::FaviconUsageDataList* favicons) {
|
|
-- std::string content;
|
|
|
|
|
|
+ std::string content;
|
|
- base::ReadFileToString(file_path, &content);
|
|
- base::ReadFileToString(file_path, &content);
|
|
|
|
++ if (!base::ReadFileToString(file_path, &content)) {
|
|
|
|
++ LOG(ERROR) << "Could not directly read bookmarks import file";
|
|
|
|
++ return;
|
|
|
|
++ }
|
|
|
|
++
|
|
|
|
++ ImportBookmarksFile(cancellation_callback, valid_url_callback, content, bookmarks, search_engines, favicons);
|
|
|
|
++}
|
|
|
|
++
|
|
|
|
++void ImportBookmarksFile(
|
|
|
|
++ base::RepeatingCallback<bool(void)> cancellation_callback,
|
|
|
|
++ base::RepeatingCallback<bool(const GURL&)> valid_url_callback,
|
|
|
|
++ const std::string& content,
|
|
|
|
++ std::vector<ImportedBookmarkEntry>* bookmarks,
|
|
|
|
++ std::vector<importer::SearchEngineInfo>* search_engines,
|
|
|
|
++ favicon_base::FaviconUsageDataList* favicons) {
|
|
std::vector<std::string> lines = base::SplitString(
|
|
std::vector<std::string> lines = base::SplitString(
|
|
content, "\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
|
|
content, "\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
|
|
|
|
|
|
-@@ -126,6 +128,7 @@ void ImportBookmarksFile(
|
|
|
|
|
|
+@@ -126,6 +144,7 @@ void ImportBookmarksFile(
|
|
std::vector<base::string16> path;
|
|
std::vector<base::string16> path;
|
|
size_t toolbar_folder_index = 0;
|
|
size_t toolbar_folder_index = 0;
|
|
std::string charset = "UTF-8"; // If no charset is specified, assume utf-8.
|
|
std::string charset = "UTF-8"; // If no charset is specified, assume utf-8.
|
|
@@ -833,7 +860,7 @@ diff --git a/chrome/utility/importer/bookmark_html_reader.cc b/chrome/utility/im
|
|
for (size_t i = 0;
|
|
for (size_t i = 0;
|
|
i < lines.size() &&
|
|
i < lines.size() &&
|
|
(cancellation_callback.is_null() || !cancellation_callback.Run());
|
|
(cancellation_callback.is_null() || !cancellation_callback.Run());
|
|
-@@ -218,10 +221,12 @@ void ImportBookmarksFile(
|
|
|
|
|
|
+@@ -218,10 +237,12 @@ void ImportBookmarksFile(
|
|
}
|
|
}
|
|
bookmarks->push_back(entry);
|
|
bookmarks->push_back(entry);
|
|
|
|
|
|
@@ -846,44 +873,20 @@ diff --git a/chrome/utility/importer/bookmark_html_reader.cc b/chrome/utility/im
|
|
|
|
|
|
continue;
|
|
continue;
|
|
}
|
|
}
|
|
-@@ -278,6 +283,22 @@ void ImportBookmarksFile(
|
|
|
|
- }
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
-+void ImportBookmarksFile(
|
|
|
|
-+ const base::Callback<bool(void)>& cancellation_callback,
|
|
|
|
-+ const base::Callback<bool(const GURL&)>& valid_url_callback,
|
|
|
|
-+ const base::FilePath& file_path,
|
|
|
|
-+ std::vector<ImportedBookmarkEntry>* bookmarks,
|
|
|
|
-+ std::vector<importer::SearchEngineInfo>* search_engines,
|
|
|
|
-+ favicon_base::FaviconUsageDataList* favicons) {
|
|
|
|
-+ std::string content;
|
|
|
|
-+ if (!base::ReadFileToString(file_path, &content)) {
|
|
|
|
-+ LOG(ERROR) << "Could not directly read bookmarks import file";
|
|
|
|
-+ return;
|
|
|
|
-+ }
|
|
|
|
-+
|
|
|
|
-+ ImportBookmarksFile(cancellation_callback, valid_url_callback, content, bookmarks, search_engines, favicons);
|
|
|
|
-+}
|
|
|
|
-+
|
|
|
|
- bool CanImportURLAsSearchEngine(const GURL& url,
|
|
|
|
- std::string* search_engine_url) {
|
|
|
|
- std::string url_spec = url.possibly_invalid_spec();
|
|
|
|
diff --git a/chrome/utility/importer/bookmark_html_reader.h b/chrome/utility/importer/bookmark_html_reader.h
|
|
diff --git a/chrome/utility/importer/bookmark_html_reader.h b/chrome/utility/importer/bookmark_html_reader.h
|
|
--- a/chrome/utility/importer/bookmark_html_reader.h
|
|
--- a/chrome/utility/importer/bookmark_html_reader.h
|
|
+++ b/chrome/utility/importer/bookmark_html_reader.h
|
|
+++ b/chrome/utility/importer/bookmark_html_reader.h
|
|
-@@ -51,6 +51,15 @@ void ImportBookmarksFile(
|
|
|
|
|
|
+@@ -51,6 +51,14 @@ void ImportBookmarksFile(
|
|
std::vector<importer::SearchEngineInfo>* search_engines,
|
|
std::vector<importer::SearchEngineInfo>* search_engines,
|
|
favicon_base::FaviconUsageDataList* favicons);
|
|
favicon_base::FaviconUsageDataList* favicons);
|
|
|
|
|
|
+void ImportBookmarksFile(
|
|
+void ImportBookmarksFile(
|
|
-+ const base::Callback<bool(void)>& cancellation_callback,
|
|
|
|
-+ const base::Callback<bool(const GURL&)>& valid_url_callback,
|
|
|
|
|
|
++ const base::RepeatingCallback<bool(void)> cancellation_callback,
|
|
|
|
++ const base::RepeatingCallback<bool(const GURL&)> valid_url_callback,
|
|
+ const std::string& content,
|
|
+ const std::string& content,
|
|
+ std::vector<ImportedBookmarkEntry>* bookmarks,
|
|
+ std::vector<ImportedBookmarkEntry>* bookmarks,
|
|
+ std::vector<importer::SearchEngineInfo>* search_engines,
|
|
+ std::vector<importer::SearchEngineInfo>* search_engines,
|
|
+ favicon_base::FaviconUsageDataList* favicons);
|
|
+ favicon_base::FaviconUsageDataList* favicons);
|
|
-+
|
|
|
|
+
|
|
+
|
|
// Returns true if |url| should be imported as a search engine, i.e. because it
|
|
// Returns true if |url| should be imported as a search engine, i.e. because it
|
|
// has replacement terms. Chrome treats such bookmarks as search engines rather
|
|
// has replacement terms. Chrome treats such bookmarks as search engines rather
|
|
@@ -891,7 +894,7 @@ diff --git a/chrome/utility/importer/bookmark_html_reader.h b/chrome/utility/imp
|
|
diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
|
diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
|
--- a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
|
--- a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
|
+++ b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
|
+++ b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
|
|
-@@ -34,6 +34,7 @@ import org.chromium.base.task.PostTask;
|
|
|
|
|
|
+@@ -35,6 +35,7 @@ import org.chromium.base.task.PostTask;
|
|
import org.chromium.base.task.TaskTraits;
|
|
import org.chromium.base.task.TaskTraits;
|
|
import org.chromium.ui.PhotoPickerListener;
|
|
import org.chromium.ui.PhotoPickerListener;
|
|
import org.chromium.ui.R;
|
|
import org.chromium.ui.R;
|
|
@@ -899,7 +902,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
import org.chromium.ui.UiUtils;
|
|
import org.chromium.ui.UiUtils;
|
|
|
|
|
|
import java.io.File;
|
|
import java.io.File;
|
|
-@@ -53,6 +54,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
|
|
|
|
+@@ -54,6 +55,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
private static final String IMAGE_TYPE = "image/";
|
|
private static final String IMAGE_TYPE = "image/";
|
|
private static final String VIDEO_TYPE = "video/";
|
|
private static final String VIDEO_TYPE = "video/";
|
|
private static final String AUDIO_TYPE = "audio/";
|
|
private static final String AUDIO_TYPE = "audio/";
|
|
@@ -907,7 +910,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
private static final String ALL_IMAGE_TYPES = IMAGE_TYPE + "*";
|
|
private static final String ALL_IMAGE_TYPES = IMAGE_TYPE + "*";
|
|
private static final String ALL_VIDEO_TYPES = VIDEO_TYPE + "*";
|
|
private static final String ALL_VIDEO_TYPES = VIDEO_TYPE + "*";
|
|
private static final String ALL_AUDIO_TYPES = AUDIO_TYPE + "*";
|
|
private static final String ALL_AUDIO_TYPES = AUDIO_TYPE + "*";
|
|
-@@ -131,6 +133,11 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
|
|
|
|
+@@ -132,6 +134,11 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
mFileTypes = fileTypes;
|
|
mFileTypes = fileTypes;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -919,7 +922,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
/**
|
|
/**
|
|
* Creates and starts an intent based on the passed fileTypes and capture value.
|
|
* Creates and starts an intent based on the passed fileTypes and capture value.
|
|
* @param fileTypes MIME types requested (i.e. "image/*")
|
|
* @param fileTypes MIME types requested (i.e. "image/*")
|
|
-@@ -158,7 +165,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
|
|
|
|
+@@ -159,7 +166,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
List<String> missingPermissions = new ArrayList<>();
|
|
List<String> missingPermissions = new ArrayList<>();
|
|
String storagePermission = Manifest.permission.READ_EXTERNAL_STORAGE;
|
|
String storagePermission = Manifest.permission.READ_EXTERNAL_STORAGE;
|
|
boolean shouldUsePhotoPicker = shouldUsePhotoPicker();
|
|
boolean shouldUsePhotoPicker = shouldUsePhotoPicker();
|
|
@@ -928,7 +931,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
if (!window.hasPermission(storagePermission)) missingPermissions.add(storagePermission);
|
|
if (!window.hasPermission(storagePermission)) missingPermissions.add(storagePermission);
|
|
} else {
|
|
} else {
|
|
if (((mSupportsImageCapture && shouldShowImageTypes())
|
|
if (((mSupportsImageCapture && shouldShowImageTypes())
|
|
-@@ -186,7 +193,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
|
|
|
|
+@@ -187,7 +194,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
}
|
|
}
|
|
|
|
|
|
// TODO(finnur): Remove once we figure out the cause of crbug.com/950024.
|
|
// TODO(finnur): Remove once we figure out the cause of crbug.com/950024.
|
|
@@ -937,7 +940,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
if (permissions.length != requestPermissions.length) {
|
|
if (permissions.length != requestPermissions.length) {
|
|
throw new RuntimeException(
|
|
throw new RuntimeException(
|
|
String.format("Permissions arrays misaligned: %d != %d",
|
|
String.format("Permissions arrays misaligned: %d != %d",
|
|
-@@ -200,7 +207,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
|
|
|
|
+@@ -201,7 +208,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
@@ -946,7 +949,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
onFileNotSelected();
|
|
onFileNotSelected();
|
|
return;
|
|
return;
|
|
}
|
|
}
|
|
-@@ -349,6 +356,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
|
|
|
|
+@@ -350,6 +357,7 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
}
|
|
}
|
|
if (!mimeTypes.contains(mimeType)) mimeTypes.add(mimeType);
|
|
if (!mimeTypes.contains(mimeType)) mimeTypes.add(mimeType);
|
|
}
|
|
}
|
|
@@ -954,7 +957,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
return mimeTypes;
|
|
return mimeTypes;
|
|
}
|
|
}
|
|
|
|
|
|
-@@ -626,6 +634,10 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
|
|
|
|
+@@ -627,6 +635,10 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback, PhotoPick
|
|
return countAcceptTypesFor(specificType) > 0;
|
|
return countAcceptTypesFor(specificType) > 0;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -968,7 +971,7 @@ diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui
|
|
diff --git a/ui/shell_dialogs/select_file_dialog.h b/ui/shell_dialogs/select_file_dialog.h
|
|
diff --git a/ui/shell_dialogs/select_file_dialog.h b/ui/shell_dialogs/select_file_dialog.h
|
|
--- a/ui/shell_dialogs/select_file_dialog.h
|
|
--- a/ui/shell_dialogs/select_file_dialog.h
|
|
+++ b/ui/shell_dialogs/select_file_dialog.h
|
|
+++ b/ui/shell_dialogs/select_file_dialog.h
|
|
-@@ -192,6 +192,8 @@ class SHELL_DIALOGS_EXPORT SelectFileDialog
|
|
|
|
|
|
+@@ -191,6 +191,8 @@ class SHELL_DIALOGS_EXPORT SelectFileDialog
|
|
void* params);
|
|
void* params);
|
|
bool HasMultipleFileTypeChoices();
|
|
bool HasMultipleFileTypeChoices();
|
|
|
|
|