From cc2e0a61987306b0710cfdf01a8f44f2111a4edd Mon Sep 17 00:00:00 2001
From: crschnick <crschnick@xpipe.io>
Date: Tue, 27 Feb 2024 06:05:32 +0000
Subject: [PATCH] More secret fixes

---
 .../main/java/io/xpipe/app/util/SecretQueryProgress.java    | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/app/src/main/java/io/xpipe/app/util/SecretQueryProgress.java b/app/src/main/java/io/xpipe/app/util/SecretQueryProgress.java
index d7d140d0e..28041e3fc 100644
--- a/app/src/main/java/io/xpipe/app/util/SecretQueryProgress.java
+++ b/app/src/main/java/io/xpipe/app/util/SecretQueryProgress.java
@@ -55,8 +55,6 @@ public class SecretQueryProgress {
         }
 
         var firstSeenIndex = seenPrompts.indexOf(prompt);
-        var ref = new SecretReference(storeId, firstSeenIndex);
-
         if (firstSeenIndex >= suppliers.size()) {
             countDown.pause();
             var r = fallback.query(prompt);
@@ -65,12 +63,10 @@ public class SecretQueryProgress {
                 requestCancelled = true;
                 return null;
             }
-            if (shouldCache(fallback, prompt)) {
-                SecretManager.set(ref, r.getSecret());
-            }
             return r.getSecret();
         }
 
+        var ref = new SecretReference(storeId, firstSeenIndex);
         var sup = suppliers.get(firstSeenIndex);
         var shouldCache = shouldCache(sup, prompt);
         var wasLastPrompt = firstSeenIndex == seenPrompts.size() - 1;