Powershell fixes

app/src/main/java/io/xpipe/app/comp/store/StoreCreationComp.java

@@ -197,7 +197,7 @@ public class StoreCreationComp extends DialogComp {
                     try {
                         DataStorage.get().addStoreEntryIfNotPresent(e);
                         if (validated
-                                && e.getProvider().shouldHaveChildren()
+                                && e.getProvider().shouldShowScan()
                                 && AppPrefs.get()
                                         .openConnectionSearchWindowOnConnectionCreation()
                                         .get()) {

app/src/main/java/io/xpipe/app/ext/DataStoreProvider.java

@@ -96,14 +96,10 @@ public interface DataStoreProvider {
         return new StoreSectionComp(section, topLevel);
     }
 
-    default boolean canHaveSubShells() {
+    default boolean shouldShowScan() {
         return true;
     }
 
-    default boolean shouldHaveChildren() {
-        return canHaveSubShells();
-    }
-
     default Comp<?> stateDisplay(StoreEntryWrapper w) {
         return Comp.empty();
     }

app/src/main/java/io/xpipe/app/util/ScanAlert.java

@@ -49,6 +49,10 @@ public class ScanAlert {
 
     public static void showForShellStore(DataStoreEntry initial) {
         show(initial, (DataStoreEntry entry, ShellControl sc) -> {
+            if (!sc.canHaveSubshells()) {
+                return null;
+            }
+
             if (!sc.getShellDialect().getDumbMode().supportsAnyPossibleInteraction()) {
                 return null;
             }

core/src/main/java/io/xpipe/core/process/ShellControl.java

@@ -46,6 +46,10 @@ public interface ShellControl extends ProcessControl {
 
     boolean isLocal();
 
+    default boolean canHaveSubshells() {
+        return true;
+    }
+
     ShellControl getMachineRootSession();
 
     ShellControl withoutLicenseCheck();

core/src/main/java/io/xpipe/core/process/ShellDialect.java

@@ -146,7 +146,11 @@ public interface ShellDialect {
 
     String getPrintWorkingDirectoryCommand();
 
-    StreamCharset getScriptCharset();
+    StreamCharset getTextCharset();
+
+    default StreamCharset getScriptCharset() {
+        return getTextCharset();
+    }
 
     CommandControl getFileCopyCommand(ShellControl parent, String oldFile, String newFile);
 

core/src/main/java/io/xpipe/core/util/StreamCharset.java

@@ -2,6 +2,7 @@ package io.xpipe.core.util;
 
 import lombok.Value;
 
+import java.io.ByteArrayInputStream;
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.nio.charset.Charset;
@@ -158,6 +159,20 @@ public class StreamCharset {
         return detected.reader(inputStream);
     }
 
+    public String read(byte[] b) throws Exception {
+        return read(new ByteArrayInputStream(b));
+    }
+
+    public String read(InputStream inputStream) throws Exception {
+        if (hasByteOrderMark()) {
+            var bom = inputStream.readNBytes(getByteOrderMark().length);
+            if (bom.length != 0 && !Arrays.equals(bom, getByteOrderMark())) {
+                throw new IllegalStateException("Charset does not match: " + charset.toString());
+            }
+        }
+        return new String(inputStream.readAllBytes(), charset);
+    }
+
     public InputStreamReader reader(InputStream stream) throws Exception {
         if (hasByteOrderMark()) {
             var bom = stream.readNBytes(getByteOrderMark().length);

ext/base/src/main/java/io/xpipe/ext/base/action/ScanStoreAction.java

@@ -31,15 +31,11 @@ public class ScanStoreAction implements ActionProvider {
 
             @Override
             public boolean isMajor(DataStoreEntryRef<ShellStore> o) {
-                return o.get().getProvider().shouldHaveChildren();
+                return true;
             }
 
             @Override
             public boolean isApplicable(DataStoreEntryRef<ShellStore> o) {
-                if (!o.get().getProvider().canHaveSubShells()) {
-                    return false;
-                }
-
                 var state = o.get().getStorePersistentState();
                 if (state instanceof ShellStoreState shellStoreState) {
                     return (shellStoreState.getShellDialect() == null

ext/base/src/main/java/io/xpipe/ext/base/script/SimpleScriptStoreProvider.java

@@ -46,7 +46,7 @@ public class SimpleScriptStoreProvider implements EnabledParentStoreProvider, Da
     }
 
     @Override
-    public boolean shouldHaveChildren() {
+    public boolean shouldShowScan() {
         return false;
     }