From aae09c255f532e4d19b7697ae058971e4ff8121f Mon Sep 17 00:00:00 2001 From: crschnick Date: Thu, 17 Oct 2024 15:32:57 +0000 Subject: [PATCH] [release] --- .../app/terminal/WindowsTerminalType.java | 10 ++++- .../io/xpipe/core/process/ShellDialects.java | 6 ++- dist/changelogs/12.3.3.md | 43 +++++++++++++++++++ dist/changelogs/12.3.3_incremental.md | 1 + version | 2 +- 5 files changed, 59 insertions(+), 3 deletions(-) create mode 100644 dist/changelogs/12.3.3.md create mode 100644 dist/changelogs/12.3.3_incremental.md diff --git a/app/src/main/java/io/xpipe/app/terminal/WindowsTerminalType.java b/app/src/main/java/io/xpipe/app/terminal/WindowsTerminalType.java index 5557c6dea..83dd4493a 100644 --- a/app/src/main/java/io/xpipe/app/terminal/WindowsTerminalType.java +++ b/app/src/main/java/io/xpipe/app/terminal/WindowsTerminalType.java @@ -3,6 +3,7 @@ package io.xpipe.app.terminal; import io.xpipe.app.issue.ErrorEvent; import io.xpipe.app.util.LocalShell; import io.xpipe.core.process.CommandBuilder; +import io.xpipe.core.process.ShellDialects; import io.xpipe.core.store.FileNames; import java.nio.file.Files; @@ -24,7 +25,14 @@ public interface WindowsTerminalType extends ExternalTerminalType { if (configuration.getColor() != null) { cmd.add("--tabColor").addQuoted(configuration.getColor().toHexString()); } - return cmd.add("--title").addQuoted(fixedName).add(configuration.getDialectLaunchCommand()); + // This is a fix for rare wt startup issues when using the full cmd launch command instead of just passing the .bat script + // This must be a bug on wt's side, so work around it by just passing the script file + var toExec = !ShellDialects.isPowershell(configuration.getScriptDialect()) + ? CommandBuilder.of().addFile(configuration.getScriptFile()) + : CommandBuilder.of() + .add("powershell", "-ExecutionPolicy", "Bypass", "-File") + .addFile(configuration.getScriptFile()); + return cmd.add("--title").addQuoted(fixedName).add(toExec); } @Override diff --git a/core/src/main/java/io/xpipe/core/process/ShellDialects.java b/core/src/main/java/io/xpipe/core/process/ShellDialects.java index 8c82f8de4..b16824db7 100644 --- a/core/src/main/java/io/xpipe/core/process/ShellDialects.java +++ b/core/src/main/java/io/xpipe/core/process/ShellDialects.java @@ -48,7 +48,11 @@ public class ShellDialects { return false; } - return sc.getShellDialect().equals(POWERSHELL) || sc.getShellDialect().equals(POWERSHELL_CORE); + return isPowershell(sc.getShellDialect()); + } + + public static boolean isPowershell(ShellDialect d) { + return d == POWERSHELL || d == POWERSHELL_CORE; } public static Optional byNameIfPresent(String name) { diff --git a/dist/changelogs/12.3.3.md b/dist/changelogs/12.3.3.md new file mode 100644 index 000000000..a4b4ecfa2 --- /dev/null +++ b/dist/changelogs/12.3.3.md @@ -0,0 +1,43 @@ +## Changes + +- Add popup to automatically save file with sudo when permissions are denied in file browser +- You can now restart any ended terminal session by pressing R in the terminal +- Add support for the windows credential manager as a password manager +- Reuse existing shell session when adding new connection and searching for available connections +- Implement support for setting custom icons, thanks to [https://github.com/selfhst/icons](https://github.com/selfhst/icons) +- Replace deprecated wmic tool interaction on Windows +- Add button to log in as a different user for RDP tunnel connections +- Properly terminate all running connections when shutting down +- Improve color scheme contrast for light themes +- Improve connection hub styling +- Rework Windows OS name detection +- Improve script summary display +- Upgrade to GraalVM 22.0.2 +- There is now a docker image with a web-based desktop environment for XPipe at [https://github.com/xpipe-io/xpipe-webtop](https://github.com/xpipe-io/xpipe-webtop) + +## Fixes + +- Fix csh, opnsense, pfsense shells being broken +- Fix VM start/stop actions only being visible when user credentials were supplied +- Fix tunnels failing to start when the remote login shell was fish +- Fix dashlane password manager configuration being wrong +- Fix some shell sessions staying open in the background when closing connection creation dialog +- Fix SSH bridge not launching on Linux with missing sshd +- Fix browser transfer progress flickering +- Fix powershell type not being able to be recognized in certain language modes +- Fix Cygwin/Msys2/GitForWindows not showing up in connection search sometimes +- Fix some startup checks not working +- Fix scrollbar not resetting when changing application tabs +- Fix file modified dates and color names not being translated + +## Git vault improvements + +- Add more extensive documentation to the remote git repository settings menu +- Add restart button to the sync settings menu +- Improve git failure messages +- Fix git CLI check not working on macOS due to xcode-select +- Fix git sync failing when multiple gpg programs were present in PATH + +## Product hunt + +XPipe will be on ProductHunt on October 22. If you interested, you can follow XPipe at [https://www.producthunt.com/products/xpipe](https://www.producthunt.com/products/xpipe) to get notified. diff --git a/dist/changelogs/12.3.3_incremental.md b/dist/changelogs/12.3.3_incremental.md new file mode 100644 index 000000000..7275523ea --- /dev/null +++ b/dist/changelogs/12.3.3_incremental.md @@ -0,0 +1 @@ +This is a hotfix release for the [12.3 release](https://github.com/xpipe-io/xpipe/releases/tag/12.3) to work around a Windows Terminal bug that is affecting some systems where all terminal launches seem to fail with cmd. \ No newline at end of file diff --git a/version b/version index 1701b30e1..021d59961 100644 --- a/version +++ b/version @@ -1 +1 @@ -12.3.2 +12.3.3